feat(feedback)!: always reject sendFeedback with an Error

Previously, sendFeedback's async rejection paths (timeout, 403, generic
transport error) rejected with plain strings, while the sync-throw paths
used Error instances. Unify on Error for all paths so consumers can rely
on a consistent rejection shape.

BREAKING CHANGE: sendFeedback now always rejects with an Error whose
.message is the error code (ERROR_TIMEOUT, ERROR_FORBIDDEN, or
ERROR_GENERIC). Previously these paths rejected with the raw string.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

Author: logaretm

packages/feedback/src/core/sendFeedback.ts

@@ -1,7 +1,6 @@
 import type { Event, EventHint, SendFeedback, SendFeedbackParams, TransportMakeRequestResponse } from '@sentry/core';
 import { captureFeedback, getClient, getCurrentScope, getLocationHref } from '@sentry/core';
 import { FEEDBACK_API_SOURCE } from '../constants';
-import type { FeedbackErrorCode } from '../util/createFeedbackError';
 import { createFeedbackError } from '../util/createFeedbackError';
 
 /**
@@ -37,7 +36,7 @@ export const sendFeedback: SendFeedback = (
   // We want to wait for the feedback to be sent (or not)
   return new Promise<string>((resolve, reject) => {
     // After 30s, we want to clear anyhow
-    const timeout = setTimeout(() => reject('ERROR_TIMEOUT' satisfies FeedbackErrorCode), 30_000);
+    const timeout = setTimeout(() => reject(createFeedbackError('ERROR_TIMEOUT')), 30_000);
 
     const cleanup = client.on('afterSendEvent', (event: Event, response: TransportMakeRequestResponse) => {
       if (event.event_id !== eventId) {
@@ -53,10 +52,10 @@ export const sendFeedback: SendFeedback = (
       }
 
       if (response?.statusCode === 403) {
-        return reject('ERROR_FORBIDDEN' satisfies FeedbackErrorCode);
+        return reject(createFeedbackError('ERROR_FORBIDDEN'));
       }
 
-      return reject('ERROR_GENERIC' satisfies FeedbackErrorCode);
+      return reject(createFeedbackError('ERROR_GENERIC'));
     });
   });
 };

packages/feedback/src/modal/components/Form.tsx

@@ -145,7 +145,7 @@ export function Form({
           onSubmitSuccess(data, eventId);
         } catch (error) {
           DEBUG_BUILD && debug.error(error);
-          const err = error instanceof Error ? error : new Error(String(error));
+          const err = error as Error;
           setError(errorTextByCode[err.message as FeedbackErrorCode] || errorGenericText);
           onSubmitError(err);
         }

packages/feedback/test/core/sendFeedback.test.ts

@@ -279,7 +279,7 @@ describe('sendFeedback', () => {
         email: 're@example.org',
         message: 'mi',
       }),
-    ).rejects.toMatch('ERROR_GENERIC');
+    ).rejects.toThrow('ERROR_GENERIC');
   });
 
   it('handles 0 transport error', async () => {
@@ -294,7 +294,7 @@ describe('sendFeedback', () => {
         email: 're@example.org',
         message: 'mi',
       }),
-    ).rejects.toMatch('ERROR_GENERIC');
+    ).rejects.toThrow('ERROR_GENERIC');
   });
 
   it('handles 403 transport error', async () => {
@@ -309,7 +309,7 @@ describe('sendFeedback', () => {
         email: 're@example.org',
         message: 'mi',
       }),
-    ).rejects.toMatch('ERROR_FORBIDDEN');
+    ).rejects.toThrow('ERROR_FORBIDDEN');
   });
 
   it('handles 200 transport response', async () => {
@@ -343,7 +343,7 @@ describe('sendFeedback', () => {
 
     vi.advanceTimersByTime(30_000);
 
-    await expect(promise).rejects.toMatch('ERROR_TIMEOUT');
+    await expect(promise).rejects.toThrow('ERROR_TIMEOUT');
 
     vi.useRealTimers();
   });