Skip to content

Commit 06c1848

Browse files
Resolve review comments
1 parent cd24728 commit 06c1848

1 file changed

Lines changed: 10 additions & 13 deletions

File tree

src/main/java/com/google/firebase/remoteconfig/ParameterValue.java

Lines changed: 10 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@
1616

1717
package com.google.firebase.remoteconfig;
1818

19+
import static java.util.stream.Collectors.toList;
1920
import static com.google.common.base.Preconditions.checkNotNull;
2021

2122
import com.google.firebase.internal.NonNull;
@@ -106,12 +107,9 @@ static ParameterValue fromParameterValueResponse(
106107
}
107108
if (parameterValueResponse.getExperimentValue() != null) {
108109
ExperimentValueResponse ev = parameterValueResponse.getExperimentValue();
109-
List<ExperimentVariantValue> variantValues = new ArrayList<>();
110-
for (ExperimentVariantValueResponse evv : ev.getExperimentVariantValues()) {
111-
variantValues.add(
112-
new ExperimentVariantValue(evv.getVariantId(), evv.getValue(),
113-
evv.getNoChange()));
114-
}
110+
List<ExperimentVariantValue> variantValues = ev.getExperimentVariantValues().stream()
111+
.map(evv -> new ExperimentVariantValue(evv.getVariantId(), evv.getValue(), evv.getNoChange()))
112+
.collect(toList());
115113
return ParameterValue.ofExperiment(ev.getExperimentId(), variantValues);
116114
}
117115
return ParameterValue.of(parameterValueResponse.getValue());
@@ -368,13 +366,12 @@ public List<ExperimentVariantValue> getExperimentVariantValues() {
368366

369367
@Override
370368
ParameterValueResponse toParameterValueResponse() {
371-
List<ExperimentVariantValueResponse> variantValueResponses = new ArrayList<>();
372-
for (ExperimentVariantValue variantValue : variantValues) {
373-
variantValueResponses.add(new ExperimentVariantValueResponse()
374-
.setVariantId(variantValue.getVariantId())
375-
.setValue(variantValue.getValue())
376-
.setNoChange(variantValue.isNoChange()));
377-
}
369+
List<ExperimentVariantValueResponse> variantValueResponses = variantValues.stream()
370+
.map(variantValue -> new ExperimentVariantValueResponse()
371+
.setVariantId(variantValue.getVariantId())
372+
.setValue(variantValue.getValue())
373+
.setNoChange(variantValue.isNoChange()))
374+
.collect(toList());
378375
return new ParameterValueResponse().setExperimentValue(
379376
new ExperimentValueResponse()
380377
.setExperimentId(this.experimentId)

0 commit comments

Comments
 (0)