Open
Conversation
Fix "done" method of generators as before it would segfault in debug
mode when getting the next element when the iterator was finished.
$ cat test_iter.codon
b = [1, 2, 3]
d = iter(b)
print(min(d))
print(d.done())
print(min(d))
$ /software/exaloop/codon/codon-0.19.4/bin/codon run test_iter.codon
1
Segmentation fault (core dumped)
$ /software/exaloop/codon/codon-0.19.4_done_fix/bin/codon run test_iter.codon
1
True
ValueError: min() arg is an empty sequence
Raised from: std.internal.builtin.min.0:0
/software/exaloop/codon/codon-0.19.4_pipe/lib/codon/stdlib/internal/builtin.codon:83:13
Backtrace:
[0x7f9950a9986f] std.internal.builtin.min.0:0[Tuple[Generator[int]],Optional[NoneType],Optional[NoneType]].851 at /software/exaloop/codon/codon-0.19.4_pipe/lib/codon/stdlib/internal/builtin.codon:83:13
[0x7f9950a9e8d2] main.0 at /software/exaloop/codon/test_iter.codon:6:7
Aborted (core dumped)
Fixes: exaloop#246
Contributor
Author
|
@arshajii Can you take a look? |
Contributor
|
Sorry for the delay on this; just wanted to do some testing especially regarding LLVM's coroutine optimizations. Will circle back shortly... |
Contributor
|
Quick follow-up here: this actually changes semantics e.g. in def foo(n):
for i in range(n):
yield i
g = foo(3)
while not g.done():
print(g.__next__())Before: After: I'm thinking about actually getting rid of this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix "done" method of generators as before it would segfault in debug mode when getting the next element when the iterator was finished.
Fixes: #246