Fix __ptr__ issues

Author: inumanag

codon/parser/visitors/translate/translate.cpp

@@ -295,6 +295,7 @@ void TranslateVisitor::visit(CallExpr *expr) {
     auto pv = make<ir::PointerValue>(expr, val->getVar(), members);
     if (pre) {
       pre->setValue(pv);
+      result = pre;
     } else {
       result = pv;
     }

codon/parser/visitors/typecheck/special.cpp

@@ -503,29 +503,15 @@ Expr *TypecheckVisitor::transformPtr(CallExpr *expr) {
     auto t = extractClassType(head);
     if (!t)
       return nullptr;
-    if (!t->isRecord())
+    if (!last && !t->isRecord())
       E(Error::CALL_PTR_VAR, expr->begin()->getExpr());
 
     if (auto id = cast<IdExpr>(head)) {
       auto val = id ? ctx->find(id->getValue(), getTime()) : nullptr;
-      if (!val || !val->isVar()) {
+      if (!val || !val->isVar())
         E(Error::CALL_PTR_VAR, expr->begin()->getExpr());
-      }
       break;
     } else if (auto dot = cast<DotExpr>(head)) {
-      if (last && !t->isRecord()) {
-        E(Error::CALL_PTR_VAR, expr->begin()->getExpr());
-      } else if (!t->isRecord()) {
-        auto tmp = getTemporaryVar("ptr");
-        auto newDot = N<DotExpr>(N<IdExpr>(tmp), dot->getMember());
-        std::ranges::reverse(members);
-        for (auto &m : members)
-          newDot = N<DotExpr>(newDot, m);
-        return transform(N<StmtExpr>(
-            N<AssignStmt>(N<IdExpr>(tmp), dot->getExpr()),
-            N<CallExpr>(N<IdExpr>(getMangledFunc("std.internal.core", "__ptr__")),
-                        newDot)));
-      }
       head = dot->getExpr();
     } else {
       E(Error::CALL_PTR_VAR, expr->begin()->getExpr());

test/parser/typecheck/test_call.codon

@@ -62,9 +62,6 @@ print(x)  #: (b: (a: (n: 55)))
 #%% call_ptr_error,barebones
 __ptr__(1) #! __ptr__() only takes identifiers or tuple fields as arguments
 
-#%% call_ptr_error_2,barebones
-__ptr__([1]) #! __ptr__() only takes identifiers or tuple fields as arguments
-
 #%% call_ptr_error_3,barebones
 v = 1
 __ptr__(v, 1) #! __ptr__() takes 1 arguments (2 given)