Merge pull request #360 from erikdarlingdata/fix/ag-secondary-filter-v2

Fix AG secondary filter to skip all inaccessible databases

Author: erikdarlingdata

Lite/Services/RemoteCollectorService.QueryStore.cs

@@ -44,27 +44,18 @@ DECLARE db_check CURSOR LOCAL FAST_FORWARD FOR
     SELECT /* PerformanceMonitorLite */
         d.name
     FROM sys.databases AS d
+    LEFT JOIN sys.dm_hadr_database_replica_states AS drs
+        ON d.database_id = drs.database_id
+        AND drs.is_local = 1
     WHERE d.database_id > 4
     AND   d.database_id < 32761
     AND   d.state_desc = N'ONLINE'
     AND   d.name <> N'PerformanceMonitor'
-    AND   d.database_id NOT IN
-          (
-              SELECT
-                  d2.database_id
-              FROM sys.databases AS d2
-              JOIN sys.availability_replicas AS r
-                ON d2.replica_id = r.replica_id
-              WHERE NOT EXISTS
-                    (
-                        SELECT
-                            1/0
-                        FROM sys.dm_hadr_availability_group_states AS s
-                        WHERE s.primary_replica = r.replica_server_name
-                    )
-              AND   r.secondary_role_allow_connections_desc = N'READ_ONLY'
-              AND   r.replica_server_name = @@SERVERNAME
-          )
+    AND
+    (
+        drs.database_id IS NULL          /*not in any AG*/
+        OR drs.is_primary_replica = 1    /*primary replica*/
+    )
     OPTION(RECOMPILE);
 
 OPEN db_check;

Lite/Services/RemoteCollectorService.ServerConfig.cs

@@ -332,27 +332,18 @@ private async Task<int> CollectDatabaseScopedConfigAsync(ServerConnection server
 SELECT
     d.name
 FROM sys.databases AS d
+LEFT JOIN sys.dm_hadr_database_replica_states AS drs
+    ON d.database_id = drs.database_id
+    AND drs.is_local = 1
 WHERE (d.database_id > 4 OR d.database_id = 2)
 AND   d.database_id < 32761
 AND   d.name <> N'PerformanceMonitor'
 AND   d.state_desc = N'ONLINE'
-AND   d.database_id NOT IN
-      (
-          SELECT
-              d2.database_id
-          FROM sys.databases AS d2
-          JOIN sys.availability_replicas AS r
-            ON d2.replica_id = r.replica_id
-          WHERE NOT EXISTS
-                (
-                    SELECT
-                        1/0
-                    FROM sys.dm_hadr_availability_group_states AS s
-                    WHERE s.primary_replica = r.replica_server_name
-                )
-          AND   r.secondary_role_allow_connections_desc = N'READ_ONLY'
-          AND   r.replica_server_name = @@SERVERNAME
-      )
+AND
+(
+    drs.database_id IS NULL          /*not in any AG*/
+    OR drs.is_primary_replica = 1    /*primary replica*/
+)
 ORDER BY d.name
 OPTION(RECOMPILE);";
 

install/09_collect_query_store.sql

@@ -299,28 +299,19 @@ BEGIN
             SELECT
                 d.name
             FROM sys.databases AS d
+            LEFT JOIN sys.dm_hadr_database_replica_states AS drs
+                ON d.database_id = drs.database_id
+                AND drs.is_local = 1
             WHERE d.state_desc = N'ONLINE'
             AND   d.database_id > 4
             AND   d.is_read_only = 0
             AND   d.name <> N'PerformanceMonitor'
             AND   d.database_id < 32761 /*exclude contained AG system databases*/
-            AND   d.database_id NOT IN
-                  (
-                      SELECT
-                          d2.database_id
-                      FROM sys.databases AS d2
-                      JOIN sys.availability_replicas AS r
-                        ON d2.replica_id = r.replica_id
-                      WHERE NOT EXISTS
-                            (
-                                SELECT
-                                    1/0
-                                FROM sys.dm_hadr_availability_group_states AS s
-                                WHERE s.primary_replica = r.replica_server_name
-                            )
-                      AND   r.secondary_role_allow_connections_desc = N'READ_ONLY'
-                      AND   r.replica_server_name = @@SERVERNAME
-                  )
+            AND
+            (
+                drs.database_id IS NULL          /*not in any AG*/
+                OR drs.is_primary_replica = 1    /*primary replica*/
+            )
             OPTION(RECOMPILE);
 
         OPEN @db_check_cursor;

install/39_collect_database_configuration.sql

@@ -161,27 +161,18 @@ BEGIN
                 database_id = d.database_id,
                 database_name = d.name
             FROM sys.databases AS d
+            LEFT JOIN sys.dm_hadr_database_replica_states AS drs
+                ON d.database_id = drs.database_id
+                AND drs.is_local = 1
             WHERE d.database_id > 4
             AND   d.name != DB_NAME()
             AND   d.state_desc = N'ONLINE'
             AND   d.database_id < 32761 /*exclude contained AG system databases*/
-            AND   d.database_id NOT IN
-                  (
-                      SELECT
-                          d2.database_id
-                      FROM sys.databases AS d2
-                      JOIN sys.availability_replicas AS r
-                        ON d2.replica_id = r.replica_id
-                      WHERE NOT EXISTS
-                            (
-                                SELECT
-                                    1/0
-                                FROM sys.dm_hadr_availability_group_states AS s
-                                WHERE s.primary_replica = r.replica_server_name
-                            )
-                      AND   r.secondary_role_allow_connections_desc = N'READ_ONLY'
-                      AND   r.replica_server_name = @@SERVERNAME
-                  )
+            AND
+            (
+                drs.database_id IS NULL          /*not in any AG*/
+                OR drs.is_primary_replica = 1    /*primary replica*/
+            )
             ORDER BY
                 d.name
             OPTION (RECOMPILE);