Fix upgrade filter skipping patch versions (#817) (#819)

FilterUpgrades used `FromVersion >= current` which excluded upgrades
when the user was on a patch release (e.g., 2.4.1 skipped the
2.4.0-to-2.5.0 upgrade because 2.4.0 < 2.4.1). Changed to
`ToVersion > current` so any upgrade the user hasn't reached is
included. Adds regression test for the patch version scenario.

Fixes #817

Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Author: erikdarlingdata

Installer.Core/ScriptProvider.cs

@@ -152,7 +152,7 @@ protected static List<UpgradeInfo> FilterUpgrades(
 
         return candidates
             .Where(x => x.FromVersion != null && x.ToVersion != null)
-            .Where(x => x.FromVersion >= current)
+            .Where(x => x.ToVersion > current)
             .Where(x => x.ToVersion <= target)
             .OrderBy(x => x.FromVersion)
             .ToList();

Installer.Tests/UpgradeOrderingTests.cs

@@ -148,6 +148,23 @@ public void DoesNotIncludeFutureUpgrades()
         Assert.DoesNotContain(upgrades, u => u.FolderName == "2.2.0-to-2.3.0");
     }
 
+    [Fact]
+    public void PatchVersion_GetsUpgradeFromPriorMinor()
+    {
+        // Regression test for #817: user on v2.4.1 should still get the
+        // 2.4.0-to-2.5.0 upgrade applied (patch version within range)
+        using var dir = new TempDirectoryBuilder()
+            .WithUpgrade("2.3.0", "2.4.0", "01_a.sql")
+            .WithUpgrade("2.4.0", "2.5.0", "01_b.sql")
+            .WithUpgrade("2.5.0", "2.6.0", "01_c.sql");
+
+        var upgrades = ScriptProvider.FromDirectory(dir.RootPath).GetApplicableUpgrades("2.4.1", "2.6.0");
+
+        Assert.Equal(2, upgrades.Count);
+        Assert.Equal("2.4.0-to-2.5.0", upgrades[0].FolderName);
+        Assert.Equal("2.5.0-to-2.6.0", upgrades[1].FolderName);
+    }
+
     [Fact]
     public void EmbeddedResources_FindsUpgradeFolders()
     {