Merge pull request #343 from erikdarlingdata/fix/rule9-memory-grant-thresholds

erikdarlingdata · web-flow · commit 9928aa5ffd10 · 2026-02-27T06:15:02.000-05:00
Rule 9: Raise memory grant warning floor to 1GB
diff --git a/Dashboard/Services/PlanAnalyzer.cs b/Dashboard/Services/PlanAnalyzer.cs
@@ -75,7 +75,7 @@ private static void AnalyzeStatement(PlanStatement stmt)
             if (grant.GrantedMemoryKB > 0 && grant.MaxUsedMemoryKB > 0)
             {
                 var wasteRatio = (double)grant.GrantedMemoryKB / grant.MaxUsedMemoryKB;
-                if (wasteRatio >= 10 && grant.GrantedMemoryKB > 1024)
+                if (wasteRatio >= 10 && grant.GrantedMemoryKB >= 1048576)
                 {
                     stmt.PlanWarnings.Add(new PlanWarning
                     {
@@ -98,7 +98,7 @@ private static void AnalyzeStatement(PlanStatement stmt)
             }
 
             // Large memory grant with sort/hash guidance
-            if (grant.GrantedMemoryKB > 102400 && stmt.RootNode != null)
+            if (grant.GrantedMemoryKB >= 1048576 && stmt.RootNode != null)
             {
                 var consumers = new List<string>();
                 FindMemoryConsumers(stmt.RootNode, consumers);
@@ -112,7 +112,7 @@ private static void AnalyzeStatement(PlanStatement stmt)
                 {
                     WarningType = "Large Memory Grant",
                     Message = $"Query granted {grantMB:F0} MB of memory.{guidance}",
-                    Severity = grantMB >= 512 ? PlanWarningSeverity.Critical : PlanWarningSeverity.Warning
+                    Severity = grantMB >= 4096 ? PlanWarningSeverity.Critical : PlanWarningSeverity.Warning
                 });
             }
         }
diff --git a/Lite/Services/PlanAnalyzer.cs b/Lite/Services/PlanAnalyzer.cs
@@ -75,7 +75,7 @@ private static void AnalyzeStatement(PlanStatement stmt)
             if (grant.GrantedMemoryKB > 0 && grant.MaxUsedMemoryKB > 0)
             {
                 var wasteRatio = (double)grant.GrantedMemoryKB / grant.MaxUsedMemoryKB;
-                if (wasteRatio >= 10 && grant.GrantedMemoryKB > 1024)
+                if (wasteRatio >= 10 && grant.GrantedMemoryKB >= 1048576)
                 {
                     stmt.PlanWarnings.Add(new PlanWarning
                     {
@@ -98,7 +98,7 @@ private static void AnalyzeStatement(PlanStatement stmt)
             }
 
             // Large memory grant with sort/hash guidance
-            if (grant.GrantedMemoryKB > 102400 && stmt.RootNode != null)
+            if (grant.GrantedMemoryKB >= 1048576 && stmt.RootNode != null)
             {
                 var consumers = new List<string>();
                 FindMemoryConsumers(stmt.RootNode, consumers);
@@ -112,7 +112,7 @@ private static void AnalyzeStatement(PlanStatement stmt)
                 {
                     WarningType = "Large Memory Grant",
                     Message = $"Query granted {grantMB:F0} MB of memory.{guidance}",
-                    Severity = grantMB >= 512 ? PlanWarningSeverity.Critical : PlanWarningSeverity.Warning
+                    Severity = grantMB >= 4096 ? PlanWarningSeverity.Critical : PlanWarningSeverity.Warning
                 });
             }
         }

Original file line number	Diff line number	Diff line change
`@@ -75,7 +75,7 @@ private static void AnalyzeStatement(PlanStatement stmt)`
`75`	`75`	`if (grant.GrantedMemoryKB > 0 && grant.MaxUsedMemoryKB > 0)`
`76`	`76`	`{`
`77`	`77`	`var wasteRatio = (double)grant.GrantedMemoryKB / grant.MaxUsedMemoryKB;`
`78`		`- if (wasteRatio >= 10 && grant.GrantedMemoryKB > 1024)`
	`78`	`+ if (wasteRatio >= 10 && grant.GrantedMemoryKB >= 1048576)`
`79`	`79`	`{`
`80`	`80`	`stmt.PlanWarnings.Add(new PlanWarning`
`81`	`81`	`{`
`@@ -98,7 +98,7 @@ private static void AnalyzeStatement(PlanStatement stmt)`
`98`	`98`	`}`
`99`	`99`
`100`	`100`	`// Large memory grant with sort/hash guidance`
`101`		`- if (grant.GrantedMemoryKB > 102400 && stmt.RootNode != null)`
	`101`	`+ if (grant.GrantedMemoryKB >= 1048576 && stmt.RootNode != null)`
`102`	`102`	`{`
`103`	`103`	`var consumers = new List<string>();`
`104`	`104`	`FindMemoryConsumers(stmt.RootNode, consumers);`
`@@ -112,7 +112,7 @@ private static void AnalyzeStatement(PlanStatement stmt)`
`112`	`112`	`{`
`113`	`113`	`WarningType = "Large Memory Grant",`
`114`	`114`	`Message = $"Query granted {grantMB:F0} MB of memory.{guidance}",`
`115`		`- Severity = grantMB >= 512 ? PlanWarningSeverity.Critical : PlanWarningSeverity.Warning`
	`115`	`+ Severity = grantMB >= 4096 ? PlanWarningSeverity.Critical : PlanWarningSeverity.Warning`
`116`	`116`	`});`
`117`	`117`	`}`
`118`	`118`	`}`