Skip to content

Commit 43e8d3b

Browse files
Merge pull request #312 from erikdarlingdata/dev
v2.0.0 hotfix: query store regressions, context menu icons, Entra MFA auth
2 parents f980b91 + 059a829 commit 43e8d3b

24 files changed

Lines changed: 759 additions & 236 deletions

Dashboard/AddServerDialog.xaml

Lines changed: 34 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,7 @@
2626
<RowDefinition Height="Auto"/>
2727
<RowDefinition Height="*"/>
2828
<RowDefinition Height="Auto"/>
29+
<RowDefinition Height="Auto"/>
2930
</Grid.RowDefinitions>
3031

3132
<!-- Header -->
@@ -50,29 +51,40 @@
5051
<!-- Authentication Type -->
5152
<TextBlock Text="Authentication:" FontWeight="Bold" Margin="0,0,0,5"
5253
Foreground="{DynamicResource ForegroundBrush}"/>
53-
<StackPanel Orientation="Horizontal" Margin="0,0,0,15">
54+
<StackPanel Margin="0,0,0,15">
5455
<RadioButton x:Name="WindowsAuthRadio" Content="Windows Authentication"
5556
GroupName="Auth" IsChecked="True"
5657
Foreground="{DynamicResource ForegroundBrush}"
57-
Checked="AuthType_Changed" Margin="0,0,20,0"/>
58+
Checked="AuthType_Changed" Margin="0,0,0,4"/>
5859
<RadioButton x:Name="SqlAuthRadio" Content="SQL Server Authentication"
5960
GroupName="Auth"
6061
Foreground="{DynamicResource ForegroundBrush}"
61-
Checked="AuthType_Changed"/>
62+
Checked="AuthType_Changed" Margin="0,0,0,4"/>
63+
<RadioButton x:Name="EntraMfaAuthRadio" Content="Microsoft Entra MFA"
64+
GroupName="Auth"
65+
Foreground="{DynamicResource ForegroundBrush}"
66+
Checked="AuthType_Changed"
67+
ToolTip="Interactive authentication with MFA for Azure SQL Database."/>
6268
</StackPanel>
6369

64-
<!-- SQL Authentication Fields (initially disabled) -->
65-
<Border x:Name="SqlAuthPanel" IsEnabled="False">
66-
<StackPanel>
67-
<TextBlock Text="Username:" FontWeight="Bold" Margin="0,0,0,5"
68-
Foreground="{DynamicResource ForegroundBrush}"/>
69-
<TextBox x:Name="UsernameTextBox" Height="25" Margin="0,0,0,15"/>
70+
<!-- SQL Authentication Fields -->
71+
<StackPanel x:Name="SqlAuthPanel" Visibility="Collapsed" Margin="0,0,0,15">
72+
<TextBlock Text="Username:" FontWeight="Bold" Margin="0,0,0,5"
73+
Foreground="{DynamicResource ForegroundBrush}"/>
74+
<TextBox x:Name="UsernameTextBox" Height="25" Margin="0,0,0,15"/>
7075

71-
<TextBlock Text="Password:" FontWeight="Bold" Margin="0,0,0,5"
72-
Foreground="{DynamicResource ForegroundBrush}"/>
73-
<PasswordBox x:Name="PasswordBox" Height="25" Margin="0,0,0,15"/>
74-
</StackPanel>
75-
</Border>
76+
<TextBlock Text="Password:" FontWeight="Bold" Margin="0,0,0,5"
77+
Foreground="{DynamicResource ForegroundBrush}"/>
78+
<PasswordBox x:Name="PasswordBox" Height="25" Margin="0,0,0,0"/>
79+
</StackPanel>
80+
81+
<!-- Microsoft Entra MFA Fields -->
82+
<StackPanel x:Name="EntraMfaPanel" Visibility="Collapsed" Margin="0,0,0,15">
83+
<TextBlock Text="Username (optional):" FontWeight="Bold" Margin="0,0,0,5"
84+
Foreground="{DynamicResource ForegroundBrush}"/>
85+
<TextBox x:Name="EntraMfaUsernameBox" Height="25" Margin="0,0,0,0"
86+
ToolTip="Optional: Pre-populate the authentication dialog with this email address"/>
87+
</StackPanel>
7688

7789
<!-- Description -->
7890
<TextBlock Text="Description (optional):" FontWeight="Bold" Margin="0,0,0,5"
@@ -114,10 +126,15 @@
114126
</StackPanel>
115127
</ScrollViewer>
116128

129+
<!-- Status -->
130+
<TextBlock x:Name="StatusText" Grid.Row="2"
131+
Foreground="{DynamicResource ForegroundMutedBrush}"
132+
TextWrapping="Wrap" Margin="0,8,0,0" Visibility="Collapsed"/>
133+
117134
<!-- Buttons -->
118-
<StackPanel Grid.Row="2" Orientation="Horizontal" HorizontalAlignment="Right" Margin="0,15,0,0">
119-
<Button Content="Test Connection" Width="120" Height="30" Margin="0,0,10,0" Click="TestConnection_Click"/>
120-
<Button Content="Save" Width="80" Height="30" Margin="0,0,10,0" Click="Save_Click" IsDefault="True"/>
135+
<StackPanel Grid.Row="3" Orientation="Horizontal" HorizontalAlignment="Right" Margin="0,15,0,0">
136+
<Button x:Name="TestConnectionButton" Content="Test Connection" Width="120" Height="30" Margin="0,0,10,0" Click="TestConnection_Click"/>
137+
<Button x:Name="SaveButton" Content="Save" Width="80" Height="30" Margin="0,0,10,0" Click="Save_Click" IsDefault="True"/>
121138
<Button Content="Cancel" Width="80" Height="30" Click="Cancel_Click" IsCancel="True"/>
122139
</StackPanel>
123140
</Grid>

0 commit comments

Comments
 (0)