chore: format three IF blocks

Author: mattcargile

sp_HumanEvents/sp_HumanEvents.sql

@@ -515,7 +515,19 @@ DECLARE
     @drop_holder nvarchar(max) = N'',
     @cleanup_views nvarchar(max) = N'',
     @nc10 nvarchar(2) = NCHAR(10),
-    @inputbuf_bom nvarchar(1) = CONVERT(nvarchar(1), 0x0a00, 0);
+    @inputbuf_bom nvarchar(1) = CONVERT(nvarchar(1), 0x0a00, 0),
+    @wait_event_type_pattern nvarchar(6) = N'%wait%',
+    @lock_event_type_pattern nvarchar(6) = N'%lock%',
+    @query_event_type_pattern nvarchar(6) = N'%quer%',
+    @compile_event_type_pattern nvarchar(6) = N'%comp%',
+    @recompile_exclude_event_type_pattern nvarchar(4) = N'%re%',
+    @recompile_event_type_pattern nvarchar(8) = N'%recomp%',
+    @is_wait_event_type bit = 0,
+    @is_lock_event_type bit = 0,
+    @is_query_event_type bit = 0,
+    @is_compile_event_type bit = 0,
+    @is_compile_any_event_type bit = 0,
+    @is_recompile_event_type bit = 0;
 
 /*check to make sure we're on a usable version*/
 IF
@@ -854,6 +866,18 @@ What on earth is %s?', 11, 1, @event_type) WITH NOWAIT;
     RETURN;
 END;
 
+SELECT
+    @is_lock_event_type           = CASE WHEN @event_type LIKE @lock_event_type_pattern THEN 1 ELSE 0 END,
+    @is_query_event_type          = CASE WHEN @event_type LIKE @query_event_type_pattern THEN 1 ELSE 0 END,
+    @is_recompile_event_type      = CASE WHEN @event_type LIKE @recompile_event_type_pattern THEN 1 ELSE 0 END,
+    @is_compile_any_event_type    = CASE WHEN @event_type LIKE @compile_event_type_pattern THEN 1 ELSE 0 END,
+    @is_wait_event_type           = CASE WHEN @event_type LIKE @wait_event_type_pattern THEN 1 ELSE 0 END,
+    @is_compile_event_type        = CASE
+                                        WHEN @event_type LIKE @compile_event_type_pattern
+                                             AND @event_type NOT LIKE @recompile_exclude_event_type_pattern THEN 1
+                                        ELSE 0
+                                    END;
+
 
 IF @debug = 1 BEGIN RAISERROR(N'Checking query sort order', 0, 1) WITH NOWAIT; END;
 IF @query_sort_order NOT IN
@@ -984,7 +1008,7 @@ IF
 (
         @wait_type <> N''
     AND @wait_type <> N'ALL'
-    AND LOWER(@event_type) NOT LIKE N'%wait%'
+    AND @is_wait_event_type = 0
 )
 BEGIN
     RAISERROR(N'You can''t filter on wait stats unless you use the wait stats event.', 11, 1) WITH NOWAIT;
@@ -998,7 +1022,7 @@ IF @debug = 1 BEGIN RAISERROR(N'Are we trying to filter for a blocking session?'
 /* blocking events need a database name to resolve objects */
 IF
 (
-        LOWER(@event_type) LIKE N'%lock%'
+        @is_lock_event_type = 1
     AND DB_ID(@database_name) IS NULL
     AND @object_name <> N''
 )
@@ -1010,7 +1034,7 @@ END;
 /* but could we resolve the object name? */
 IF
 (
-        LOWER(@event_type) LIKE N'%lock%'
+        @is_lock_event_type = 1
     AND @object_name <> N''
     AND OBJECT_ID(@fully_formed_babby) IS NULL
 )
@@ -1021,7 +1045,7 @@ END;
 
 /* no blocked process report, no love */
 IF @debug = 1 BEGIN RAISERROR(N'Validating if the Blocked Process Report is on, if the session is for blocking', 0, 1) WITH NOWAIT; END;
-IF @event_type LIKE N'%lock%'
+IF @is_lock_event_type = 1
 AND EXISTS
 (
     SELECT
@@ -1165,10 +1189,13 @@ END;
 IF @debug = 1 BEGIN RAISERROR(N'Is output database OR schema filled in?', 0, 1) WITH NOWAIT; END;
 IF
 (
-     LEN(@output_database_name + @output_schema_name) > 0
-    AND  @output_schema_name <> N'dbo'
-    AND (@output_database_name  = N''
-    OR   @output_schema_name = N'')
+        LEN(@output_database_name + @output_schema_name) > 0
+    AND @output_schema_name <> N'dbo'
+    AND
+    (
+           @output_database_name = N''
+        OR @output_schema_name   = N''
+    )
 )
 BEGIN
     IF @output_database_name = N''
@@ -1189,8 +1216,8 @@ END;
 IF @debug = 1 BEGIN RAISERROR(N'Is custom name something stupid?', 0, 1) WITH NOWAIT; END;
 IF
 (
-    PATINDEX(N'%[^a-zA-Z0-9]%', @custom_name) > 0
-      OR @custom_name LIKE N'[0-9]%'
+       PATINDEX(N'%[^a-zA-Z0-9]%', @custom_name) > 0
+    OR @custom_name LIKE N'[0-9]%'
 )
 BEGIN
     RAISERROR(N'
@@ -1234,7 +1261,7 @@ END;
 IF @debug = 1 BEGIN RAISERROR(N'Setting up individual filters', 0, 1) WITH NOWAIT; END;
 IF @query_duration_ms > 0
 BEGIN
-    IF LOWER(@event_type) NOT LIKE N'%comp%' /* compile and recompile durations are tiny */
+    IF @is_compile_any_event_type <> 0 /* compile and recompile durations are tiny */
     BEGIN
         SET @query_duration_filter += N'     AND duration >= ' + CONVERT(nvarchar(20), (@query_duration_ms * 1000)) + @nc10;
     END;
@@ -1291,12 +1318,12 @@ END;
 
 IF @object_name <> N''
 BEGIN
-    IF @event_type LIKE N'%lock%'
+    IF @is_lock_event_type = 1
     BEGIN
         SET @object_id = OBJECT_ID(@fully_formed_babby);
         SET @object_name_filter += N'     AND object_id = ' + @object_id + @nc10;
     END;
-    IF @event_type NOT LIKE N'%lock%'
+    IF @is_lock_event_type = 0
     BEGIN
         SET @object_name_filter += N'     AND object_name = N' + QUOTENAME(@object_name, N'''') + @nc10;
     END;
@@ -1311,7 +1338,7 @@ END;
 
 /* At this point we'll either put my list of interesting waits in a temp table,
    or a list of user defined waits */
-IF LOWER(@event_type) LIKE N'%wait%'
+IF @is_wait_event_type = 1
 BEGIN
     INSERT
         #wait WITH(TABLOCK)
@@ -1571,11 +1598,11 @@ SET @session_filter_parameterization +=
 IF @debug = 1 BEGIN RAISERROR(N'Setting up the event session', 0, 1) WITH NOWAIT; END;
 SET @session_sql +=
         CASE
-            WHEN LOWER(@event_type) LIKE N'%lock%'
+            WHEN @is_lock_event_type = 1
             THEN N'
       ADD EVENT sqlserver.blocked_process_report
         (WHERE ( ' + @session_filter_blocking + N' ))'
-            WHEN LOWER(@event_type) LIKE N'%quer%'
+            WHEN @is_query_event_type = 1
             THEN N'
       ADD EVENT sqlserver.module_end
         (SET collect_statement = 1
@@ -1602,21 +1629,21 @@ SET @session_sql +=
          WHERE ( ' + @session_filter_query_plans + N' ))'
                          ELSE N''
                      END
-            WHEN LOWER(@event_type) LIKE N'%wait%'
+            WHEN @is_wait_event_type = 1
             AND  @v > 11
             THEN N'
       ADD EVENT sqlos.wait_completed
         (SET collect_wait_resource = 1
          ACTION (sqlserver.database_name, sqlserver.plan_handle, sqlserver.query_hash_signed, sqlserver.query_plan_hash_signed)
          WHERE ( ' + @session_filter_waits + N' ))'
-            WHEN LOWER(@event_type) LIKE N'%wait%'
+            WHEN @is_wait_event_type = 1
             AND  @v = 11
             THEN N'
       ADD EVENT sqlos.wait_info
         (
          ACTION (sqlserver.database_name, sqlserver.plan_handle, sqlserver.query_hash_signed, sqlserver.query_plan_hash_signed)
          WHERE ( ' + @session_filter_waits + N' ))'
-            WHEN LOWER(@event_type) LIKE N'%recomp%'
+            WHEN @is_recompile_event_type = 1
             THEN CASE
                      WHEN @compile_events = 1
                      THEN N'
@@ -1630,8 +1657,7 @@ SET @session_sql +=
          ACTION(sqlserver.database_name)
          WHERE ( ' + @session_filter_recompile + N' ))'
                  END
-            WHEN (LOWER(@event_type) LIKE N'%comp%'
-            AND   LOWER(@event_type) NOT LIKE N'%re%')
+            WHEN @is_compile_event_type = 1
             THEN CASE
                      WHEN @compile_events = 1
                      THEN N'
@@ -1674,9 +1700,12 @@ IF @debug = 1 BEGIN RAISERROR(@start_sql, 0, 1) WITH NOWAIT; END;
 EXECUTE (@start_sql);
 
 /* bail out here if we want to keep the session and not log to tables*/
-IF  @keep_alive = 1
-AND @output_database_name = N''
-AND @output_schema_name IN (N'', N'dbo')
+IF
+(
+        @keep_alive = 1
+    AND @output_database_name = N''
+    AND @output_schema_name IN (N'', N'dbo')
+)
 BEGIN
     IF @debug = 1
     BEGIN
@@ -1784,7 +1813,7 @@ END;
 /*
 This is where magic will happen
 */
-IF LOWER(@event_type) LIKE N'%quer%'
+IF @is_query_event_type = 1
 BEGIN
     WITH
         queries AS
@@ -2137,7 +2166,7 @@ BEGIN
 END;
 
 
-IF LOWER(@event_type) LIKE N'%comp%' AND LOWER(@event_type) NOT LIKE N'%re%'
+IF @is_compile_event_type = 1
 BEGIN
     IF @compile_events = 1
     BEGIN
@@ -2389,7 +2418,7 @@ BEGIN
     END;
 END;
 
-IF LOWER(@event_type) LIKE N'%recomp%'
+IF @is_recompile_event_type = 1
 BEGIN
 IF @compile_events = 1
     BEGIN
@@ -2548,7 +2577,7 @@ IF @compile_events = 1
 END;
 
 
-IF LOWER(@event_type) LIKE N'%wait%'
+IF @is_wait_event_type = 1
 BEGIN
     WITH
         waits AS
@@ -2700,7 +2729,7 @@ BEGIN
 END;
 
 
-IF LOWER(@event_type) LIKE N'%lock%'
+IF @is_lock_event_type = 1
 BEGIN
     SELECT
         event_time =
@@ -3626,16 +3655,16 @@ BEGIN
         SET
             hew.event_type_short =
                 CASE
-                    WHEN hew.event_type LIKE N'%block%'
+                    WHEN hew.event_type LIKE @lock_event_type_pattern
                     THEN N'[_]Blocking'
-                    WHEN ( hew.event_type LIKE N'%comp%'
-                             AND hew.event_type NOT LIKE N'%re%' )
+                    WHEN ( hew.event_type LIKE @compile_event_type_pattern
+                             AND hew.event_type NOT LIKE @recompile_exclude_event_type_pattern )
                     THEN N'[_]Compiles'
-                    WHEN hew.event_type LIKE N'%quer%'
+                    WHEN hew.event_type LIKE @query_event_type_pattern
                     THEN N'[_]Queries'
-                    WHEN hew.event_type LIKE N'%recomp%'
+                    WHEN hew.event_type LIKE @recompile_event_type_pattern
                     THEN N'[_]Recompiles'
-                    WHEN hew.event_type LIKE N'%wait%'
+                    WHEN hew.event_type LIKE @wait_event_type_pattern
                     THEN N'[_]Waits'
                     ELSE N'?'
                 END
@@ -3687,20 +3716,20 @@ BEGIN
                 SELECT
                     @table_sql =
                         CASE
-                            WHEN @event_type_check LIKE N'%wait%'
+                            WHEN @event_type_check LIKE @wait_event_type_pattern
                             THEN N'CREATE TABLE ' + @object_name_check + @nc10 +
                                  N'( id bigint PRIMARY KEY IDENTITY, server_name sysname NULL, event_time datetime2 NULL, event_type sysname NULL,  ' + @nc10 +
                                  N'  database_name sysname NULL, wait_type nvarchar(60) NULL, duration_ms bigint NULL, signal_duration_ms bigint NULL, ' + @nc10 +
                                  N'  wait_resource sysname NULL, query_plan_hash_signed binary(8) NULL, query_hash_signed binary(8) NULL, plan_handle varbinary(64) NULL );'
-                            WHEN @event_type_check LIKE N'%lock%'
+                            WHEN @event_type_check LIKE @lock_event_type_pattern
                             THEN N'CREATE TABLE ' + @object_name_check + @nc10 +
                                  N'( id bigint PRIMARY KEY IDENTITY, server_name sysname NULL, event_time datetime2 NULL, ' + @nc10 +
                                  N'  activity nvarchar(20) NULL, database_name sysname NULL, database_id integer NULL, object_id bigint NULL, contentious_object AS OBJECT_NAME(object_id, database_id), ' + @nc10 +
                                  N'  transaction_id bigint NULL, resource_owner_type sysname NULL, monitor_loop integer NULL, spid integer NULL, ecid integer NULL, query_text nvarchar(max) NULL, ' +
                                  N'  wait_time bigint NULL, transaction_name sysname NULL, last_transaction_started nvarchar(30) NULL, wait_resource nvarchar(100) NULL, ' + @nc10 +
                                  N'  lock_mode nvarchar(10) NULL, status nvarchar(10) NULL, priority integer NULL, transaction_count integer NULL, ' + @nc10 +
                                  N'  client_app sysname NULL, host_name sysname NULL, login_name sysname NULL, isolation_level nvarchar(30) NULL, sql_handle varbinary(64) NULL, blocked_process_report XML NULL );'
-                            WHEN @event_type_check LIKE N'%quer%'
+                            WHEN @event_type_check LIKE @query_event_type_pattern
                             THEN N'CREATE TABLE ' + @object_name_check + @nc10 +
                                  N'( id bigint PRIMARY KEY IDENTITY, server_name sysname NULL, event_time datetime2 NULL, event_type sysname NULL, ' + @nc10 +
                                  N'  database_name sysname NULL, object_name nvarchar(512) NULL, sql_text nvarchar(max) NULL, statement nvarchar(max) NULL, ' + @nc10 +
@@ -3709,12 +3738,12 @@ BEGIN
                                  N'  spills_mb decimal(18,2) NULL, row_count decimal(18,2) NULL, estimated_rows decimal(18,2) NULL, dop integer NULL,  ' + @nc10 +
                                  N'  serial_ideal_memory_mb decimal(18,2) NULL, requested_memory_mb decimal(18,2) NULL, used_memory_mb decimal(18,2) NULL, ideal_memory_mb decimal(18,2) NULL, ' + @nc10 +
                                  N'  granted_memory_mb decimal(18,2) NULL, query_plan_hash_signed binary(8) NULL, query_hash_signed binary(8) NULL, plan_handle varbinary(64) NULL );'
-                            WHEN @event_type_check LIKE N'%recomp%'
+                            WHEN @event_type_check LIKE @recompile_event_type_pattern
                             THEN N'CREATE TABLE ' + @object_name_check + @nc10 +
                                  N'( id bigint PRIMARY KEY IDENTITY, server_name sysname NULL, event_time datetime2 NULL, event_type sysname NULL,  ' + @nc10 +
                                  N'  database_name sysname NULL, object_name nvarchar(512) NULL, recompile_cause sysname NULL, statement_text nvarchar(max) NULL, statement_text_checksum AS CHECKSUM(database_name + statement_text) PERSISTED '
                                  + CASE WHEN @compile_events = 1 THEN N', compile_cpu_ms bigint NULL, compile_duration_ms bigint NULL );' ELSE N' );' END
-                            WHEN @event_type_check LIKE N'%comp%' AND @event_type_check NOT LIKE N'%re%'
+                            WHEN @event_type_check LIKE @compile_event_type_pattern AND @event_type_check NOT LIKE @recompile_exclude_event_type_pattern
                             THEN N'CREATE TABLE ' + @object_name_check + @nc10 +
                                  N'( id bigint PRIMARY KEY IDENTITY, server_name sysname NULL, event_time datetime2 NULL, event_type sysname NULL,  ' + @nc10 +
                                  N'  database_name sysname NULL, object_name nvarchar(512) NULL, statement_text nvarchar(max) NULL, statement_text_checksum AS CHECKSUM(database_name + statement_text) PERSISTED '
@@ -4052,7 +4081,7 @@ END;
                                  (
                                      nvarchar(max),
                         CASE
-                        WHEN @event_type_check LIKE N'%wait%' /*Wait stats!*/
+                        WHEN @event_type_check LIKE @wait_event_type_pattern /*Wait stats!*/
                         THEN CONVERT
                              (
                                  nvarchar(max),
@@ -4104,9 +4133,9 @@ OUTER APPLY xet.human_events_xml.nodes(''//event'') AS oa(c)
 WHERE c.exist(''(data[@name="duration"]/value/text()[. > 0])'') = 1
 AND   c.exist(''@timestamp[. > sql:variable("@date_filter")]'') = 1;')
                              )
-                        WHEN @event_type_check LIKE N'%lock%' /*Blocking!*/
-                                                              /*To cut down on nonsense, I'm only inserting new blocking scenarios*/
-                                                              /*Any existing blocking scenarios will update the blocking duration*/
+                        WHEN @event_type_check LIKE @lock_event_type_pattern /*Blocking!*/
+                                                                             /*To cut down on nonsense, I'm only inserting new blocking scenarios*/
+                                                                             /*Any existing blocking scenarios will update the blocking duration*/
                         THEN CONVERT
                              (
                                  nvarchar(max),
@@ -4283,7 +4312,7 @@ JOIN
     AND   x.hostname = x2.host_name
     AND   x.loginname = x2.login_name;
 '                                ))
-                       WHEN @event_type_check LIKE N'%quer%' /*Queries!*/
+                       WHEN @event_type_check LIKE @query_event_type_pattern /*Queries!*/
                        THEN
                             CONVERT
                             (
@@ -4346,7 +4375,7 @@ OUTER APPLY xet.human_events_xml.nodes(''//event'') AS oa(c)
 WHERE oa.c.exist(''@timestamp[. > sql:variable("@date_filter")]'') = 1
 AND   oa.c.exist(''(action[@name="query_hash_signed"]/value[. != 0])'') = 1; '
                             ))
-                       WHEN @event_type_check LIKE N'%recomp%' /*Recompiles!*/
+                       WHEN @event_type_check LIKE @recompile_event_type_pattern /*Recompiles!*/
                        THEN
                             CONVERT
                             (
@@ -4393,7 +4422,7 @@ AND oa.c.exist(''@timestamp[. > sql:variable("@date_filter")]'') = 1
 ORDER BY
     event_time;'
                             )))
-                       WHEN @event_type_check LIKE N'%comp%' AND @event_type_check NOT LIKE N'%re%' /*Compiles!*/
+                       WHEN @event_type_check LIKE @compile_event_type_pattern AND @event_type_check NOT LIKE @recompile_exclude_event_type_pattern /*Compiles!*/
                        THEN
                             CONVERT
                             (