Merge pull request #748 from erikdarlingdata/dev

Merge dev to main: sp_QuickieCache fixes

Author: erikdarlingdata

sp_QuickieCache/sp_QuickieCache.sql

@@ -12,6 +12,7 @@ ALTER PROCEDURE
     dbo.sp_QuickieCache
 (
     @top integer = 10, /*candidates per metric dimension before dedup*/
+    @sort_order varchar(20) = 'cpu', /*secondary sort after impact_score: cpu, duration, reads, writes, memory, spills, executions*/
     @database_name sysname = NULL, /*filter to a specific database*/
     @start_date datetime = NULL, /*only include plans created after this date*/
     @end_date datetime = NULL, /*only include plans created before this date*/
@@ -69,6 +70,8 @@ BEGIN
                 CASE ap.name
                     WHEN N'@top'
                     THEN N'Number of candidate queries per metric dimension (cpu, reads, etc.) before dedup. Default: 10.'
+                    WHEN N'@sort_order'
+                    THEN N'Secondary sort after impact_score. Options: cpu, duration, reads, writes, memory, spills, executions. Default: cpu.'
                     WHEN N'@database_name'
                     THEN N'Filter to a specific database. Default: NULL (all user databases).'
                     WHEN N'@start_date'
@@ -183,6 +186,19 @@ BEGIN
         RETURN;
     END;
 
+    SELECT
+        @sort_order = LOWER(LTRIM(RTRIM(@sort_order)));
+
+    IF @sort_order NOT IN
+       (
+           'cpu', 'duration', 'reads', 'writes',
+           'memory', 'spills', 'executions'
+       )
+    BEGIN
+        RAISERROR(N'@sort_order must be one of: cpu, duration, reads, writes, memory, spills, executions.', 16, 1) WITH NOWAIT;
+        RETURN;
+    END;
+
     /*
     ╔══════════════════════════════════════════════════╗
     ║  Plan cache health analysis                      ║
@@ -248,6 +264,15 @@ BEGIN
             ),
         @oldest_plan_date = MIN(qs.creation_time)
     FROM sys.dm_exec_query_stats AS qs
+    CROSS APPLY
+    (
+        SELECT TOP (1)
+            value = pa.value
+        FROM sys.dm_exec_plan_attributes(qs.plan_handle) AS pa
+        WHERE pa.attribute = N'dbid'
+    ) AS pa
+    WHERE 1 = 1
+    AND   (@database_id IS NULL OR pa.value = @database_id)
     OPTION(RECOMPILE);
 
     IF @total_plans > 0
@@ -387,6 +412,7 @@ BEGIN
         WHERE pa.value IS NOT NULL
         AND   CONVERT(integer, pa.value) NOT IN (1, 2, 3, 4)
         AND   CONVERT(integer, pa.value) < 32761
+        AND   (@database_id IS NULL OR CONVERT(integer, pa.value) = @database_id)
         GROUP BY
             pa.value
     ) AS x
@@ -413,7 +439,15 @@ BEGIN
         SELECT
             plan_count = COUNT_BIG(*)
         FROM sys.dm_exec_query_stats AS qs
+        CROSS APPLY
+        (
+            SELECT TOP (1)
+                value = pa.value
+            FROM sys.dm_exec_plan_attributes(qs.plan_handle) AS pa
+            WHERE pa.attribute = N'dbid'
+        ) AS pa
         WHERE qs.query_hash <> 0x0000000000000000
+        AND   (@database_id IS NULL OR CONVERT(integer, pa.value) = @database_id)
         GROUP BY
             qs.query_hash
         HAVING
@@ -487,6 +521,7 @@ BEGIN
         WHERE pa.value IS NOT NULL
         AND   CONVERT(integer, pa.value) NOT IN (1, 2, 3, 4)
         AND   CONVERT(integer, pa.value) < 32761
+        AND   (@database_id IS NULL OR CONVERT(integer, pa.value) = @database_id)
         GROUP BY
             pa.value
         ORDER BY
@@ -1921,7 +1956,16 @@ OPTION(RECOMPILE, MAXDOP 1);';
     ) AS qp
     WHERE s.impact_score >= @impact_threshold
     ORDER BY
-        s.impact_score DESC
+        s.impact_score DESC,
+        CASE @sort_order
+            WHEN 'cpu'        THEN s.cpu_share
+            WHEN 'duration'   THEN s.duration_share
+            WHEN 'reads'      THEN s.reads_share
+            WHEN 'writes'     THEN s.writes_share
+            WHEN 'memory'     THEN s.grant_share
+            WHEN 'spills'     THEN s.spills_share
+            WHEN 'executions' THEN s.executions_share
+        END DESC
     OPTION(RECOMPILE);
 
     /*