Skip to content

Commit caa67d2

Browse files
sp_QuickieStore: clarify reads as physical reads in @find_high_impact output
Renamed reads_share to physical_reads_share, and updated high_signals and volatile_metrics to say "physical reads" instead of just "reads" to avoid confusion with logical reads. Also updated help text. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
1 parent 22dc54f commit caa67d2

1 file changed

Lines changed: 7 additions & 6 deletions

File tree

sp_QuickieStore/sp_QuickieStore.sql

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -407,10 +407,10 @@ BEGIN
407407
SELECT 'impact_score: 0.00 to 1.00. The average PERCENT_RANK across all active resource dimensions.' UNION ALL
408408
SELECT ' 0.90 means this query outranks 90% of all queries in the database on the metrics where it registers.' UNION ALL
409409
SELECT ' Only queries scoring >= 0.50 are shown. A dimension is "active" when the query accounts for >= 0.1% of the total.' UNION ALL
410-
SELECT 'high_signals: which dimensions scored above the 80th percentile (e.g. "cpu, duration, reads")' UNION ALL
410+
SELECT 'high_signals: which dimensions scored above the 80th percentile (e.g. "cpu, duration, physical reads")' UNION ALL
411411
SELECT REPLICATE('-', 100) UNION ALL
412412
SELECT 'total_executions: how many times this query_hash executed in the time window' UNION ALL
413-
SELECT 'cpu_share, duration_share, reads_share, writes_share, memory_share, executions_share:' UNION ALL
413+
SELECT 'cpu_share, duration_share, physical_reads_share, writes_share, memory_share, executions_share:' UNION ALL
414414
SELECT ' what percentage of the server''s total for that metric this single query_hash consumed.' UNION ALL
415415
SELECT ' This is the 80/20 answer: "this one query is X% of all CPU on the server."' UNION ALL
416416
SELECT REPLICATE('-', 100) UNION ALL
@@ -425,7 +425,7 @@ BEGIN
425425
SELECT ' This typically means tempdb spills from underestimated memory grants, or worktable spools.' UNION ALL
426426
SELECT REPLICATE('-', 100) UNION ALL
427427
SELECT 'volatile_metrics: flags metrics with extreme variance: (max - min) / avg > 10x.' UNION ALL
428-
SELECT ' Only flagged when the absolute max exceeds meaningful thresholds (1s duration, 100ms CPU, 1MB reads/writes/memory).' UNION ALL
428+
SELECT ' Only flagged when the absolute max exceeds meaningful thresholds (1s duration, 100ms CPU, 1MB physical reads/writes/memory).' UNION ALL
429429
SELECT ' High volatility means the query''s performance is unpredictable, even if the average looks acceptable.';
430430

431431
/*
@@ -5021,7 +5021,7 @@ SELECT
50215021
(
50225022
ISNULL(N'', '' + CASE WHEN s.cpu_pctl >= 0.80 THEN N''cpu'' END, N'''') +
50235023
ISNULL(N'', '' + CASE WHEN s.duration_pctl >= 0.80 THEN N''duration'' END, N'''') +
5024-
ISNULL(N'', '' + CASE WHEN s.reads_pctl >= 0.80 THEN N''reads'' END, N'''') +
5024+
ISNULL(N'', '' + CASE WHEN s.reads_pctl >= 0.80 THEN N''physical reads'' END, N'''') +
50255025
ISNULL(N'', '' + CASE WHEN s.writes_pctl >= 0.80 THEN N''writes'' END, N'''') +
50265026
ISNULL(N'', '' + CASE WHEN s.memory_pctl >= 0.80 THEN N''memory'' END, N'''') +
50275027
ISNULL(N'', '' + CASE WHEN s.executions_pctl >= 0.80 THEN N''executions'' END, N''''),
@@ -5032,7 +5032,8 @@ SELECT
50325032
s.total_executions,
50335033
s.cpu_share,
50345034
s.duration_share,
5035-
s.reads_share,
5035+
physical_reads_share =
5036+
s.reads_share,
50365037
s.writes_share,
50375038
s.memory_share,
50385039
s.executions_share,
@@ -5152,7 +5153,7 @@ SELECT
51525153
WHEN s.max_physical_reads_mb > 1
51535154
AND (s.max_physical_reads_mb - s.min_physical_reads_mb) /
51545155
NULLIF(s.avg_physical_reads_mb, 0) > 10
5155-
THEN N''reads ('' +
5156+
THEN N''physical reads ('' +
51565157
CONVERT
51575158
(
51585159
nvarchar(20),

0 commit comments

Comments
 (0)