Honor @pending_task_threshold in sp_HealthParser scheduler shreds

@pending_task_threshold documents the minimum pending-task count the
caller wants to see, but two shreds silently ignored it:

1. #scheduler_details WHERE clause (line ~2954):
     AND (... pendingTasks[.>= sql:variable("@pending_task_threshold")] ...
          OR @warnings_only = 0)
   The `OR @warnings_only = 0` short-circuit meant that whenever the
   user ran in the default @warnings_only = 0 mode, the threshold
   predicate evaluated to TRUE regardless of the pending-task value.
   Setting @pending_task_threshold = 100 returned rows with 2 pending
   tasks just the same.

2. #pending_task_details CROSS APPLY (line ~3179):
     ... queryProcessing[@pendingTasks > 1] ...
   Hardcoded literal 1, again with no reference to the parameter.

Both now use sql:variable("@pending_task_threshold") unconditionally.
@warnings_only still independently controls the WARNING-state filter.

Verified the sproc installs clean and @what_to_check = 'scheduler'
with @pending_task_threshold = 100 runs without errors against the
system_health session on SQL Server 2022.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

Author: erikdarlingdata

sp_HealthParser/sp_HealthParser.sql

@@ -2951,7 +2951,11 @@ AND   ca.utc_timestamp < @end_date';
         CROSS APPLY wi.sp_server_diagnostics_component_result.nodes('/event') AS w(x)
         WHERE w.x.exist('(data[@name="component"]/text[.= "QUERY_PROCESSING"])') = 1
         AND  (w.x.exist('(data[@name="state"]/text[.= "WARNING"])') = @warnings_only OR @warnings_only = 0)
-        AND  (w.x.exist('(/event/data[@name="data"]/value/queryProcessing/@pendingTasks[.>= sql:variable("@pending_task_threshold")])') = 1 OR @warnings_only = 0)
+        /* Threshold is honored whether or not @warnings_only is set — the
+           parameter documents "minimum pending tasks to display" and the
+           previous `OR @warnings_only = 0` short-circuit silently ignored
+           the user-supplied value whenever warnings-only was off. */
+        AND   w.x.exist('(/event/data[@name="data"]/value/queryProcessing/@pendingTasks[.>= sql:variable("@pending_task_threshold")])') = 1
         OPTION(RECOMPILE, MAXDOP 1);
 
         IF @debug = 1
@@ -3176,7 +3180,10 @@ AND   ca.utc_timestamp < @end_date';
         INTO #pending_task_details
         FROM #sp_server_diagnostics_component_result AS wi
         CROSS APPLY wi.sp_server_diagnostics_component_result.nodes('/event') AS w(x)
-        CROSS APPLY w.x.nodes('/event/data[@name="data"]/value/queryProcessing[@pendingTasks > 1]/pendingTasks/entryPoint') AS ep(e)
+        /* Hardcoded threshold > 1 ignored the @pending_task_threshold
+           parameter. Replaced with sql:variable() binding so the user's
+           value actually takes effect here too. */
+        CROSS APPLY w.x.nodes('/event/data[@name="data"]/value/queryProcessing[@pendingTasks >= sql:variable("@pending_task_threshold")]/pendingTasks/entryPoint') AS ep(e)
         WHERE w.x.exist('(data[@name="component"]/text[.= "QUERY_PROCESSING"])') = 1
         AND  (w.x.exist('(data[@name="state"]/text[.= "WARNING"])') = @warnings_only OR @warnings_only = 0)
         OPTION(RECOMPILE, MAXDOP 1);