Minor helper function fixes

Author: erikdarlingdata

Helper Views/WhatsUpIndexes.sql

@@ -26,7 +26,7 @@ IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMA
 CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
 */
 
-IF OBJECT_ID(N'dbo.WhatsUpIndexes', N'IF') IS NULL
+IF OBJECT_ID(N'dbo.WhatsUpIndexes', N'V') IS NULL
 BEGIN
     DECLARE
         @vsql nvarchar(MAX) = N'
@@ -45,21 +45,24 @@ GO
 ALTER VIEW
     dbo.WhatsUpIndexes
 AS
-SELECT TOP (2147483647)
-    view_name =
-        'WhatsUpIndexes',
-    database_name =
-        DB_NAME(),
-    schema_name =
-        s.name,
-    table_name =
-        OBJECT_NAME(ps.object_id),
-    index_name =
-        i.name,
+SELECT TOP (9223372036854775807)
+    view_name = 'WhatsUpIndexes',
+    database_name = DB_NAME(),
+    schema_name = s.name,
+    table_name = OBJECT_NAME(ps.object_id),
+    index_name = i.name,
     in_row_pages_mb =
-        (ps.reserved_page_count * 8. / 1024.),
+        CONVERT
+        (
+            decimal(38, 2),
+            (ps.reserved_page_count * 8. / 1024.)
+        ),
     lob_pages_mb =
-        (ps.lob_reserved_page_count * 8. / 1024.),
+        CONVERT
+        (
+            decimal(38, 2),
+            (ps.lob_reserved_page_count * 8. / 1024.)
+        ),
     ps.in_row_used_page_count,
     ps.row_count
 FROM sys.dm_db_partition_stats AS ps
@@ -76,3 +79,4 @@ ORDER BY
     ps.object_id,
     ps.index_id,
     ps.partition_number;
+GO

Helper Views/WhatsUpLocks.sql

@@ -55,20 +55,19 @@ RETURN
 SELECT TOP (9223372036854775807)
     dtl.request_session_id,
     blocked_by =
-    ISNULL
-    (
+        ISNULL
         (
-            SELECT
-                der.blocking_session_id
-            FROM sys.dm_exec_requests AS der
-            WHERE dtl.request_session_id = der.session_id
+            (
+                SELECT
+                    der.blocking_session_id
+                FROM sys.dm_exec_requests AS der
+                WHERE dtl.request_session_id = der.session_id
+            ),
+            0
         ),
-        0
-    ),
     dtl.request_mode,
     l.locked_object,
-    index_name =
-        ISNULL(i.name, N'OBJECT'),
+    index_name = ISNULL(i.name, N'OBJECT'),
     dtl.resource_type,
     dtl.request_status,
     dtl.request_owner_type,
@@ -112,8 +111,7 @@ SELECT TOP (9223372036854775807)
                 0
             )
         ),
-    total_locks =
-        COUNT_BIG(*)
+    total_locks = COUNT_BIG(*)
 FROM sys.dm_tran_locks AS dtl WITH(NOLOCK)
 LEFT JOIN sys.partitions AS p WITH(NOLOCK)
   ON dtl.resource_associated_entity_id = p.hobt_id
@@ -159,3 +157,4 @@ ORDER BY
     l.locked_object,
     index_name,
     total_locks DESC;
+GO

Helper Views/WhatsUpMemory.sql

@@ -30,7 +30,7 @@ CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
 
 */
 
-IF OBJECT_ID(N'dbo.WhatsUpMemory', N'IF') IS NULL
+IF OBJECT_ID(N'dbo.WhatsUpMemory', N'V') IS NULL
 BEGIN
     DECLARE
         @vsql nvarchar(MAX) = N'
@@ -49,44 +49,46 @@ GO
 ALTER VIEW
     dbo.WhatsUpMemory
 AS
-SELECT TOP (2147483647)
-    view_name =
-        'WhatsUpMemory',
-    database_name =
-        DB_NAME(),
+SELECT TOP (9223372036854775807)
+    view_name = 'WhatsUpMemory',
+    database_name = DB_NAME(),
     x.schema_name,
     x.object_name,
     x.index_name,
     in_row_pages_mb =
-        SUM
+        CONVERT
         (
-            CASE
-                WHEN x.type IN (1, 3)
-                THEN 1
-                ELSE 0
-            END
-        ) * 8. / 1024.,
+            decimal(38, 2),
+            SUM
+            (
+                CASE
+                    WHEN x.type IN (1, 3)
+                    THEN 1
+                    ELSE 0
+                END
+            ) * 8. / 1024.
+        ),
     lob_pages_mb =
-        SUM
+        CONVERT
         (
-            CASE
-                WHEN x.type = 2
-                THEN 1
-                ELSE 0
-            END
-        ) * 8. / 1024.,
-    buffer_cache_pages_total =
-        COUNT_BIG(*)
+            decimal(38, 2),
+            SUM
+            (
+                CASE
+                    WHEN x.type = 2
+                    THEN 1
+                    ELSE 0
+                END
+            ) * 8. / 1024.
+        ),
+    buffer_cache_pages_total = COUNT_BIG(*)
 FROM sys.dm_os_buffer_descriptors AS obd
 INNER HASH JOIN
 (
     SELECT
-        schema_name =
-            s.name,
-        object_name =
-            o.name,
-        index_name =
-            i.name,
+        schema_name = s.name,
+        object_name = o.name,
+        index_name = i.name,
         au.type,
         au.allocation_unit_id
     FROM sys.allocation_units AS au
@@ -106,12 +108,9 @@ INNER HASH JOIN
     UNION ALL
 
     SELECT
-        schema_name =
-            s.name,
-        object_name =
-            o.name,
-        index_name =
-            i.name,
+        schema_name = s.name,
+        object_name = o.name,
+        index_name = i.name,
         au.type,
         au.allocation_unit_id
     FROM sys.allocation_units AS au
@@ -131,12 +130,9 @@ INNER HASH JOIN
     UNION ALL
 
     SELECT
-        schema_name =
-            s.name,
-        object_name =
-            o.name,
-        index_name =
-            i.name,
+        schema_name = s.name,
+        object_name = o.name,
+        index_name = i.name,
         au.type,
         au.allocation_unit_id
     FROM sys.allocation_units AS au
@@ -160,3 +156,4 @@ GROUP BY
     x.index_name
 ORDER BY
     COUNT_BIG(*) DESC;
+GO