Skip to content

Commit 4d0b3e9

Browse files
Remove sp_PerfCheck from basic execution tests (requires default trace)
sp_PerfCheck reads the default trace file which does not exist in Docker containers. Move to help-only testing (already covered in test_help_output.sql). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
1 parent 57c9e67 commit 4d0b3e9

1 file changed

Lines changed: 4 additions & 14 deletions

File tree

.github/sql/test_basic_execution.sql

Lines changed: 4 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,9 @@
11
/*
22
CI Test: Run default execution for procedures that are safe to execute without special setup.
3-
Procs requiring extended events or special data (sp_HumanEvents, sp_HumanEventsBlockViewer,
4-
sp_QueryReproBuilder) are tested with @help = 1 only (see test_help_output.sql).
3+
Procs requiring extended events, special data, or host features not available in Docker
4+
(sp_HumanEvents, sp_HumanEventsBlockViewer, sp_QueryReproBuilder, sp_PerfCheck)
5+
are tested with @help = 1 only (see test_help_output.sql).
6+
sp_PerfCheck reads the default trace which does not exist in Docker containers.
57
Uses a temp table to track results across GO batches.
68
*/
79

@@ -28,18 +30,6 @@ BEGIN CATCH
2830
END CATCH;
2931
GO
3032

31-
/* sp_PerfCheck - comprehensive performance health check */
32-
BEGIN TRY
33-
EXEC dbo.sp_PerfCheck;
34-
INSERT #exec_results VALUES ('sp_PerfCheck', 1);
35-
PRINT 'PASS: sp_PerfCheck (default)';
36-
END TRY
37-
BEGIN CATCH
38-
INSERT #exec_results VALUES ('sp_PerfCheck', 0);
39-
PRINT 'FAIL: sp_PerfCheck - ' + ERROR_MESSAGE();
40-
END CATCH;
41-
GO
42-
4333
/* sp_HealthParser - analyzes system health extended event */
4434
BEGIN TRY
4535
EXEC dbo.sp_HealthParser;

0 commit comments

Comments
 (0)