fix: removed elixir 1.19 warnings (#823)

Author: kraleppa

.github/workflows/ci.yml

@@ -10,7 +10,7 @@ jobs:
 
     strategy:
       matrix:
-        elixir-otp: [{otp: 24.x, elixir: 1.12.x}, {otp: 26.x, elixir: 1.16.x}, {otp: 27.x, elixir: 1.17.x}, {otp: 27.x, elixir: 1.18.x}]
+        elixir-otp: [{otp: 24.x, elixir: 1.12.x}, {otp: 26.x, elixir: 1.16.x}, {otp: 27.x, elixir: 1.17.x}, {otp: 27.x, elixir: 1.18.x}, {otp: 28.x, elixir: 1.19.x}]
       fail-fast: false
 
     env:
@@ -46,7 +46,7 @@ jobs:
 
     strategy:
       matrix:
-        elixir-otp: [{otp: 27.x, elixir: 1.18.x}]
+        elixir-otp: [{otp: 28.x, elixir: 1.19.x}]
       fail-fast: false
 
     steps:
@@ -91,7 +91,7 @@ jobs:
 
     strategy:
       matrix:
-        elixir-otp: [{otp: 24.x, elixir: 1.12.x}, {otp: 26.x, elixir: 1.16.x}, {otp: 27.x, elixir: 1.17.x}, {otp: 27.x, elixir: 1.18.x}]
+        elixir-otp: [{otp: 24.x, elixir: 1.12.x}, {otp: 26.x, elixir: 1.16.x}, {otp: 27.x, elixir: 1.17.x}, {otp: 27.x, elixir: 1.18.x}, {otp: 28.x, elixir: 1.19.x}]
       fail-fast: false
 
     env:
@@ -127,7 +127,7 @@ jobs:
 
     strategy:
       matrix:
-        elixir-otp: [{otp: 24.x, elixir: 1.12.x}, {otp: 26.x, elixir: 1.16.x}, {otp: 27.x, elixir: 1.17.x}, {otp: 27.x, elixir: 1.18.x}]
+        elixir-otp: [{otp: 24.x, elixir: 1.12.x}, {otp: 26.x, elixir: 1.16.x}, {otp: 27.x, elixir: 1.17.x}, {otp: 27.x, elixir: 1.18.x}, {otp: 28.x, elixir: 1.19.x}]
       fail-fast: false
 
     env:
@@ -178,7 +178,7 @@ jobs:
 
     strategy:
       matrix:
-        elixir-otp: [{otp: 27.x, elixir: 1.18.x}]
+        elixir-otp: [{otp: 27.x, elixir: 1.18.x}, {otp: 28.x, elixir: 1.19.x}]
       fail-fast: false
 
     steps:

.tool-versions

@@ -1,2 +1,2 @@
-elixir 1.18.1
-erlang 27.2
+elixir 1.19.1-otp-28
+erlang 28.1.1

lib/wallaby/browser.ex

@@ -954,7 +954,7 @@ defmodule Wallaby.Browser do
         |> Query.result()
 
       {:error, {:not_found, result}} ->
-        query = %Query{query | result: result}
+        query = %{query | result: result}
 
         case validate_html(parent, query) do
           {:ok, _} ->
@@ -1008,7 +1008,7 @@ defmodule Wallaby.Browser do
   def all(parent, %Query{} = query) do
     find(
       parent,
-      %Query{query | conditions: Keyword.merge(query.conditions, count: nil, minimum: 0)}
+      %{query | conditions: Keyword.merge(query.conditions, count: nil, minimum: 0)}
     )
   end
 
@@ -1171,7 +1171,7 @@ defmodule Wallaby.Browser do
         error ->
           case error do
             {:error, {:not_found, results}} ->
-              query = %Query{query | result: results}
+              query = %{query | result: results}
 
               raise ExpectationNotMetError,
                     Query.ErrorMessage.message(query, :not_found)
@@ -1504,7 +1504,7 @@ defmodule Wallaby.Browser do
              {:ok, elements} <- validate_selected(query, elements),
              {:ok, elements} <- validate_count(query, elements),
              {:ok, elements} <- do_at(query, elements) do
-          {:ok, %Query{query | result: elements}}
+          {:ok, %{query | result: elements}}
         end
       rescue
         StaleReferenceError ->

lib/wallaby/chrome/chromedriver/server.ex

@@ -103,7 +103,7 @@ defmodule Wallaby.Chrome.Chromedriver.Server do
     check_readiness_async(port_number)
 
     {:noreply,
-     %State{
+     %{
        state
        | port_number: port_number,
          wrapper_script_port: wrapper_script_port,
@@ -125,13 +125,13 @@ defmodule Wallaby.Chrome.Chromedriver.Server do
       GenServer.reply(call, :ok)
     end
 
-    {:noreply, %State{state | calls_awaiting_readiness: [], ready?: true}}
+    {:noreply, %{state | calls_awaiting_readiness: [], ready?: true}}
   end
 
   def handle_info({port, {:data, output}}, %State{wrapper_script_port: port} = state) do
     case analyze_output(output) do
       {:os_pid, os_pid} ->
-        {:noreply, %State{state | chromedriver_os_pid: os_pid}}
+        {:noreply, %{state | chromedriver_os_pid: os_pid}}
 
       :unknown ->
         {:noreply, state}
@@ -161,7 +161,7 @@ defmodule Wallaby.Chrome.Chromedriver.Server do
 
   def handle_call(:wait_until_ready, from, %State{ready?: false} = state) do
     %State{calls_awaiting_readiness: calls_awaiting_readiness} = state
-    {:noreply, %State{state | calls_awaiting_readiness: [from | calls_awaiting_readiness]}}
+    {:noreply, %{state | calls_awaiting_readiness: [from | calls_awaiting_readiness]}}
   end
 
   @spec open_chromedriver_port(String.t(), port_number) :: port

lib/wallaby/element.ex

@@ -286,6 +286,11 @@ defimpl Inspect, for: Wallaby.Element do
           []
       end
 
-    concat([Inspect.Any.inspect(element, opts)] ++ additional_output)
+    element
+    |> Inspect.Any.inspect(opts)
+    |> maybe_concat(additional_output)
   end
+
+  defp maybe_concat(inspect_result, []), do: inspect_result
+  defp maybe_concat(inspect_result, output), do: concat([inspect_result | output])
 end

lib/wallaby/query.ex

@@ -582,6 +582,6 @@ defmodule Wallaby.Query do
 
   defp update_condition(%Query{conditions: conditions} = query, key, value) do
     updated_conditions = Keyword.put(conditions, key, value)
-    %Query{query | conditions: updated_conditions}
+    %{query | conditions: updated_conditions}
   end
 end

mix.exs

@@ -22,15 +22,20 @@ defmodule Wallaby.Mixfile do
 
       # Custom testing
       aliases: ["test.all": ["test", "test.drivers"], "test.drivers": &test_drivers/1],
-      preferred_cli_env: [
-        "test.all": :test,
-        "test.drivers": :test
-      ],
       test_paths: test_paths(@selected_driver),
       dialyzer: dialyzer()
     ]
   end
 
+  def cli do
+    [
+      preferred_envs: [
+        "test.all": :test,
+        "test.drivers": :test
+      ]
+    ]
+  end
+
   def application do
     [extra_applications: [:logger], mod: {Wallaby, []}]
   end