Merge pull request erikdarlingdata#922 from erikdarlingdata/feature/916-correlated-crosshair-tooltip

Apply erikdarlingdata#916 popup-wedge fix to CorrelatedCrosshairManager

Author: erikdarlingdata

Dashboard/Helpers/CorrelatedCrosshairManager.cs

@@ -74,9 +74,28 @@ public void AddLane(ScottPlot.WPF.WpfPlot chart, string label, string unit)
         chart.MouseMove += (s, e) => OnMouseMove(lane, e);
         chart.MouseLeave += (s, e) => OnMouseLeave();
 
+        /* Tab switching can leave the popup wedged: WPF unloads the parent TabItem
+           without firing MouseLeave, so IsOpen stays true with a stale anchor.
+           When a chart becomes visible again, OnMouseMove sets IsOpen = true but
+           it is already true, so the popup never re-anchors. Force-close on every
+           visibility/load transition for any lane so the next mouse move re-opens
+           cleanly. */
+        chart.IsVisibleChanged += OnLaneVisibilityChanged;
+        chart.Unloaded += OnLaneUnloaded;
+        chart.Loaded += OnLaneLoaded;
+
         _lanes.Add(lane);
     }
 
+    private void OnLaneVisibilityChanged(object sender, DependencyPropertyChangedEventArgs e) =>
+        _tooltip.IsOpen = false;
+
+    private void OnLaneUnloaded(object sender, RoutedEventArgs e) =>
+        _tooltip.IsOpen = false;
+
+    private void OnLaneLoaded(object sender, RoutedEventArgs e) =>
+        _tooltip.IsOpen = false;
+
     /// <summary>
     /// Sets the expected baseline range for a lane (upper/lower bounds).
     /// Values outside this range get ▲/▼ indicators in the tooltip.
@@ -287,6 +306,11 @@ private void OnMouseMove(LaneInfo sourceLane, MouseEventArgs e)
         _tooltip.PlacementTarget = sourceLane.Chart;
         _tooltip.HorizontalOffset = pos.X + 15;
         _tooltip.VerticalOffset = pos.Y + 15;
+        /* Toggle if already open so WPF re-evaluates the placement target.
+           Without this, a popup that was IsOpen = true when its TabItem was
+           unloaded stays "open" with a stale anchor and never appears on
+           return — the assignment below is a no-op. */
+        if (_tooltip.IsOpen) _tooltip.IsOpen = false;
         _tooltip.IsOpen = true;
     }
 
@@ -373,6 +397,9 @@ public void Dispose()
         _tooltip.IsOpen = false;
         foreach (var lane in _lanes)
         {
+            lane.Chart.IsVisibleChanged -= OnLaneVisibilityChanged;
+            lane.Chart.Unloaded -= OnLaneUnloaded;
+            lane.Chart.Loaded -= OnLaneLoaded;
             lane.Series.Clear();
             lane.VLine = null;
         }

Lite/Helpers/CorrelatedCrosshairManager.cs

@@ -74,9 +74,28 @@ public void AddLane(ScottPlot.WPF.WpfPlot chart, string label, string unit)
         chart.MouseMove += (s, e) => OnMouseMove(lane, e);
         chart.MouseLeave += (s, e) => OnMouseLeave();
 
+        /* Tab switching can leave the popup wedged: WPF unloads the parent TabItem
+           without firing MouseLeave, so IsOpen stays true with a stale anchor.
+           When a chart becomes visible again, OnMouseMove sets IsOpen = true but
+           it is already true, so the popup never re-anchors. Force-close on every
+           visibility/load transition for any lane so the next mouse move re-opens
+           cleanly. */
+        chart.IsVisibleChanged += OnLaneVisibilityChanged;
+        chart.Unloaded += OnLaneUnloaded;
+        chart.Loaded += OnLaneLoaded;
+
         _lanes.Add(lane);
     }
 
+    private void OnLaneVisibilityChanged(object sender, DependencyPropertyChangedEventArgs e) =>
+        _tooltip.IsOpen = false;
+
+    private void OnLaneUnloaded(object sender, RoutedEventArgs e) =>
+        _tooltip.IsOpen = false;
+
+    private void OnLaneLoaded(object sender, RoutedEventArgs e) =>
+        _tooltip.IsOpen = false;
+
     /// <summary>
     /// Sets the expected baseline range for a lane (upper/lower bounds).
     /// Values outside this range get ▲/▼ indicators in the tooltip.
@@ -287,6 +306,11 @@ private void OnMouseMove(LaneInfo sourceLane, MouseEventArgs e)
         _tooltip.PlacementTarget = sourceLane.Chart;
         _tooltip.HorizontalOffset = pos.X + 15;
         _tooltip.VerticalOffset = pos.Y + 15;
+        /* Toggle if already open so WPF re-evaluates the placement target.
+           Without this, a popup that was IsOpen = true when its TabItem was
+           unloaded stays "open" with a stale anchor and never appears on
+           return — the assignment below is a no-op. */
+        if (_tooltip.IsOpen) _tooltip.IsOpen = false;
         _tooltip.IsOpen = true;
     }
 
@@ -373,6 +397,9 @@ public void Dispose()
         _tooltip.IsOpen = false;
         foreach (var lane in _lanes)
         {
+            lane.Chart.IsVisibleChanged -= OnLaneVisibilityChanged;
+            lane.Chart.Unloaded -= OnLaneUnloaded;
+            lane.Chart.Loaded -= OnLaneLoaded;
             lane.Series.Clear();
             lane.VLine = null;
         }