|
| 1 | +using System; |
| 2 | +using PerformanceMonitorLite.Services; |
| 3 | +using Xunit; |
| 4 | + |
| 5 | +namespace PerformanceMonitorLite.Tests; |
| 6 | + |
| 7 | +/// <summary> |
| 8 | +/// Guards the Lite server-tab badge acknowledgement logic for the low-disk (#754) and |
| 9 | +/// failed-Agent-job (#749) conditions added in #1128. Those conditions are plain booleans with |
| 10 | +/// no event timestamp, so the timestamp-based ack clear in |
| 11 | +/// <see cref="AlertStateService.UpdateAlertCounts"/> never fires for them. The review fix added |
| 12 | +/// <see cref="AlertStateService.ClearAcknowledgementForNewCondition"/> — the false->true |
| 13 | +/// transition hook MainWindow calls so a freshly-breaching disk or a brand-new failed job |
| 14 | +/// re-lights an acknowledged badge, matching the Dashboard's re-show behaviour. |
| 15 | +/// |
| 16 | +/// Each test uses a unique server id so the shared (CWD-relative) alert_state.json the service |
| 17 | +/// persists to cannot leak state between tests; assertions read in-memory state, so they hold |
| 18 | +/// even when the best-effort file write is unavailable. |
| 19 | +/// </summary> |
| 20 | +public class AlertBadgeAckTests |
| 21 | +{ |
| 22 | + private static string NewServerId() => "badge-test-" + Guid.NewGuid().ToString("N"); |
| 23 | + |
| 24 | + [Fact] |
| 25 | + public void StandingLowDisk_AfterAck_StaysSuppressed_UntilNewConditionClearsIt() |
| 26 | + { |
| 27 | + var svc = new AlertStateService(); |
| 28 | + var server = NewServerId(); |
| 29 | + |
| 30 | + /* A standing low-disk breach lights the badge... */ |
| 31 | + Assert.True(svc.UpdateAlertCounts(server, 0, 0, hasLowDisk: true, hasFailedJob: false, latestEventTimeUtc: null)); |
| 32 | + |
| 33 | + /* ...the user dismisses it: the badge stays suppressed even though the breach is still |
| 34 | + standing — with no event timestamp, UpdateAlertCounts can never auto-clear the ack. */ |
| 35 | + svc.AcknowledgeAlert(server); |
| 36 | + Assert.False(svc.UpdateAlertCounts(server, 0, 0, hasLowDisk: true, hasFailedJob: false, latestEventTimeUtc: null)); |
| 37 | + |
| 38 | + /* A fresh false->true transition (re-breach / new job) clears the ack and re-lights. */ |
| 39 | + var fired = false; |
| 40 | + svc.SuppressionStateChanged += (_, _) => fired = true; |
| 41 | + svc.ClearAcknowledgementForNewCondition(server); |
| 42 | + Assert.True(fired); |
| 43 | + Assert.True(svc.UpdateAlertCounts(server, 0, 0, hasLowDisk: true, hasFailedJob: false, latestEventTimeUtc: null)); |
| 44 | + } |
| 45 | + |
| 46 | + [Fact] |
| 47 | + public void FailedJob_AfterAck_StaysSuppressed_UntilNewConditionClearsIt() |
| 48 | + { |
| 49 | + var svc = new AlertStateService(); |
| 50 | + var server = NewServerId(); |
| 51 | + |
| 52 | + Assert.True(svc.UpdateAlertCounts(server, 0, 0, hasLowDisk: false, hasFailedJob: true, latestEventTimeUtc: null)); |
| 53 | + |
| 54 | + svc.AcknowledgeAlert(server); |
| 55 | + Assert.False(svc.UpdateAlertCounts(server, 0, 0, hasLowDisk: false, hasFailedJob: true, latestEventTimeUtc: null)); |
| 56 | + |
| 57 | + svc.ClearAcknowledgementForNewCondition(server); |
| 58 | + Assert.True(svc.UpdateAlertCounts(server, 0, 0, hasLowDisk: false, hasFailedJob: true, latestEventTimeUtc: null)); |
| 59 | + } |
| 60 | + |
| 61 | + [Fact] |
| 62 | + public void ClearAcknowledgementForNewCondition_WhenNothingAcknowledged_DoesNotFireEvent() |
| 63 | + { |
| 64 | + var svc = new AlertStateService(); |
| 65 | + var server = NewServerId(); |
| 66 | + |
| 67 | + var fired = false; |
| 68 | + svc.SuppressionStateChanged += (_, _) => fired = true; |
| 69 | + |
| 70 | + /* No prior ack for this server -> nothing to clear -> no event, no save churn. */ |
| 71 | + svc.ClearAcknowledgementForNewCondition(server); |
| 72 | + Assert.False(fired); |
| 73 | + |
| 74 | + /* And a standing condition still lights the badge (it was never suppressed). */ |
| 75 | + Assert.True(svc.UpdateAlertCounts(server, 0, 0, hasLowDisk: true, hasFailedJob: false, latestEventTimeUtc: null)); |
| 76 | + } |
| 77 | + |
| 78 | + [Fact] |
| 79 | + public void SilencedServer_NewCondition_StaysSuppressed() |
| 80 | + { |
| 81 | + /* ClearAcknowledgementForNewCondition only clears the *ack*; a fully-silenced server must |
| 82 | + stay dark even when a new disk/job condition appears. */ |
| 83 | + var svc = new AlertStateService(); |
| 84 | + var server = NewServerId(); |
| 85 | + |
| 86 | + svc.SilenceServer(server); |
| 87 | + svc.ClearAcknowledgementForNewCondition(server); |
| 88 | + Assert.False(svc.UpdateAlertCounts(server, 0, 0, hasLowDisk: true, hasFailedJob: true, latestEventTimeUtc: null)); |
| 89 | + } |
| 90 | +} |
0 commit comments