Conversation
|
sitole
reviewed
Jul 28, 2025
Comment on lines
-1
to
-5
| update-api-spec: | ||
| @echo "Updating API spec" | ||
| @./scripts/update-api-spec.sh | ||
| @echo "Done" | ||
|
|
Member
Author
There was a problem hiding this comment.
it didn't work and it isn't used anyway, so I removed it to prevent issues
sitole
approved these changes
Jul 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes an issue in generating files in Docker. There has been an incompatibility of
buf(version29.5) andprotoc-gen-es(version2.2.2).I updated
protoc-gen-es@to2.6.2Also refactored the code a little so it's easier to read
Added a CI pipeline job to check all files are properly generated