User group tree not working with Accounts feature enabled

[nunoaguiar]

Is your feature request related to a problem? Please describe.
When the feature flag "Enable user account functionality" is enabled, the user groups tree does not go past 1 level deep.
It should be possible to use the subgroups (that are not of type accounts) regardless of the feature flag being enabled

Repro steps

• Ensure "Enable user account functionality" is disabled
• Create 3 or more level of user groups. For example
  • A
    • A-1
    • A-1-1
• Enable "Enable user account functionality"
• Go back to Users
• The tree does not render subgroups now - but you can get to subgroups using the "List subgroups" feature
• However, there is no way to ever get to "A-1-1"

https://app.screencast.com/jkr3wi1t59TV2

Best Regards,
Nuno Aguiar

[jentjohansen]

Thank you for the video Nuno , i can see you are running on 10.28.5 version .
I do not get same issue as you do. on my 10.29. version

I tried with enabling / disabling the Account functionality

[nunoaguiar]

Sounds great, thanks for confirming @jentjohansen

[nunoaguiar]

@jentjohansen Could this be merged down to 10.27?

We are going live in about 2 months and it will need to be in R3 by then.

[nunoaguiar]

@jentjohansen and @nicped

I am now in 10.29 and still experience the problem. I was able to get better repro steps:

• Create a User Group that has a User and Group Type (in my case, I'm calling it Role)
• If the Subgroups are a specific UserAndGroupType, they are not listed
  (my initial screencast) https://app.screencast.com/jkr3wi1t59TV2
• If the Subgroups is a standard group (no User and Group Type), then it shows.
  https://app.screencast.com/znh2OL8fz3swi

The problem seems to be in https://dev.azure.com/dynamicwebsoftware/Dynamicweb/_git/Dynamicweb10?path=/Dynamicweb.Users.UI/Tree/UsersAreaSectionProvider.cs&version=GBmaster&_a=contents&line=149&lineStyle=plain&lineEnd=151&lineStartColumn=13&lineEndColumn=1

It should just continue if the User and Group Type is SystemAccount
(proposed fix)

  if (Feature.IsActive<UserGroupAccountFeature>() && group.GetUserAndGroupType()?.SystemName == AccountSystemName)
    continue;

If this is confirmed, I'd appreciate it being published down to 10.27

Best Regards,
Nuno