Skip to content

Commit 25eede7

Browse files
Harden OrderBys (#160)
1 parent f450308 commit 25eede7

2 files changed

Lines changed: 4 additions & 2 deletions

File tree

src/Http/Controllers/CP/Discounts/DiscountController.php

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@
1212
use Statamic\Facades\Scope;
1313
use Statamic\Http\Controllers\CP\CpController;
1414
use Statamic\Http\Requests\FilteredRequest;
15+
use Statamic\Query\OrderBy;
1516
use Statamic\Query\Scopes\Filters\Concerns\QueriesFilters;
1617
use Statamic\Support\Arr;
1718

@@ -28,7 +29,7 @@ public function index(FilteredRequest $request)
2829

2930
$activeFilterBadges = $this->queryFilters($query, $request->filters);
3031

31-
$sortField = request('sort');
32+
$sortField = OrderBy::column(request('sort'));
3233
$sortDirection = request('order', 'asc');
3334

3435
if (! $sortField && ! request('search')) {

src/Http/Controllers/CP/Orders/OrderController.php

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@
1414
use Statamic\Facades\User;
1515
use Statamic\Http\Controllers\CP\CpController;
1616
use Statamic\Http\Requests\FilteredRequest;
17+
use Statamic\Query\OrderBy;
1718
use Statamic\Query\Scopes\Filters\Concerns\QueriesFilters;
1819

1920
class OrderController extends CpController
@@ -29,7 +30,7 @@ public function index(FilteredRequest $request)
2930

3031
$activeFilterBadges = $this->queryFilters($query, $request->filters);
3132

32-
$sortField = request('sort');
33+
$sortField = OrderBy::column(request('sort'));
3334
$sortDirection = request('order', 'asc');
3435

3536
if (! $sortField && ! request('search')) {

0 commit comments

Comments
 (0)