Skip to content

Commit 79e46f2

Browse files
committed
chore: Stopped publishing vela-yaml-validator image
Closes #58
1 parent dacb246 commit 79e46f2

6 files changed

Lines changed: 19 additions & 22 deletions

File tree

.circleci/config.yml

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ slack_image: &slack_image
77

88
yaml_validator_image: &yaml_validator_image
99
docker:
10-
- image: devatherock/vela-yaml-validator:latest
10+
- image: devatherock/drone-yaml-validator:latest
1111
auth:
1212
username: $DOCKER_USERNAME
1313
password: $DOCKER_PASSWORD
@@ -131,12 +131,8 @@ jobs:
131131
docker login -u $DOCKER_USERNAME -p $DOCKER_PASSWORD
132132
docker build -t devatherock/drone-yaml-validator:$TAG .
133133
docker tag devatherock/drone-yaml-validator:$TAG devatherock/drone-yaml-validator:latest
134-
docker tag devatherock/drone-yaml-validator:$TAG devatherock/vela-yaml-validator:$TAG
135-
docker tag devatherock/drone-yaml-validator:$TAG devatherock/vela-yaml-validator:latest
136134
docker push devatherock/drone-yaml-validator:$TAG
137135
docker push devatherock/drone-yaml-validator:latest
138-
docker push devatherock/vela-yaml-validator:$TAG
139-
docker push devatherock/vela-yaml-validator:latest
140136
141137
test_docker:
142138
<<: *yaml_validator_image
@@ -209,9 +205,7 @@ jobs:
209205
docker login -u $DOCKER_USERNAME -p $DOCKER_PASSWORD
210206
docker pull devatherock/drone-yaml-validator:$DEV_TAG
211207
docker tag devatherock/drone-yaml-validator:$DEV_TAG devatherock/drone-yaml-validator:$TAG
212-
docker tag devatherock/drone-yaml-validator:$TAG devatherock/vela-yaml-validator:$TAG
213208
docker push devatherock/drone-yaml-validator:$TAG
214-
docker push devatherock/vela-yaml-validator:$TAG
215209
216210
notify_success:
217211
<<: *slack_image

CHANGELOG.md

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,9 @@
1111
### Changed
1212
- chore(deps): update dependency org.codehaus.groovy:groovy to v2.5.15
1313

14+
### Removed
15+
- [#58](https://github.com/devatherock/drone-yaml-validator/issues/58): `vela-yaml-validator` publish, so that one image `drone-yaml-validator`, that supports both vela and drone, can be used
16+
1417
## [1.5.0] - 2021-01-25
1518
### Added
1619
- [#28](https://github.com/devatherock/drone-yaml-validator/issues/28): Flag to treat YAML files with duplicate keys as valid.

README.md

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,9 @@
11
[![CircleCI](https://circleci.com/gh/devatherock/drone-yaml-validator.svg?style=svg)](https://circleci.com/gh/devatherock/drone-yaml-validator)
2-
[![Version](https://img.shields.io/docker/v/devatherock/vela-yaml-validator?sort=semver)](https://hub.docker.com/r/devatherock/vela-yaml-validator/)
2+
[![Version](https://img.shields.io/docker/v/devatherock/drone-yaml-validator?sort=semver)](https://hub.docker.com/r/devatherock/drone-yaml-validator/)
33
[![Coverage Status](https://coveralls.io/repos/github/devatherock/drone-yaml-validator/badge.svg?branch=master)](https://coveralls.io/github/devatherock/drone-yaml-validator?branch=master)
44
[![Codacy Badge](https://app.codacy.com/project/badge/Grade/eee25e47d4104a20894d2a0f8f35d2fd)](https://www.codacy.com/gh/devatherock/drone-yaml-validator/dashboard?utm_source=github.com&amp;utm_medium=referral&amp;utm_content=devatherock/drone-yaml-validator&amp;utm_campaign=Badge_Grade)
55
[![Docker Pulls - Drone](https://img.shields.io/docker/pulls/devatherock/drone-yaml-validator.svg)](https://hub.docker.com/r/devatherock/drone-yaml-validator/)
6-
[![Docker Image Size](https://img.shields.io/docker/image-size/devatherock/vela-yaml-validator.svg?sort=date)](https://hub.docker.com/r/devatherock/vela-yaml-validator/)
6+
[![Docker Image Size](https://img.shields.io/docker/image-size/devatherock/drone-yaml-validator.svg?sort=date)](https://hub.docker.com/r/devatherock/drone-yaml-validator/)
77
[![License: MIT](https://img.shields.io/badge/License-MIT-yellow.svg)](https://opensource.org/licenses/MIT)
88
# yaml-validator
99
CI plugin to validate yaml files
@@ -40,7 +40,7 @@ steps:
4040
ruleset:
4141
branch: master
4242
event: push
43-
image: devatherock/vela-yaml-validator:1.5.0
43+
image: devatherock/drone-yaml-validator:1.5.0
4444
parameters:
4545
debug: false
4646
continue_on_error: true
@@ -66,7 +66,7 @@ version: 2.1
6666
jobs:
6767
validate_yamls:
6868
docker:
69-
- image: devatherock/vela-yaml-validator:1.5.0
69+
- image: devatherock/drone-yaml-validator:1.5.0
7070
working_directory: ~/my-repo
7171
environment:
7272
PARAMETER_DEBUG: false

src/test/groovy/io/github/devatherock/yamlvalidator/docker/YamlValidatorDockerSpec.groovy

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -14,19 +14,19 @@ class YamlValidatorDockerSpec extends Specification {
1414
@Shared
1515
def config = [
1616
'drone': [
17-
'image' : 'devatherock/drone-yaml-validator:latest',
1817
'envPrefix': 'PLUGIN_'
1918
],
2019
'vela' : [
21-
'image' : 'devatherock/vela-yaml-validator:latest',
2220
'envPrefix': 'PARAMETER_'
2321
]
2422
]
2523

24+
@Shared
25+
String dockerImage = 'devatherock/drone-yaml-validator:latest'
26+
2627
def setupSpec() {
2728
System.setProperty('java.util.logging.SimpleFormatter.format', '%5$s%n')
28-
executeCommand("docker pull ${config['drone'].image}")
29-
executeCommand("docker pull ${config['vela'].image}")
29+
executeCommand("docker pull ${dockerImage}")
3030
}
3131

3232
@Unroll
@@ -37,7 +37,7 @@ class YamlValidatorDockerSpec extends Specification {
3737
'-w=/work',
3838
'-e', "${config[ci].envPrefix}DEBUG=${debugEnabled}",
3939
'-e', "${config[ci].envPrefix}SEARCH_PATH=/work/src/test/resources/data/${folderName}",
40-
config[ci].image])
40+
dockerImage])
4141

4242
then:
4343
output[0] == expectedExitCode
@@ -89,7 +89,7 @@ class YamlValidatorDockerSpec extends Specification {
8989
'-v', "${System.properties['user.dir']}/src/test/resources/data:/work",
9090
'-w=/work',
9191
'-e', "${config[ci].envPrefix}CONTINUE_ON_ERROR=${continueOnError}",
92-
config[ci].image])
92+
dockerImage])
9393

9494
then:
9595
output[0] == 1
@@ -117,7 +117,7 @@ class YamlValidatorDockerSpec extends Specification {
117117
'-v', "${System.properties['user.dir']}/src/test/resources/data/duplicate:/work",
118118
'-w=/work',
119119
'-e', "${config[ci].envPrefix}ALLOW_DUPLICATE_KEYS=${allowDuplicateKeys}",
120-
config[ci].image])
120+
dockerImage])
121121

122122
then:
123123
output[0] == expectedExitCode

src/test/resources/data/invalid2/anchor.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ jobs:
3232
at: ~/drone-yaml-validator
3333
- run: |
3434
TAG=1.0.1
35-
docker build -t devatherock/drone-yaml-validator:$TAG -t devatherock/vela-yaml-validator:$TAG .
35+
docker build -t devatherock/drone-yaml-validator:$TAG -t devatherock/drone-yaml-validator:latest .
3636
docker login -u $DOCKER_USERNAME -p $DOCKER_PASSWORD
3737
docker push devatherock/drone-yaml-validator:$TAG
38-
docker push devatherock/vela-yaml-validator:$TAG
38+
docker push devatherock/drone-yaml-validator:latest

src/test/resources/data/valid/config.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -36,10 +36,10 @@ jobs:
3636
at: ~/drone-yaml-validator
3737
- run: |
3838
TAG=1.0.1
39-
docker build -t devatherock/drone-yaml-validator:$TAG -t devatherock/vela-yaml-validator:$TAG .
39+
docker build -t devatherock/drone-yaml-validator:$TAG -t devatherock/drone-yaml-validator:latest .
4040
docker login -u $DOCKER_USERNAME -p $DOCKER_PASSWORD
4141
docker push devatherock/drone-yaml-validator:$TAG
42-
docker push devatherock/vela-yaml-validator:$TAG
42+
docker push devatherock/drone-yaml-validator:latest
4343
4444
workflows:
4545
version: 2

0 commit comments

Comments
 (0)