Skip to content

Commit 03c38cd

Browse files
committed
Addressed copilot's comments
1 parent 4245550 commit 03c38cd

4 files changed

Lines changed: 15 additions & 13 deletions

File tree

.github/workflows/test-build-kontron-vx3060-s2.yml

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -22,24 +22,24 @@ jobs:
2222
shopt -s nullglob
2323
2424
sudo sed -i \
25-
-e "s|https\?://azure\.archive\.ubuntu\.com/ubuntu/?|http://mirror.arizona.edu/ubuntu/|g" \
25+
-e "s|https\?://azure\.archive\.ubuntu\.com/ubuntu/?|https://mirror.arizona.edu/ubuntu/|g" \
2626
/etc/apt/sources.list || true
2727
2828
for f in /etc/apt/sources.list.d/*.list; do
2929
sudo sed -i \
30-
-e "s|https\?://azure\.archive\.ubuntu\.com/ubuntu/?|http://mirror.arizona.edu/ubuntu/|g" \
30+
-e "s|https\?://azure\.archive\.ubuntu\.com/ubuntu/?|https://mirror.arizona.edu/ubuntu/|g" \
3131
"$f"
3232
done
3333
3434
for f in /etc/apt/sources.list.d/*.sources; do
3535
sudo sed -i \
36-
-e "s|https\?://azure\.archive\.ubuntu\.com/ubuntu/?|http://mirror.arizona.edu/ubuntu/|g" \
37-
-e "s|https\?://azure\.archive\.ubuntu\.com|http://mirror.arizona.edu|g" \
36+
-e "s|https\?://azure\.archive\.ubuntu\.com/ubuntu/?|https://mirror.arizona.edu/ubuntu/|g" \
37+
-e "s|https\?://azure\.archive\.ubuntu\.com|https://mirror.arizona.edu|g" \
3838
"$f"
3939
done
4040
4141
if grep -qE '^[[:space:]]*https?://azure\.archive\.ubuntu\.com/ubuntu/?' /etc/apt/apt-mirrors.txt; then
42-
sudo sed -i 's|https\?://azure\.archive\.ubuntu\.com/ubuntu/|http://mirror.arizona.edu/ubuntu/|g' /etc/apt/apt-mirrors.txt
42+
sudo sed -i 's|https\?://azure\.archive\.ubuntu\.com/ubuntu/|https://mirror.arizona.edu/ubuntu/|g' /etc/apt/apt-mirrors.txt
4343
fi
4444
- name: install req
4545
run: |

.github/workflows/test-x86-fsp-qemu.yml

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -22,24 +22,24 @@ jobs:
2222
shopt -s nullglob
2323
2424
sudo sed -i \
25-
-e "s|https\?://azure\.archive\.ubuntu\.com/ubuntu/?|http://mirror.arizona.edu/ubuntu/|g" \
25+
-e "s|https\?://azure\.archive\.ubuntu\.com/ubuntu/?|https://mirror.arizona.edu/ubuntu/|g" \
2626
/etc/apt/sources.list || true
2727
2828
for f in /etc/apt/sources.list.d/*.list; do
2929
sudo sed -i \
30-
-e "s|https\?://azure\.archive\.ubuntu\.com/ubuntu/?|http://mirror.arizona.edu/ubuntu/|g" \
30+
-e "s|https\?://azure\.archive\.ubuntu\.com/ubuntu/?|https://mirror.arizona.edu/ubuntu/|g" \
3131
"$f"
3232
done
3333
3434
for f in /etc/apt/sources.list.d/*.sources; do
3535
sudo sed -i \
36-
-e "s|https\?://azure\.archive\.ubuntu\.com/ubuntu/?|http://mirror.arizona.edu/ubuntu/|g" \
37-
-e "s|https\?://azure\.archive\.ubuntu\.com|http://mirror.arizona.edu|g" \
36+
-e "s|https\?://azure\.archive\.ubuntu\.com/ubuntu/?|https://mirror.arizona.edu/ubuntu/|g" \
37+
-e "s|https\?://azure\.archive\.ubuntu\.com|https://mirror.arizona.edu|g" \
3838
"$f"
3939
done
4040
4141
if grep -qE '^[[:space:]]*https?://azure\.archive\.ubuntu\.com/ubuntu/?' /etc/apt/apt-mirrors.txt; then
42-
sudo sed -i 's|https\?://azure\.archive\.ubuntu\.com/ubuntu/|http://mirror.arizona.edu/ubuntu/|g' /etc/apt/apt-mirrors.txt
42+
sudo sed -i 's|https\?://azure\.archive\.ubuntu\.com/ubuntu/|https://mirror.arizona.edu/ubuntu/|g' /etc/apt/apt-mirrors.txt
4343
fi
4444
- name: install req
4545
run: |

hal/nrf52.c

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,10 +26,12 @@
2626
#include "nrf52.h"
2727

2828
#ifdef DEBUG_UART
29+
#define UARTE_ENABLE_ENABLE 8u
30+
2931
void uart_init(void)
3032
{
3133
UART0_BAUDRATE = BAUD_115200;
32-
UART0_ENABLE = 4;
34+
UART0_ENABLE = UARTE_ENABLE_ENABLE;
3335
}
3436

3537
static volatile uint8_t uart_tx_buf;

tools/renode/docker-test.sh

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ declare -r HOST_TEST_RESULTS_PATH=${HOST_ROOT_DIR}/test_results
44
declare -r HOST_LOG_PATH=${HOST_TEST_RESULTS_PATH}
55
declare -r HOST_LOG_FILENAME=${HOST_LOG_PATH}/logs.txt
66

7-
declare -r DOCKER_IMAGE="${DOCKER_IMAGE:-ghcr.io/wolfssl/wolfboot-ci-renode:latest}"
7+
declare -r DOCKER_IMAGE="${DOCKER_IMAGE:-ghcr.io/wolfssl/wolfboot-ci-renode:1.5}"
88
declare -r DOCKER_WORKSPACE=/workspace
99
declare -r DOCKER_TEST_RESULTS_PATH=/tmp/test_results
1010

@@ -20,7 +20,7 @@ if ! docker run \
2020
--env SCRIPT=${DOCKER_WORKSPACE}/renode-config.resc \
2121
--workdir ${DOCKER_WORKSPACE} \
2222
${DOCKER_IMAGE} \
23-
/bin/bash -c "tools/scripts/renode-test-update.sh $@ 2>&1 > ${DOCKER_TEST_RESULTS_PATH}/logs.txt"
23+
/bin/bash -c 'tools/scripts/renode-test-update.sh "$@" > '"${DOCKER_TEST_RESULTS_PATH}"'/logs.txt 2>&1' -- "$@"
2424
then
2525
echo "FAILED"
2626
exit_code=1

0 commit comments

Comments
 (0)