Skip to content

Commit 1986cd2

Browse files
authored
[-] fix error message for incorrect --config param value, fixes #351 (#352)
When `NewConfig()` fails, `log.Fatal(err)` was called on the no-op logger, which exits with code 1 but silently drops the message.
1 parent 07401fc commit 1986cd2

1 file changed

Lines changed: 3 additions & 4 deletions

File tree

main.go

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -21,8 +21,6 @@ var (
2121
date = "unknown"
2222
)
2323

24-
var log *zap.SugaredLogger = zap.L().Sugar()
25-
2624
func main() {
2725
if (len(os.Args) > 1) && (os.Args[1] == "--version") {
2826
fmt.Printf("version: %s\n", version)
@@ -33,9 +31,10 @@ func main() {
3331

3432
conf, err := vipconfig.NewConfig()
3533
if err != nil {
36-
log.Fatal(err)
34+
fmt.Fprintln(os.Stderr, err)
35+
os.Exit(1)
3736
}
38-
log = conf.Logger.Sugar()
37+
log := conf.Logger.Sugar()
3938
defer func() { _ = conf.Logger.Sync() }()
4039

4140
lc, err := checker.NewLeaderChecker(conf)

0 commit comments

Comments
 (0)