make linter happy

Author: pashagolub

cmd/convert_metrics/convert_metrics.go

@@ -55,12 +55,6 @@ const (
 	PresetConfigYAMLFile      = "preset-configs.yaml"
 )
 
-// VersionToInt parses a given version and returns an integer  or
-// an error if unable to parse the version. Only parses valid semantic versions.
-// Performs checking that can find errors within the version.
-// Examples: v1.2 -> 01_02_00, v9.6.3 -> 09_06_03, v11 -> 11_00_00
-var regVer = regexp.MustCompile(`(\d+).?(\d*).?(\d*)`)
-
 // expected is following structure: metric_name/pg_ver/metric(_master|standby).sql
 func ReadMetricsFromFolder(folder string) (metricsMap Metrics, err error) {
 	metricFolders, err := os.ReadDir(folder)
@@ -220,10 +214,10 @@ new_helper:
 func getArgs(src *string, dst *string) (err error) {
 	flag.Parse()
 	if src == nil || *src == "" {
-		err = errors.New("Error: src option is required")
+		err = errors.New("-src option is required")
 	}
 	if dst == nil || *dst == "" {
-		err = errors.Join(err, errors.New("Error: dst option is required"))
+		err = errors.Join(err, errors.New("-dst option is required"))
 	}
 	if err != nil {
 		fmt.Println(err)

cmd/convert_metrics/convert_metrics_test.go

@@ -57,14 +57,14 @@ func downloadAndExtractMetrics(t *testing.T, dest string) string {
 			rel := strings.TrimPrefix(f.Name, metricsRoot)
 			if rel == "" {
 				extracted = filepath.Join(dest, "metrics")
-				os.MkdirAll(extracted, 0755)
+				_ = os.MkdirAll(extracted, 0755)
 				continue
 			}
 			path := filepath.Join(dest, "metrics", rel)
 			if f.FileInfo().IsDir() {
-				os.MkdirAll(path, 0755)
+				_ = os.MkdirAll(path, 0755)
 			} else {
-				os.MkdirAll(filepath.Dir(path), 0755)
+				_ = os.MkdirAll(filepath.Dir(path), 0755)
 				out, err := os.Create(path)
 				if err != nil {
 					t.Fatalf("failed to create file: %v", err)
@@ -74,9 +74,9 @@ func downloadAndExtractMetrics(t *testing.T, dest string) string {
 					out.Close()
 					t.Fatalf("failed to open file in zip: %v", err)
 				}
-				io.Copy(out, rc)
-				out.Close()
-				rc.Close()
+				_, _ = io.Copy(out, rc)
+				_ = out.Close()
+				_ = rc.Close()
 			}
 		}
 	}