add coverage

Author: pashagolub

internal/pgengine/bootstrap_test.go

@@ -17,6 +17,14 @@ import (
 	"github.com/stretchr/testify/assert"
 )
 
+func anyArgs(i int) []any {
+	args := make([]any, i)
+	for j := range i {
+		args[j] = pgxmock.AnyArg()
+	}
+	return args
+}
+
 func TestExecuteSchemaScripts(t *testing.T) {
 	initmockdb(t)
 	defer mockPool.Close()
@@ -146,6 +154,87 @@ func TestTryLockClientName(t *testing.T) {
 	})
 }
 
+func TestCreateChainFromYamlErrors(t *testing.T) {
+	initmockdb(t)
+	defer mockPool.Close()
+	mockpge := pgengine.NewDB(mockPool, "pgengine_unit_test")
+
+	t.Run("Database error during chain creation", func(t *testing.T) {
+		mockPool.ExpectQuery(`INSERT INTO timetable.chain`).
+			WithArgs(anyArgs(9)...).
+			WillReturnError(fmt.Errorf("simulated DB error"))
+		_, err := mockpge.CreateChainFromYaml(ctx, &pgengine.YamlChain{})
+		assert.Error(t, err)
+		assert.NoError(t, mockPool.ExpectationsWereMet())
+	})
+
+	t.Run("Database error during task creation", func(t *testing.T) {
+		mockPool.ExpectQuery(`INSERT INTO timetable.chain`).
+			WithArgs(anyArgs(9)...).
+			WillReturnRows(pgxmock.NewRows([]string{"chain_id"}).AddRow(1))
+		mockPool.ExpectQuery(`INSERT INTO timetable.task`).
+			WithArgs(anyArgs(10)...).
+			WillReturnError(fmt.Errorf("simulated DB error on task"))
+
+		_, err := mockpge.CreateChainFromYaml(ctx, &pgengine.YamlChain{
+			Chain:    pgengine.Chain{ChainName: "test-chain"},
+			Schedule: "0 0 * * *",
+			Tasks: []pgengine.YamlTask{
+				{ChainTask: pgengine.ChainTask{Command: "SELECT 1", Kind: "SQL"}},
+			},
+		})
+		assert.Error(t, err)
+		assert.NoError(t, mockPool.ExpectationsWereMet())
+	})
+
+	t.Run("Database error during parameter unmarshalling", func(t *testing.T) {
+		mockPool.ExpectQuery(`INSERT INTO timetable.chain`).
+			WithArgs(anyArgs(9)...).
+			WillReturnRows(pgxmock.NewRows([]string{"chain_id"}).AddRow(1))
+		mockPool.ExpectQuery(`INSERT INTO timetable.task`).
+			WithArgs(anyArgs(10)...).
+			WillReturnRows(pgxmock.NewRows([]string{"task_id"}).AddRow(1))
+
+		_, err := mockpge.CreateChainFromYaml(ctx, &pgengine.YamlChain{
+			Chain:    pgengine.Chain{ChainName: "test-chain"},
+			Schedule: "0 0 * * *",
+			Tasks: []pgengine.YamlTask{
+				{
+					ChainTask:  pgengine.ChainTask{Command: "SELECT 1", Kind: "SQL"},
+					Parameters: []any{func() {}}, // functions cannot be marshalled to JSON
+				},
+			},
+		})
+		assert.Error(t, err)
+		assert.NoError(t, mockPool.ExpectationsWereMet())
+	})
+
+	t.Run("Database error during parameter creation", func(t *testing.T) {
+		mockPool.ExpectQuery(`INSERT INTO timetable.chain`).
+			WithArgs(anyArgs(9)...).
+			WillReturnRows(pgxmock.NewRows([]string{"chain_id"}).AddRow(1))
+		mockPool.ExpectQuery(`INSERT INTO timetable.task`).
+			WithArgs(anyArgs(10)...).
+			WillReturnRows(pgxmock.NewRows([]string{"task_id"}).AddRow(1))
+		mockPool.ExpectExec(`INSERT INTO timetable.parameter`).
+			WithArgs(anyArgs(3)...).
+			WillReturnError(fmt.Errorf("simulated DB error on parameter"))
+
+		_, err := mockpge.CreateChainFromYaml(ctx, &pgengine.YamlChain{
+			Chain:    pgengine.Chain{ChainName: "test-chain"},
+			Schedule: "0 0 * * *",
+			Tasks: []pgengine.YamlTask{
+				{
+					ChainTask:  pgengine.ChainTask{Command: "SELECT 1", Kind: "SQL"},
+					Parameters: []any{"foo"},
+				},
+			},
+		})
+		assert.Error(t, err)
+		assert.NoError(t, mockPool.ExpectationsWereMet())
+	})
+}
+
 func TestExecuteFileScript(t *testing.T) {
 	initmockdb(t)
 	defer mockPool.Close()
@@ -154,14 +243,6 @@ func TestExecuteFileScript(t *testing.T) {
 	// Create temporary directory for test files
 	tmpDir := t.TempDir()
 
-	anyArgs := func(i int) []any {
-		args := make([]any, i)
-		for j := range i {
-			args[j] = pgxmock.AnyArg()
-		}
-		return args
-	}
-
 	t.Run("SQL file execution", func(t *testing.T) {
 		// Create temporary SQL file
 		sqlFile := filepath.Join(tmpDir, "test.sql")

internal/pgengine/yaml.go

@@ -59,7 +59,7 @@ func (pge *PgEngine) LoadYamlChains(ctx context.Context, filePath string, replac
 		}
 
 		// Multi-task chain - use direct SQL
-		chainID, err := pge.createChainFromYaml(ctx, &yamlChain)
+		chainID, err := pge.CreateChainFromYaml(ctx, &yamlChain)
 		if err != nil {
 			return fmt.Errorf("failed to create multi-task chain %s: %w", yamlChain.ChainName, err)
 		}
@@ -70,8 +70,8 @@ func (pge *PgEngine) LoadYamlChains(ctx context.Context, filePath string, replac
 	return nil
 }
 
-// createChainFromYaml creates a multi-task chain using direct SQL inserts
-func (pge *PgEngine) createChainFromYaml(ctx context.Context, yamlChain *YamlChain) (int64, error) {
+// CreateChainFromYaml creates a multi-task chain using direct SQL inserts
+func (pge *PgEngine) CreateChainFromYaml(ctx context.Context, yamlChain *YamlChain) (int64, error) {
 	// Insert chain
 	var chainID int64
 	err := pge.ConfigDb.QueryRow(ctx, `INSERT INTO timetable.chain (
@@ -121,13 +121,13 @@ func (pge *PgEngine) createChainFromYaml(ctx context.Context, yamlChain *YamlCha
 		if len(task.Parameters) > 0 {
 			for paramIndex, param := range task.Parameters {
 				orderID := paramIndex + 1
-				
+
 				// Convert parameter to JSON for JSONB storage
 				jsonValue, err := json.Marshal(param)
 				if err != nil {
 					return 0, fmt.Errorf("failed to marshal parameter %d to JSON: %w", orderID, err)
 				}
-				
+
 				_, err = pge.ConfigDb.Exec(ctx,
 					"INSERT INTO timetable.parameter (task_id, order_id, value) VALUES ($1, $2, $3::jsonb)",
 					taskID, orderID, string(jsonValue))
@@ -258,5 +258,3 @@ func ParseYamlFile(filePath string) (*YamlConfig, error) {
 
 	return &config, nil
 }
-
-

internal/pgengine/yaml_test.go

@@ -254,6 +254,11 @@ func TestParseYamlFile(t *testing.T) {
 		assert.Contains(t, err.Error(), "file not found")
 	})
 
+	t.Run("File cannot be read", func(t *testing.T) {
+		_, err := pgengine.ParseYamlFile(".")
+		assert.Error(t, err)
+	})
+
 	t.Run("Invalid YAML syntax", func(t *testing.T) {
 		invalidYaml := `chains:
   - name: "test"