MB-71838: Replace std::filesystem::remove_all

Replace all instances of std::filesystem::remove_all() with the custom
cb::io::remove_with_retry() function across test and benchmark
files. This provides better retry behavior and error handling for
directory removal operations.

Change-Id: I14aebd07d793133394b6815caedfe10d036d9409
Reviewed-on: https://review.couchbase.org/c/kv_engine/+/244909
Tested-by: Build Bot <build@couchbase.com>
Reviewed-by: Jim Walker <jim@couchbase.com>

Author: trondn

auditd/tests/auditconfig_test.cc

@@ -23,7 +23,7 @@ class AuditConfigTest : public ::testing::Test {
     }
 
     static void TearDownTestCase() {
-        std::filesystem::remove_all(testdir);
+        cb::io::remove_with_retry(testdir);
     }
 
     nlohmann::json json;

auditd/tests/auditfile_test.cc

@@ -40,7 +40,7 @@ class AuditFileTest : public ::testing::Test {
     }
 
     void TearDown() override {
-        std::filesystem::remove_all(testdir);
+        cb::io::remove_with_retry(testdir);
     }
 
     nlohmann::json create_audit_event() {

daemon/bucket_manager_test.cc

@@ -36,7 +36,7 @@ class BucketManagerTest : public ::testing::Test, public BucketManager {
     }
 
     void TearDown() override {
-        remove_all(bucketPath);
+        cb::io::remove_with_retry(bucketPath);
     }
 
     static void SetUpTestSuite() {
@@ -52,7 +52,7 @@ class BucketManagerTest : public ::testing::Test, public BucketManager {
             if (is_directory(p.path(), ec)) {
                 if (p.path().filename().string().starts_with(
                             "BucketManagerTest")) {
-                    remove_all(p.path(), ec);
+                    cb::io::remove_with_retry(p.path(), ec);
                 }
             }
         }

daemon/bucket_metering_stats_test.cc

@@ -36,7 +36,7 @@ class BucketMeteringStatsTest : public ::testing::Test {
             if (is_directory(p.path(), ec)) {
                 if (p.path().filename().string().starts_with(
                             "BucketMeteringStatsTest")) {
-                    remove_all(p.path(), ec);
+                    cb::io::remove_with_retry(p.path(), ec);
                 }
             }
         }
@@ -63,7 +63,7 @@ class BucketMeteringStatsTest : public ::testing::Test {
 
     void TearDown() override {
         BucketManager::instance().destroyAll();
-        remove_all(bucketPath);
+        cb::io::remove_with_retry(bucketPath);
     }
 
     Bucket* bucket = nullptr;

daemon/bucket_stats_test.cc

@@ -35,7 +35,7 @@ class BucketStatsTest : public ::testing::Test {
     void TearDown() override {
         // destroy the bucket which was created for this test
         BucketManager::instance().doBlockingDestroy(cookie, "foobar", true, {});
-        remove_all(bucketPath);
+        cb::io::remove_with_retry(bucketPath);
     }
 
     Bucket* bucket = nullptr;

engines/ep/benchmarks/engine_fixture.cc

@@ -55,7 +55,7 @@ void EngineFixture::TearDown(const benchmark::State& state) {
         engine->getDcpConnMap().manageConnections();
         engine.reset();
         ExecutorPool::shutdown();
-        std::filesystem::remove_all("benchmarks-test");
+        cb::io::remove_with_retry("benchmarks-test");
     }
     ObjectRegistry::onSwitchThread(nullptr);
 }

engines/ep/benchmarks/kvstore_bench.cc

@@ -107,7 +107,7 @@ class KVStoreBench : public benchmark::Fixture {
                 gsl::narrow_cast<uint16_t>(workload.getNumShards()),
                 shardId);
 
-        std::filesystem::remove_all(kvstoreConfig->getDBName());
+        cb::io::remove_with_retry(kvstoreConfig->getDBName());
         std::filesystem::create_directories(kvstoreConfig->getDBName());
         kvstore = setup_kv_store(*kvstoreConfig);
 
@@ -135,7 +135,7 @@ class KVStoreBench : public benchmark::Fixture {
 
     void TearDown(const benchmark::State& state) override {
         kvstore.reset();
-        std::filesystem::remove_all(kvstoreConfig->getDBName());
+        cb::io::remove_with_retry(kvstoreConfig->getDBName());
     }
 
 private:

engines/ep/src/access_scanner.cc

@@ -72,7 +72,7 @@ ItemAccessVisitor::ItemAccessVisitor(
         // (e.g. due to a crash). We *don't* want to use the common
         // method removeFile, as we can't continue running the visitor
         // if we failed to remove the file.
-        std::filesystem::remove_all(next);
+        cb::io::remove_with_retry(next);
     } catch (const std::exception& e) {
         EP_LOG_WARN_CTX("Failed to remove existing access log",
                         {"path", next},

engines/ep/tests/ep_testsuite.cc

@@ -8130,7 +8130,7 @@ static test_result test_reader_thread_starvation_warmup(EngineIface* h) {
     verify_curr_items(slowBucket, keysPerVbucket, "after warmup");
     // 12. Ensure the buckets are destroyed and shutdown at the end of the test
     testHarness->destroy_bucket(smallBucket, true);
-    std::filesystem::remove_all(smallBucketDir);
+    cb::io::remove_with_retry(smallBucketDir);
     testHarness->destroy_bucket(slowBucket, true);
     return SUCCESS;
 }

engines/ep/tests/ep_testsuite_common.cc

@@ -119,7 +119,7 @@ static enum test_result skipped_test_function(EngineIface*) {
 }
 
 enum test_result rmdb(std::string_view path) {
-    std::filesystem::remove_all(path);
+    cb::io::remove_with_retry(path);
     return SUCCESS;
 }