PYCBC-1782: MutateInResult content_as() raises TypeError

Changes
--------
* Pass in default transcoder and `is_subdoc=True` when building a
  `MutateInResult`
* Add tests to confirm `MutateInResult.content_as(...)` does not raise
  `TypeError`

Change-Id: I892a82744a5121432afc9eb20d2a2a7664261784
Reviewed-on: https://review.couchbase.org/c/couchbase-python-client/+/248674
Reviewed-by: Dimitris Christodoulou <dimitris.christodoulou@couchbase.com>
Tested-by: Build Bot <build@couchbase.com>

Author: thejcfactor

acouchbase/logic/collection_impl.py

@@ -234,7 +234,8 @@ async def lookup_in_any_replica(self,
     async def mutate_in(self, req: PycbcCoreKeyValueRequest, obs_handler: ObservableRequestHandler) -> MutateInResult:
         await self.wait_until_bucket_connected()
         ret = await self.client_adapter.execute_collection_request(req.opcode, req, obs_handler=obs_handler)
-        return MutateInResult(ret, key=req.key)
+        transcoder = self._collection_details.default_transcoder
+        return MutateInResult(ret, transcoder=transcoder, is_subdoc=True, key=req.key)
 
     async def prepend(self, req: PycbcCoreKeyValueRequest, obs_handler: ObservableRequestHandler) -> MutationResult:
         await self.wait_until_bucket_connected()

acouchbase/tests/subdoc_t.py

@@ -64,6 +64,8 @@ class SubDocumentTestSuite:
         'test_decrement_create_parents',
         'test_increment',
         'test_increment_create_parents',
+        'test_increment_result_content',
+        'test_decrement_result_content',
         'test_insert_create_parents',
         'test_lookup_in_all_replicas_bad_key',
         'test_lookup_in_all_replicas_exists',
@@ -356,6 +358,22 @@ async def test_increment_create_parents(self, cb_env):
         result = await cb_env.collection.get(key)
         assert result.content_as[dict]['new']['counter'] == 100
 
+    @pytest.mark.asyncio
+    async def test_increment_result_content(self, cb_env):
+        key = cb_env.get_existing_doc_by_type('count', key_only=True)
+        result = await cb_env.collection.mutate_in(
+            key, (SD.increment('count', 50),))
+        assert isinstance(result, MutateInResult)
+        assert result.content_as[int](0) == 150
+
+    @pytest.mark.asyncio
+    async def test_decrement_result_content(self, cb_env):
+        key = cb_env.get_existing_doc_by_type('count', key_only=True)
+        result = await cb_env.collection.mutate_in(
+            key, (SD.decrement('count', 50),))
+        assert isinstance(result, MutateInResult)
+        assert result.content_as[int](0) == 50
+
     @pytest.mark.asyncio
     async def test_insert_create_parents(self, cb_env):
         key = cb_env.get_existing_doc_by_type('array', key_only=True)

couchbase/logic/collection_impl.py

@@ -330,7 +330,8 @@ def mutate_in(self,
                   req: PycbcCoreKeyValueRequest,
                   obs_handler: ObservableRequestHandler) -> MutateInResult:
         ret = self._client_adapter.execute_collection_request(req.opcode, req, obs_handler=obs_handler)
-        return MutateInResult(ret, key=req.key)
+        transcoder = self._collection_details.default_transcoder
+        return MutateInResult(ret, transcoder=transcoder, is_subdoc=True, key=req.key)
 
     def prepend(self,
                 req: PycbcCoreKeyValueRequest,

couchbase/result.py

@@ -598,8 +598,10 @@ class MutationResult(Result):
     def __init__(self,
                  orig,  # type: pycbc_result
                  key=None,        # type: Optional[str]
+                 transcoder=None,  # type: Optional[Transcoder]
+                 is_subdoc=None,  # type: Optional[bool]
                  ):
-        super().__init__(orig, key=key)
+        super().__init__(orig, key=key, transcoder=transcoder, is_subdoc=is_subdoc)
         self._raw_mutation_token = self._orig.raw_result.get('token', None)
         self._mutation_token = None
 

couchbase/tests/subdoc_t.py

@@ -68,6 +68,8 @@ class SubDocumentTestSuite:
         'test_decrement_create_parents',
         'test_increment',
         'test_increment_create_parents',
+        'test_increment_result_content',
+        'test_decrement_result_content',
         'test_insert_create_parents',
         'test_lookup_in_all_replicas_bad_key',
         'test_lookup_in_all_replicas_exists',
@@ -459,6 +461,20 @@ def test_increment_create_parents(self, cb_env):
         result = cb_env.collection.get(key)
         assert result.content_as[dict]['new']['counter'] == 100
 
+    def test_increment_result_content(self, cb_env):
+        key = cb_env.get_existing_doc_by_type('count', key_only=True)
+        result = cb_env.collection.mutate_in(
+            key, (SD.increment('count', 50),))
+        assert isinstance(result, MutateInResult)
+        assert result.content_as[int](0) == 150
+
+    def test_decrement_result_content(self, cb_env):
+        key = cb_env.get_existing_doc_by_type('count', key_only=True)
+        result = cb_env.collection.mutate_in(
+            key, (SD.decrement('count', 50),))
+        assert isinstance(result, MutateInResult)
+        assert result.content_as[int](0) == 50
+
     def test_insert_create_parents(self, cb_env):
         key = cb_env.get_existing_doc_by_type('array', key_only=True)
         result = cb_env.collection.mutate_in(