Skip to content

Commit cbef716

Browse files
vgvassilevvgvassilev
authored
Do not skip tests for valgrind. (#922)
1 parent fb595ac commit cbef716

7 files changed

Lines changed: 0 additions & 56 deletions

File tree

‎unittests/CppInterOp/FunctionReflectionTest.cpp‎

Lines changed: 0 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -702,8 +702,6 @@ TYPED_TEST(CPPINTEROP_TEST_MODE, FunctionReflection_ExistsFunctionTemplate) {
702702

703703
TYPED_TEST(CPPINTEROP_TEST_MODE,
704704
FunctionReflection_InstantiateTemplateFunctionFromString) {
705-
if (llvm::sys::RunningOnValgrind())
706-
GTEST_SKIP() << "XFAIL due to Valgrind report";
707705
std::vector<const char*> interpreter_args = { "-include", "new" };
708706
TestFixture::CreateInterpreter(interpreter_args);
709707
std::string code = R"(#include <memory>)";
@@ -763,8 +761,6 @@ TYPED_TEST(CPPINTEROP_TEST_MODE, FunctionReflection_InstantiateTemplateMethod) {
763761
}
764762

765763
TYPED_TEST(CPPINTEROP_TEST_MODE, FunctionReflection_LookupConstructors) {
766-
if (llvm::sys::RunningOnValgrind())
767-
GTEST_SKIP() << "XFAIL due to Valgrind report";
768764

769765
std::vector<Decl*> Decls;
770766
std::string code = R"(
@@ -804,8 +800,6 @@ TYPED_TEST(CPPINTEROP_TEST_MODE, FunctionReflection_LookupConstructors) {
804800
}
805801

806802
TYPED_TEST(CPPINTEROP_TEST_MODE, FunctionReflection_GetClassTemplatedMethods) {
807-
if (llvm::sys::RunningOnValgrind())
808-
GTEST_SKIP() << "XFAIL due to Valgrind report";
809803

810804
std::vector<Decl*> Decls;
811805
std::string code = R"(
@@ -1543,8 +1537,6 @@ TYPED_TEST(CPPINTEROP_TEST_MODE, FunctionReflection_IsStaticMethod) {
15431537
}
15441538

15451539
TYPED_TEST(CPPINTEROP_TEST_MODE, FunctionReflection_GetFunctionAddress) {
1546-
if (llvm::sys::RunningOnValgrind())
1547-
GTEST_SKIP() << "XFAIL due to Valgrind report";
15481540
#ifdef _WIN32
15491541
GTEST_SKIP() << "Disabled on Windows. Needs fixing.";
15501542
#endif
@@ -1615,8 +1607,6 @@ TYPED_TEST(CPPINTEROP_TEST_MODE, FunctionReflection_JitCallAdvanced) {
16151607
#if CLANG_VERSION_MAJOR == 20 && defined(CPPINTEROP_USE_CLING) && defined(_WIN32)
16161608
GTEST_SKIP() << "Test fails with Cling on Windows";
16171609
#endif
1618-
if (llvm::sys::RunningOnValgrind())
1619-
GTEST_SKIP() << "XFAIL due to Valgrind report";
16201610

16211611
if (TypeParam::isOutOfProcess)
16221612
GTEST_SKIP() << "Test fails for OOP JIT builds";
@@ -1661,8 +1651,6 @@ TYPED_TEST(CPPINTEROP_TEST_MODE, FunctionReflection_JitCallAdvanced) {
16611651
#if !defined(NDEBUG) && GTEST_HAS_DEATH_TEST
16621652
#ifndef _WIN32 // Death tests do not work on Windows
16631653
TYPED_TEST(CPPINTEROP_TEST_MODE, FunctionReflection_JitCallDebug) {
1664-
if (llvm::sys::RunningOnValgrind())
1665-
GTEST_SKIP() << "XFAIL due to Valgrind report";
16661654

16671655
if (TypeParam::isOutOfProcess)
16681656
GTEST_SKIP() << "Test fails for OOP JIT builds";
@@ -1767,8 +1755,6 @@ TYPED_TEST(CPPINTEROP_TEST_MODE, FunctionReflection_GetFunctionCallWrapper) {
17671755
#ifdef EMSCRIPTEN
17681756
GTEST_SKIP() << "Test fails for Emscipten builds";
17691757
#endif
1770-
if (llvm::sys::RunningOnValgrind())
1771-
GTEST_SKIP() << "XFAIL due to Valgrind report";
17721758
#if defined(CPPINTEROP_USE_CLING) && defined(_WIN32)
17731759
GTEST_SKIP() << "Disabled, invoking functions containing printf does not work with Cling on Windows";
17741760
#endif
@@ -2425,8 +2411,6 @@ TYPED_TEST(CPPINTEROP_TEST_MODE, FunctionReflection_GetFunctionArgDefault) {
24252411
}
24262412

24272413
TYPED_TEST(CPPINTEROP_TEST_MODE, FunctionReflection_Construct) {
2428-
if (llvm::sys::RunningOnValgrind())
2429-
GTEST_SKIP() << "XFAIL due to Valgrind report";
24302414
#ifdef _WIN32
24312415
GTEST_SKIP() << "Disabled on Windows. Needs fixing.";
24322416
#endif
@@ -2513,8 +2497,6 @@ TYPED_TEST(CPPINTEROP_TEST_MODE, FunctionReflection_Construct) {
25132497

25142498
// Test zero initialization of PODs and default initialization cases
25152499
TYPED_TEST(CPPINTEROP_TEST_MODE, FunctionReflection_ConstructPOD) {
2516-
if (llvm::sys::RunningOnValgrind())
2517-
GTEST_SKIP() << "XFAIL due to Valgrind report";
25182500
#ifdef _WIN32
25192501
GTEST_SKIP() << "Disabled on Windows. Needs fixing.";
25202502
#endif
@@ -2555,8 +2537,6 @@ TYPED_TEST(CPPINTEROP_TEST_MODE, FunctionReflection_ConstructPOD) {
25552537

25562538
// Test nested constructor calls
25572539
TYPED_TEST(CPPINTEROP_TEST_MODE, FunctionReflection_ConstructNested) {
2558-
if (llvm::sys::RunningOnValgrind())
2559-
GTEST_SKIP() << "XFAIL due to Valgrind report";
25602540
#ifdef _WIN32
25612541
GTEST_SKIP() << "Disabled on Windows. Needs fixing.";
25622542
#endif
@@ -2618,8 +2598,6 @@ TYPED_TEST(CPPINTEROP_TEST_MODE, FunctionReflection_ConstructArray) {
26182598
#if defined(EMSCRIPTEN)
26192599
GTEST_SKIP() << "Test fails for Emscripten builds";
26202600
#endif
2621-
if (llvm::sys::RunningOnValgrind())
2622-
GTEST_SKIP() << "XFAIL due to Valgrind report";
26232601
#ifdef _WIN32
26242602
GTEST_SKIP() << "Disabled on Windows. Needs fixing.";
26252603
#endif
@@ -2672,8 +2650,6 @@ TYPED_TEST(CPPINTEROP_TEST_MODE, FunctionReflection_Destruct) {
26722650
#ifdef EMSCRIPTEN
26732651
GTEST_SKIP() << "Test fails for Emscipten builds";
26742652
#endif
2675-
if (llvm::sys::RunningOnValgrind())
2676-
GTEST_SKIP() << "XFAIL due to Valgrind report";
26772653

26782654
#ifdef _WIN32
26792655
GTEST_SKIP() << "Disabled on Windows. Needs fixing.";
@@ -2745,8 +2721,6 @@ TYPED_TEST(CPPINTEROP_TEST_MODE, FunctionReflection_DestructArray) {
27452721
#ifdef EMSCRIPTEN
27462722
GTEST_SKIP() << "Test fails for Emscipten builds";
27472723
#endif
2748-
if (llvm::sys::RunningOnValgrind())
2749-
GTEST_SKIP() << "XFAIL due to Valgrind report";
27502724

27512725
#ifdef _WIN32
27522726
GTEST_SKIP() << "Disabled on Windows. Needs fixing.";

‎unittests/CppInterOp/InterpreterTest.cpp‎

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -68,8 +68,6 @@ TYPED_TEST(CPPINTEROP_TEST_MODE, Interpreter_Evaluate) {
6868
#ifdef _WIN32
6969
GTEST_SKIP() << "Disabled on Windows. Needs fixing.";
7070
#endif
71-
if (llvm::sys::RunningOnValgrind())
72-
GTEST_SKIP() << "XFAIL due to Valgrind report";
7371
if (TypeParam::isOutOfProcess)
7472
GTEST_SKIP() << "Test fails for OOP JIT builds";
7573
// EXPECT_TRUE(Cpp::Evaluate(I, "") == 0);
@@ -157,8 +155,6 @@ TYPED_TEST(CPPINTEROP_TEST_MODE, Interpreter_Process) {
157155
#endif
158156
if (TypeParam::isOutOfProcess)
159157
GTEST_SKIP() << "Test fails for OOP JIT builds";
160-
if (llvm::sys::RunningOnValgrind())
161-
GTEST_SKIP() << "XFAIL due to Valgrind report";
162158
std::vector<const char*> interpreter_args = { "-include", "new", "-Xclang", "-iwithsysroot/include/compat" };
163159
auto* I = TestFixture::CreateInterpreter(interpreter_args);
164160
EXPECT_TRUE(Cpp::Process("") == 0);
@@ -427,8 +423,6 @@ TYPED_TEST(CPPINTEROP_TEST_MODE, Interpreter_GetLanguageStandardGNU) {
427423

428424
TYPED_TEST(CPPINTEROP_TEST_MODE, Interpreter_ExternalInterpreter) {
429425

430-
if (llvm::sys::RunningOnValgrind())
431-
GTEST_SKIP() << "XFAIL due to Valgrind report";
432426

433427
#ifndef CPPINTEROP_USE_CLING
434428
llvm::ExitOnError ExitOnErr;

‎unittests/CppInterOp/JitTest.cpp‎

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -15,8 +15,6 @@ TYPED_TEST(CPPINTEROP_TEST_MODE, Jit_InsertOrReplaceJitSymbol) {
1515
#ifdef EMSCRIPTEN
1616
GTEST_SKIP() << "Test fails for Emscipten builds";
1717
#endif
18-
if (llvm::sys::RunningOnValgrind())
19-
GTEST_SKIP() << "XFAIL due to Valgrind report";
2018
#ifdef _WIN32
2119
GTEST_SKIP() << "Disabled on Windows. Needs fixing.";
2220
#endif
@@ -79,8 +77,6 @@ TYPED_TEST(CPPINTEROP_TEST_MODE, Jit_StreamRedirectJIT) {
7977
#ifdef EMSCRIPTEN
8078
GTEST_SKIP() << "Test fails for Emscipten builds";
8179
#endif
82-
if (llvm::sys::RunningOnValgrind())
83-
GTEST_SKIP() << "XFAIL due to Valgrind report";
8480
#ifdef _WIN32
8581
GTEST_SKIP() << "Disabled on Windows. Needs fixing.";
8682
#endif

‎unittests/CppInterOp/ScopeReflectionTest.cpp‎

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -13,8 +13,6 @@
1313
#include "clang/Frontend/CompilerInstance.h"
1414
#include "clang/Sema/Sema.h"
1515

16-
#include "llvm/Support/Valgrind.h"
17-
1816
#include "gtest/gtest.h"
1917

2018
#include <memory>
@@ -1066,8 +1064,6 @@ template<typename T> T TrivialFnTemplate() { return T(); }
10661064

10671065
TYPED_TEST(CPPINTEROP_TEST_MODE,
10681066
ScopeReflection_InstantiateTemplateFunctionFromString) {
1069-
if (llvm::sys::RunningOnValgrind())
1070-
GTEST_SKIP() << "XFAIL due to Valgrind report";
10711067
std::vector<const char*> interpreter_args = {"-include", "new"};
10721068
TestFixture::CreateInterpreter(interpreter_args);
10731069
std::string code = R"(#include <memory>)";
@@ -1212,8 +1208,6 @@ TYPED_TEST(CPPINTEROP_TEST_MODE,
12121208
}
12131209

12141210
TYPED_TEST(CPPINTEROP_TEST_MODE, ScopeReflection_IncludeVector) {
1215-
if (llvm::sys::RunningOnValgrind())
1216-
GTEST_SKIP() << "XFAIL due to Valgrind report";
12171211
std::string code = R"(
12181212
#include <vector>
12191213
#include <iostream>
@@ -1224,8 +1218,6 @@ TYPED_TEST(CPPINTEROP_TEST_MODE, ScopeReflection_IncludeVector) {
12241218
}
12251219

12261220
TYPED_TEST(CPPINTEROP_TEST_MODE, ScopeReflection_GetOperator) {
1227-
if (llvm::sys::RunningOnValgrind())
1228-
GTEST_SKIP() << "XFAIL due to Valgrind report";
12291221

12301222
TestFixture::CreateInterpreter();
12311223

‎unittests/CppInterOp/TypeReflectionTest.cpp‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -558,8 +558,6 @@ TYPED_TEST(CPPINTEROP_TEST_MODE, TypeReflection_IsSmartPtrType) {
558558
#if CLANG_VERSION_MAJOR == 20 && defined(CPPINTEROP_USE_CLING) && defined(_WIN32)
559559
GTEST_SKIP() << "Test fails with Cling on Windows";
560560
#endif
561-
if (llvm::sys::RunningOnValgrind())
562-
GTEST_SKIP() << "XFAIL due to Valgrind report";
563561

564562
std::vector<const char*> interpreter_args = {"-include", "new"};
565563
TestFixture::CreateInterpreter(interpreter_args);

‎unittests/CppInterOp/Utils.h‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,8 +9,6 @@
99
#include "CppInterOp/CppInterOp.h"
1010
#define CPPINTEROP_TEST_MODE CppInterOpTest
1111

12-
#include "llvm/Support/Valgrind.h"
13-
1412
#include <memory>
1513
#include <string>
1614
#include <utility>

‎unittests/CppInterOp/VariableReflectionTest.cpp‎

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -117,8 +117,6 @@ TYPED_TEST(CPPINTEROP_TEST_MODE, VariableReflection_DatamembersWithAnonymousStru
117117
#if CLANG_VERSION_MAJOR == 20 && defined(CPPINTEROP_USE_CLING) && defined(_WIN32)
118118
GTEST_SKIP() << "Test fails with Cling on Windows";
119119
#endif
120-
if (llvm::sys::RunningOnValgrind())
121-
GTEST_SKIP() << "XFAIL due to Valgrind report";
122120

123121
std::vector<Decl*> Decls;
124122
#define Stringify(s) Stringifyx(s)
@@ -168,8 +166,6 @@ TYPED_TEST(CPPINTEROP_TEST_MODE, VariableReflection_DatamembersWithAnonymousStru
168166
}
169167

170168
TYPED_TEST(CPPINTEROP_TEST_MODE, VariableReflection_GetTypeAsString) {
171-
if (llvm::sys::RunningOnValgrind())
172-
GTEST_SKIP() << "XFAIL due to Valgrind report";
173169

174170
std::string code = R"(
175171
namespace my_namespace {
@@ -385,8 +381,6 @@ TYPED_TEST(CPPINTEROP_TEST_MODE, VariableReflection_VariableOffsetsWithInheritan
385381
#if CLANG_VERSION_MAJOR == 20 && defined(CPPINTEROP_USE_CLING) && defined(_WIN32)
386382
GTEST_SKIP() << "Test fails with Cling on Windows";
387383
#endif
388-
if (llvm::sys::RunningOnValgrind())
389-
GTEST_SKIP() << "XFAIL due to Valgrind report";
390384

391385
std::vector<const char*> interpreter_args = {"-include", "new"};
392386
TestFixture::CreateInterpreter(interpreter_args);
@@ -560,8 +554,6 @@ TYPED_TEST(CPPINTEROP_TEST_MODE,
560554
}
561555

562556
TYPED_TEST(CPPINTEROP_TEST_MODE, VariableReflection_StaticConstExprDatamember) {
563-
if (llvm::sys::RunningOnValgrind())
564-
GTEST_SKIP() << "XFAIL due to Valgrind report";
565557

566558
#ifdef _WIN32
567559
GTEST_SKIP() << "Disabled on Windows. Needs fixing.";

0 commit comments

Comments
 (0)