Skip to content

Commit d96fd5b

Browse files
committed
apply changes from the code review
1 parent b971015 commit d96fd5b

4 files changed

Lines changed: 5 additions & 6 deletions

File tree

src/Commands/ClearSettings.php

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@
44

55
use CodeIgniter\CLI\BaseCommand;
66
use CodeIgniter\CLI\CLI;
7+
use CodeIgniter\Settings\Config\Settings;
78

89
class ClearSettings extends BaseCommand
910
{
@@ -33,10 +34,8 @@ public function run(array $params)
3334

3435
/**
3536
* Gets a human-readable list of handler names.
36-
*
37-
* @param mixed $config
3837
*/
39-
private function getHandlerNames($config): ?string
38+
private function getHandlerNames(Settings $config): ?string
4039
{
4140
if ($config->handlers === []) {
4241
return null;

src/Handlers/ArrayHandler.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,7 @@ protected function hasStored(string $class, string $property, ?string $context):
6868
/**
6969
* Retrieves a value from storage.
7070
*
71-
* @return mixed|null
71+
* @return mixed
7272
*/
7373
protected function getStored(string $class, string $property, ?string $context)
7474
{

src/Handlers/DatabaseHandler.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@ public function has(string $class, string $property, ?string $context = null): b
5959
* read and stored the first call for each contexts
6060
* and then retrieved from storage.
6161
*
62-
* @return mixed|null
62+
* @return mixed
6363
*/
6464
public function get(string $class, string $property, ?string $context = null)
6565
{

src/Handlers/FileHandler.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@ public function has(string $class, string $property, ?string $context = null): b
5858
* To boost performance, all values are read and stored
5959
* on the first call for each class+context, then retrieved from storage.
6060
*
61-
* @return mixed|null
61+
* @return mixed
6262
*/
6363
public function get(string $class, string $property, ?string $context = null)
6464
{

0 commit comments

Comments
 (0)