Skip to content

Commit fefa1d9

Browse files
author
markw65
committed
Fix early exit from clearStacks
Fixes #12154
1 parent ab79c3b commit fefa1d9

3 files changed

Lines changed: 57 additions & 1 deletion

File tree

src/core/core.datasetController.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -217,7 +217,7 @@ function clearStacks(meta, items) {
217217
for (const parsed of items) {
218218
const stacks = parsed._stacks;
219219
if (!stacks || stacks[axis] === undefined || stacks[axis][datasetIndex] === undefined) {
220-
return;
220+
continue;
221221
}
222222
delete stacks[axis][datasetIndex];
223223
if (stacks[axis]._visualValues !== undefined && stacks[axis]._visualValues[datasetIndex] !== undefined) {
Lines changed: 56 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,56 @@
1+
function makeDs(label, offset) {
2+
return {
3+
label,
4+
data: [
5+
[0, 12],
6+
[1, 19],
7+
[2, 3],
8+
[2, 5],
9+
[3, 2],
10+
[4, 3],
11+
].map(([x, y]) => ({x, y: y === null ? null : y + offset})),
12+
showLine: true,
13+
spanGaps: false,
14+
stack: `stack${label}`,
15+
borderColor: label === 'A' ? '#c00' : '#00c'
16+
};
17+
}
18+
19+
const dsA = makeDs('A', 0);
20+
const dsB = makeDs('B', 1);
21+
22+
module.exports = {
23+
config: {
24+
type: 'scatter',
25+
data: {
26+
datasets: [dsA, dsB],
27+
},
28+
options: {
29+
scales: {
30+
x: {display: false},
31+
y: {display: false},
32+
},
33+
elements: {
34+
point: {
35+
backgroundColor: '#444',
36+
},
37+
},
38+
layout: {
39+
padding: {
40+
left: 24,
41+
right: 24,
42+
},
43+
},
44+
},
45+
},
46+
options: {
47+
canvas: {
48+
height: 128,
49+
width: 256,
50+
},
51+
async run(chart) {
52+
chart.data = {datasets: [dsB, dsA]};
53+
chart.update();
54+
}
55+
},
56+
};
8.55 KB
Loading

0 commit comments

Comments
 (0)