Skip to content
This repository was archived by the owner on Sep 14, 2020. It is now read-only.

Commit af8f87b

Browse files
Merge pull request #246 from bugsnag/kattrali/reduce-gratuitous-logging
refactor: Reduce gratuitous logging
2 parents 72cf650 + 0da6909 commit af8f87b

3 files changed

Lines changed: 10 additions & 9 deletions

File tree

CHANGELOG.md

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,14 @@
11
Changelog
22
=========
33

4+
5+
## TBD
6+
7+
### Bug fixes
8+
9+
* (android) Reduce gratutious android logging
10+
[#245](https://github.com/bugsnag/bugsnag-react-native/issues/245)
11+
412
## 2.9.5 (2018-05-31)
513

614
### Bug fixes
@@ -17,7 +25,6 @@ Changelog
1725
* Enforce requiring API key to initialise notifier
1826
[bugsnag-cocoa#280](https://github.com/bugsnag/bugsnag-cocoa/pull/280)
1927

20-
2128
## 2.9.4 (2018-05-02)
2229

2330
* Enable nativeSerializer to handle Error objects by extracting the stack and message from a given Error class before serialising it. [#239](https://github.com/bugsnag/bugsnag-react-native/issues/239) [#240](https://github.com/bugsnag/bugsnag-react-native/pull/240) [daisy1754](https://github.com/daisy1754) [Cawllec](https://github.com/Cawllec)

Makefile

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -39,6 +39,6 @@ ifeq ($(IOS_VERSION),)
3939
endif
4040
@git -C ../bugsnag-cocoa fetch
4141
@git -C ../bugsnag-cocoa checkout v$(IOS_VERSION)
42-
@rsync --delete -al ../bugsnag-cocoa/Source cocoa/vendor/bugsnag-cocoa/Source
43-
@rsync --delete -al ../bugsnag-cocoa/iOS cocoa/vendor/bugsnag-cocoa/iOS
42+
@rsync --delete -al ../bugsnag-cocoa/Source/ cocoa/vendor/bugsnag-cocoa/Source/
43+
@rsync --delete -al ../bugsnag-cocoa/iOS/ cocoa/vendor/bugsnag-cocoa/iOS/
4444
@git status

android/src/main/java/com/bugsnag/BugsnagReactNative.java

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -89,7 +89,6 @@ public void startWithOptions(ReadableMap options) {
8989
@ReactMethod
9090
public void leaveBreadcrumb(ReadableMap options) {
9191
String name = options.getString("name");
92-
logger.info(String.format("Leaving breadcrumb '%s'", name));
9392
Bugsnag.leaveBreadcrumb(name,
9493
parseBreadcrumbType(options.getString("type")),
9594
readStringMap(options.getMap("metadata")));
@@ -130,18 +129,14 @@ public void notifyBlocking(ReadableMap payload, boolean blocking, com.facebook.r
130129
map.put("severity", severity);
131130
map.put("severityReason", severityReason);
132131

133-
logger.info("Notifying native client, severity = " + severity +
134-
", severityReason = " + severityReason);
135132
Bugsnag.internalClientNotify(exc, map, blocking, handler);
136-
logger.info("Notified native client");
137133

138134
if (callback != null)
139135
callback.invoke();
140136
}
141137

142138
@ReactMethod
143139
public void setUser(ReadableMap userInfo) {
144-
logger.info("Setting user data");
145140
String userId = userInfo.hasKey("id") ? userInfo.getString("id") : null;
146141
String email = userInfo.hasKey("email") ? userInfo.getString("email") : null;
147142
String name = userInfo.hasKey("name") ? userInfo.getString("name") : null;
@@ -406,7 +401,6 @@ class JavaScriptException extends Exception implements JsonStream.Streamable {
406401
}
407402

408403
public void toStream(JsonStream writer) throws IOException {
409-
BugsnagReactNative.logger.info("Serializing exception");
410404
writer.beginObject();
411405
writer.name("errorClass").value(name);
412406
writer.name("message").value(getLocalizedMessage());

0 commit comments

Comments
 (0)