Skip to content
This repository was archived by the owner on Sep 14, 2020. It is now read-only.

Commit 8c1ed58

Browse files
Merge pull request #361 from bugsnag/nullity-fix
Remove nullability annotations to workaround androidx jetifier issue
2 parents ced2f90 + a756608 commit 8c1ed58

3 files changed

Lines changed: 9 additions & 6 deletions

File tree

CHANGELOG.md

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,13 @@
11
Changelog
22
=========
33

4+
## TBD
5+
6+
### Bug fixes
7+
8+
* Remove nullability annotations to workaround androidx jetifier issue
9+
[#361](https://github.com/bugsnag/bugsnag-react-native/pull/361)
10+
411
## 2.19.1 (2019-05-21)
512

613
### Bug fixes

android/src/main/java/com/bugsnag/DiagnosticsCallback.java

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,6 @@
55
import com.bugsnag.android.Report;
66
import com.bugsnag.android.Severity;
77

8-
import android.support.annotation.NonNull;
9-
108
import com.facebook.react.bridge.ReadableMap;
119
import com.facebook.react.bridge.ReadableMapKeySetIterator;
1210

@@ -92,7 +90,7 @@ Map<String, Object> readObjectMap(ReadableMap map) {
9290
}
9391

9492
@Override
95-
public void beforeNotify(@NonNull Report report) {
93+
public void beforeNotify(Report report) {
9694
report.getNotifier().setName(NOTIFIER_NAME);
9795
report.getNotifier().setURL(NOTIFIER_URL);
9896
report.getNotifier().setVersion(String.format("%s (Android %s)",

android/src/main/java/com/bugsnag/JavaScriptException.java

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,6 @@
22

33
import com.bugsnag.android.JsonStream;
44

5-
import android.support.annotation.NonNull;
6-
75
import java.io.IOException;
86

97
/**
@@ -24,7 +22,7 @@ class JavaScriptException extends Exception implements JsonStream.Streamable {
2422
}
2523

2624
@Override
27-
public void toStream(@NonNull JsonStream writer) throws IOException {
25+
public void toStream(JsonStream writer) throws IOException {
2826
writer.beginObject();
2927
writer.name("errorClass").value(name);
3028
writer.name("message").value(getLocalizedMessage());

0 commit comments

Comments
 (0)