Skip to content
This repository was archived by the owner on Sep 14, 2020. It is now read-only.

Commit 85b5bf3

Browse files
Merge pull request #241 from bugsnag/update-example-app
Update example app
2 parents e5e31a1 + 8001ccb commit 85b5bf3

19 files changed

Lines changed: 3422 additions & 3635 deletions

File tree

.travis.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -40,12 +40,12 @@ jobs:
4040
-
4141
- stage: build cocoa
4242
language: objective-c
43-
osx-image: xcode7.3
44-
env: SDK=macosx10.11 BUILD_OSX=9
43+
os: osx
44+
osx_image: xcode9.3
4545
xcode_project: ./cocoa/BugsnagReactNative.xcodeproj
4646
xcode_scheme: BugsnagReactNative
4747
install:
48-
- brew install node yarn
48+
- brew install yarn
4949
before_script:
5050
- npm install
5151
- npm install babel-cli

CONTRIBUTING.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -74,6 +74,8 @@ open coverage/lcov-report/index.html
7474
Run `npm install`, then use `react-native run-android` or `react-native run-ios`
7575
to run the example projects.
7676

77+
If you wish to run in release mode, specify `--configuration Release` for iOS, or `--variant=release` for Android.
78+
7779
## Releasing
7880

7981
### Upgrading the vendored libraries

examples/plain/README.md

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -45,11 +45,10 @@ A robust example of how to make best use of the Bugsnag React Native notifier.
4545

4646
1. Run the app
4747
```
48-
react-native run-ios
48+
react-native run-ios --configuration Release
4949
```
5050

5151
or
5252
```
53-
react-native run-android
53+
react-native run-android --variant=release
5454
```
55-

examples/plain/android/app/build.gradle

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -115,10 +115,19 @@ android {
115115
include "armeabi-v7a", "x86"
116116
}
117117
}
118+
signingConfigs {
119+
release {
120+
storeFile file("fakekeys")
121+
storePassword "password"
122+
keyAlias "password"
123+
keyPassword "password"
124+
}
125+
}
118126
buildTypes {
119127
release {
120128
minifyEnabled enableProguardInReleaseBuilds
121129
proguardFiles getDefaultProguardFile("proguard-android.txt"), "proguard-rules.pro"
130+
signingConfig signingConfigs.release
122131
}
123132
}
124133
// applicationVariants are e.g. debug, release
@@ -137,11 +146,10 @@ android {
137146
}
138147

139148
dependencies {
140-
compile project(':react-native-vector-icons')
141149
compile project(':bugsnag-react-native')
142150
compile fileTree(dir: "libs", include: ["*.jar"])
143151
compile "com.android.support:appcompat-v7:23.0.1"
144-
compile "com.facebook.react:react-native:+" // From node_modules
152+
compile "com.facebook.react:react-native:0.55.3" // From node_modules
145153
}
146154

147155
// Run this once to be able to run the application with BUCK
2.02 KB
Binary file not shown.

examples/plain/android/app/src/main/java/com/bugsnagreactnativeexample/MainApplication.java

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@
44
import android.util.Log;
55

66
import com.facebook.react.ReactApplication;
7-
import com.oblador.vectoricons.VectorIconsPackage;
87
import com.bugsnag.BugsnagReactNative;
98
import com.facebook.react.ReactInstanceManager;
109
import com.facebook.react.ReactNativeHost;
@@ -27,7 +26,6 @@ public boolean getUseDeveloperSupport() {
2726
protected List<ReactPackage> getPackages() {
2827
return Arrays.<ReactPackage>asList(
2928
new MainReactPackage(),
30-
new VectorIconsPackage(),
3129
new CrashyPackage(),
3230
BugsnagReactNative.getPackage()
3331
);

examples/plain/app/components/list_item.js

Lines changed: 0 additions & 14 deletions
This file was deleted.

examples/plain/app/components/navigation_bar_route_mapper.js

Lines changed: 0 additions & 78 deletions
This file was deleted.

examples/plain/app/components/scenes/crashy.js

Lines changed: 0 additions & 64 deletions
This file was deleted.

examples/plain/app/components/scenes/main.js

Lines changed: 0 additions & 56 deletions
This file was deleted.

0 commit comments

Comments
 (0)