Skip to content
This repository was archived by the owner on Sep 14, 2020. It is now read-only.

Commit 7c5aa06

Browse files
committed
chore: address review feedback of example project deobfuscation
1 parent 3c62c97 commit 7c5aa06

8 files changed

Lines changed: 8 additions & 1 deletion

File tree

examples/plain/README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@ This app provides working examples of how to deobfuscate stacktraces for JS, And
5959

6060
### JavaScript
6161

62-
You will need to upload source maps to Bugsnag in order to deobfuscate JavaScript stack traces. Example scripts for achieving this on Android/iOS in both debug and release builds can be found [here](scripts). The example script requires the installation of [bugsnag-sourcemaps](https://github.com/bugsnag/bugsnag-sourcemaps) to work. The scripts can also be invoked in this example project using [npm run](https://docs.npmjs.com/cli/run-script.html):
62+
You will need to upload source maps to Bugsnag in order to deobfuscate JavaScript stack traces. Example scripts for achieving this on Android/iOS in both debug and release builds can be found [here](scripts). The example script requires the installation of [bugsnag-sourcemaps](https://github.com/bugsnag/bugsnag-sourcemaps) to work, which is a dev dependency of this example project. The scripts can also be invoked in this example project using [npm run](https://docs.npmjs.com/cli/run-script.html):
6363

6464
```bash
6565
npm run upload-sourcemaps:debug:android
Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
11
#!/usr/bin/env bash
2+
set -e
23
cd android
34
./gradlew uploadBugsnagReleaseMapping
Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
11
#!/usr/bin/env bash
2+
set -e
23
cd ios
34
bugsnag-dsym-upload build/Build/Products/Release-iphonesimulator/

examples/plain/package.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,7 @@
2323
"devDependencies": {
2424
"babel-jest": "22.4.3",
2525
"babel-preset-react-native": "4.0.0",
26+
"bugsnag-sourcemaps": "^1.1.0",
2627
"eslint": "^4.19.1",
2728
"eslint-config-react-native": "^2.0.0",
2829
"eslint-plugin-babel": "^5.1.0",

examples/plain/scripts/upload-debug-android.sh

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
#!/usr/bin/env bash
2+
set -e
23

34
API_KEY=YOUR-API-KEY-HERE # set your own API key here
45
APP_VERSION=1 # set your own app version here (using the Android versionCode)

examples/plain/scripts/upload-debug-ios.sh

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
#!/usr/bin/env bash
2+
set -e
23

34
API_KEY=YOUR-API-KEY-HERE # set your own API key here
45
APP_VERSION=1 # set your own app version here (using the iOS build number)

examples/plain/scripts/upload-release-android.sh

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
#!/usr/bin/env bash
2+
set -e
23

34
API_KEY=YOUR-API-KEY-HERE # set your own API key here
45
APP_VERSION=1 # set your own app version here (using the Android versionCode)

examples/plain/scripts/upload-release-ios.sh

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
#!/usr/bin/env bash
2+
set -e
23

34
API_KEY=YOUR-API-KEY-HERE # set your own API key here
45
APP_VERSION=1 # set your own app version here (using the iOS build number)

0 commit comments

Comments
 (0)