fix: guard against api key by avoiding error/session paths

Author: fractalwrench

cocoa/BugsnagReactNative.m

@@ -216,7 +216,7 @@ + (void)startWithConfiguration:(BugsnagConfiguration *)config {
     NSString *codeBundleId = [RCTConvert NSString:options[@"codeBundleId"]];
     BugsnagConfiguration* config = [Bugsnag bugsnagStarted] ? [Bugsnag configuration] : [BugsnagConfiguration new];
 
-    if (apiKey != nil && apiKey.length > 0) {
+    if (apiKey.length > 0) {
         config.apiKey = apiKey;
     }
 

cocoa/vendor/bugsnag-cocoa/Source/BugsnagSessionTracker.m

@@ -58,7 +58,7 @@ - (void)startNewSession:(NSDate *)date
 - (void)trackSession {
     [self.sessionStore write:self.currentSession];
     self.trackedFirstSession = YES;
-    
+
     if (self.callback) {
         self.callback(self.currentSession);
     }
@@ -96,7 +96,7 @@ - (void)send {
         }
         BugsnagSessionTrackingPayload *payload = [[BugsnagSessionTrackingPayload alloc] initWithSessions:sessions];
 
-        if (payload.sessions.count > 0) {
+        if (payload.sessions.count > 0 && self.config.apiKey.length > 0) {
             [self.apiClient sendData:payload
                          withPayload:[payload toJson]
                                toURL:self.config.sessionURL

cocoa/vendor/bugsnag-cocoa/Source/BugsnagSink.m

@@ -95,7 +95,7 @@ - (void)filterReports:(NSArray *)reports
     }
 #pragma clang diagnostic pop
 
-    if (reportData == nil) {
+    if (reportData == nil || [reportData count] <= 0) {
         if (onCompletion) {
             onCompletion(@[], YES, nil);
         }
@@ -113,17 +113,20 @@ - (void)filterReports:(NSArray *)reports
 // Generates the payload for notifying Bugsnag
 - (NSDictionary *)getBodyFromReports:(NSArray *)reports {
     NSMutableDictionary *data = [[NSMutableDictionary alloc] init];
-    BSGDictSetSafeObject(data, [Bugsnag notifier].details, BSGKeyNotifier);
-    BSGDictSetSafeObject(data, [Bugsnag notifier].configuration.apiKey, BSGKeyApiKey);
 
-    NSMutableArray *formatted =
-            [[NSMutableArray alloc] initWithCapacity:[reports count]];
+    if ([Bugsnag notifier].configuration.apiKey.length > 0) {
+        BSGDictSetSafeObject(data, [Bugsnag notifier].details, BSGKeyNotifier);
+        BSGDictSetSafeObject(data, [Bugsnag notifier].configuration.apiKey, BSGKeyApiKey);
 
-    for (BugsnagCrashReport *report in reports) {
-        BSGArrayAddSafeObject(formatted, [report toJson]);
-    }
+        NSMutableArray *formatted =
+                [[NSMutableArray alloc] initWithCapacity:[reports count]];
+
+        for (BugsnagCrashReport *report in reports) {
+            BSGArrayAddSafeObject(formatted, [report toJson]);
+        }
 
-    BSGDictSetSafeObject(data, formatted, BSGKeyEvents);
+        BSGDictSetSafeObject(data, formatted, BSGKeyEvents);
+    }
     return data;
 }