Merge branch 'integration/typescript' into PLAT-13698-metadata-delegate

Author: AnastasiiaSvietlova

packages/core/package.json

@@ -17,7 +17,6 @@
     "./lib/derecursify": "./src/lib/derecursify.js",
     "./lib/callback-runner": "./src/lib/callback-runner.js",
     "./lib/node-fallback-stack": "./src/lib/node-fallback-stack.js",
-    "./lib/sync-callback-runner": "./src/lib/sync-callback-runner.js",
     "./lib/path-normalizer": "./src/lib/path-normalizer.js",
     "./lib/validators/string-with-length": "./src/lib/validators/string-with-length.js",
     "./lib/validators/list-of-functions": "./src/lib/validators/list-of-functions.js",

packages/core/src/index.ts

@@ -8,5 +8,6 @@ export { default as jsonPayload } from './lib/json-payload'
 export { default as intRange } from './lib/validators/int-range'
 export { default as isError } from './lib/iserror'
 export { default as metadataDelegate } from './lib/metadata-delegate'
+export { default as runSyncCallbacks } from './lib/sync-callback-runner'
 
 export * from './common'

packages/core/src/lib/sync-callback-runner.js

@@ -0,0 +1,28 @@
+import type Breadcrumb from '../breadcrumb'
+import { LoggerConfig, OnBreadcrumbCallback, OnSessionCallback } from '../common'
+import type Session from '../session'
+type Callbacks = (...args: any[]) => any
+
+const runSyncCallbacks = (
+  callbacks: OnSessionCallback[] | OnBreadcrumbCallback[] | Callbacks[] | any[],
+  callbackArg: Session | Breadcrumb | Event,
+  callbackType: string,
+  logger: LoggerConfig
+): boolean => {
+  let ignore = false
+  const cbs = callbacks.slice()
+  while (!ignore) {
+    if (!cbs.length) break
+    try {
+      ignore = cbs.pop()(callbackArg) === false
+    } catch (e) {
+      logger.error(
+        `Error occurred in ${callbackType} callback, continuing anyway…`
+      )
+      logger.error(e)
+    }
+  }
+  return ignore
+}
+
+export default runSyncCallbacks

packages/core/src/lib/sync-callback-runner.ts

@@ -1,5 +1,5 @@
 const { readFile } = require('fs').promises
-const runSyncCallbacks = require('@bugsnag/core/lib/sync-callback-runner')
+const { runSyncCallbacks } = require('@bugsnag/core')
 const { serialiseEvent, deserialiseEvent } = require('./event-serialisation')
 
 module.exports = class MinidumpDeliveryLoop {

packages/plugin-electron-deliver-minidumps/minidump-loop.js

@@ -1,7 +1,6 @@
-const { intRange } = require('@bugsnag/core')
+const { intRange, runSyncCallbacks } = require('@bugsnag/core')
 const SessionTracker = require('./tracker')
 const Backoff = require('backo')
-const runSyncCallbacks = require('@bugsnag/core/lib/sync-callback-runner')
 
 module.exports = {
   load: (client) => {