Merge pull request #2405 from bugsnag/PLAT-13701-int-range

Convert @bugsnag/core/lib/validators/int-range to TypeScript

Author: gingerbenw

packages/core/package.json

@@ -10,7 +10,6 @@
       "default": "./dist/index.cjs"
     },
     "./lib/es-utils/assign": "./src/lib/es-utils/assign.js",
-    "./lib/validators/int-range": "./src/lib/validators/int-range.js",
     "./lib/es-utils/includes": "./src/lib/es-utils/includes.js",
     "./lib/es-utils/filter": "./src/lib/es-utils/filter.js",
     "./lib/iserror": "./src/lib/iserror.js",

packages/core/src/index.ts

@@ -5,5 +5,6 @@ export { default as Session } from './session'
 export { default as schema } from './config'
 export { default as cloneClient } from './lib/clone-client'
 export { default as jsonPayload } from './lib/json-payload'
+export { default as intRange } from './lib/validators/int-range'
 
 export * from './common'

packages/core/src/lib/validators/int-range.d.ts

@@ -0,0 +1,9 @@
+const intRange: <T>(min?: number, max?: number) => (value: T) => boolean = (
+  min = 1,
+  max = Infinity
+) => (value) =>
+  typeof value === "number" &&
+  parseInt("" + value, 10) === value &&
+  value >= min && value <= max;
+
+export default intRange

packages/core/src/lib/validators/int-range.js

@@ -1,6 +1,5 @@
 const native = require('bindings')('bugsnag_plugin_electron_app_bindings')
-const { schema } = require('@bugsnag/core')
-const intRange = require('@bugsnag/core/lib/validators/int-range')
+const { schema, intRange } = require('@bugsnag/core')
 
 const isNativeClientEnabled = client => client._config.autoDetectErrors && client._config.enabledErrorTypes.nativeCrashes
 

packages/core/src/lib/validators/int-range.ts

@@ -1,4 +1,4 @@
-const intRange = require('@bugsnag/core/lib/validators/int-range')
+const { intRange } = require('@bugsnag/core')
 const SessionTracker = require('./tracker')
 const Backoff = require('backo')
 const runSyncCallbacks = require('@bugsnag/core/lib/sync-callback-runner')

packages/plugin-electron-app/app.js

@@ -1,5 +1,4 @@
-import intRange from '@bugsnag/core/lib/validators/int-range'
-import { Client, Config, Plugin } from '@bugsnag/core'
+import { intRange, Client, Config, Plugin } from '@bugsnag/core'
 
 interface PluginConfig extends Config {
   maxEvents: number