update attw check

Co-authored-by: Copilot <copilot@github.com>

Author: gingerbenw

.github/workflows/attw-check.yml

@@ -48,6 +48,14 @@ jobs:
           cat packages/browser/dist/bugsnag.min.js | gzip | wc -c > .diff/size-after-gzipped
           cp coverage/coverage-summary.json .diff/coverage-after.json
 
+      - name: Run ATTW check
+        continue-on-error: true
+        env:
+          PLAYWRIGHT_SKIP_BROWSER_DOWNLOAD: 1
+          ELECTRON_DISABLE_SANDBOX: 1
+        run: |
+          npm run test:attw || true
+
       - name: Run danger
         uses: danger/danger-js@67ed2c1f42fd2fc198cc3c14b43c8f83351f4fe9 # 13.0.5
         env:

.github/workflows/pr-diff.yml

@@ -24,3 +24,5 @@ Gemfile.lock
 *.iml
 zscaler-root-ca.crt*
 .ts38-validation
+# Arethetypeswrong working files
+attw-results.json

.gitignore

@@ -1,6 +1,7 @@
 /* global markdown */
 
-const { readFileSync } = require('fs')
+const { readFileSync, existsSync } = require('fs')
+const { execSync } = require('child_process')
 const coverageDiff = require('coverage-diff')
 
 const before = {
@@ -25,6 +26,22 @@ const showDiff = n => {
   return '_No change_'
 }
 
+let attwReport = ''
+if (existsSync(`${__dirname}/attw-results.json`)) {
+  try {
+    const attwOutput = execSync('node scripts/parse-attw-results.js --format=markdown', {
+      encoding: 'utf8',
+      stdio: ['pipe', 'pipe', 'pipe']
+    })
+    attwReport = `\n\n${attwOutput}`
+  } catch (error) {
+    // Script exits with code 1 if there are problems, but we still want the output
+    if (error.stdout) {
+      attwReport = `\n\n${error.stdout}`
+    }
+  }
+}
+
 markdown(`
 ### \`@bugsnag/browser\` bundle size diff
 
@@ -36,5 +53,5 @@ markdown(`
 
 ### code coverage diff
 
-${coverageDiff.diff(before.coverage, after.coverage).results}
+${coverageDiff.diff(before.coverage, after.coverage).results}${attwReport}
 `)

dangerfile.js

@@ -86,7 +86,7 @@
     "build": "lerna run build",
     "clean": "lerna run clean",
     "build:electron": "lerna run build --scope '@bugsnag/plugin-electron-ipc' --scope '@bugsnag/plugin-electron-app' --scope '@bugsnag/plugin-electron-client-state-persistence'",
-    "test:attw": "lerna exec --concurrency 1 -- attw --pack . -f json > attw-results.json",
+    "test:attw": "node scripts/run-attw.js",
     "test:lint": "eslint --report-unused-disable-directives .",
     "test:lint-native": "bash scripts/cppcheck.sh",
     "test:unit:electron-runner": "xvfb-maybe --auto-servernum -- jest -c config/electron-jest.config.js --rootDir .",

package.json

@@ -10,50 +10,63 @@ const path = require('path');
 
 function parseResults(filePath) {
   const content = fs.readFileSync(filePath, 'utf8');
-  const lines = content.split('\n');
-  const results = [];
 
-  let currentJson = '';
-  let braceCount = 0;
-  let inJson = false;
-  
-  for (const line of lines) {
-    // Skip empty lines and lines that don't start a JSON object if we're not already in one
-    if (!inJson && !line.trim().startsWith('{')) {
-      continue;
+  try {
+    // Try parsing as a JSON array first (new format)
+    const parsed = JSON.parse(content);
+    if (Array.isArray(parsed)) {
+      return parsed;
     }
+    // If it's a single object, wrap it in an array
+    return [parsed];
+  } catch (error) {
+    // Fall back to parsing multiple JSON objects separated by newlines (legacy format)
+    console.warn('⚠️  Using legacy multi-object JSON parsing. Consider running with the new script.');
+    const lines = content.split('\n');
+    const results = [];
 
-    // Start tracking a new JSON object
-    if (line.trim().startsWith('{') && braceCount === 0) {
-      inJson = true;
-      currentJson = '';
-      braceCount = 0;
-    }
+    let currentJson = '';
+    let braceCount = 0;
+    let inJson = false;
 
-    if (inJson) {
-      currentJson += line + '\n';
+    for (const line of lines) {
+      // Skip empty lines and lines that don't start a JSON object if we're not already in one
+      if (!inJson && !line.trim().startsWith('{')) {
+        continue;
+      }
 
-      // Count braces to know when we've completed a JSON object
-      for (const char of line) {
-        if (char === '{') braceCount++;
-        if (char === '}') braceCount--;
+      // Start tracking a new JSON object
+      if (line.trim().startsWith('{') && braceCount === 0) {
+        inJson = true;
+        currentJson = '';
+        braceCount = 0;
       }
 
-      // When braceCount returns to 0, we have a complete JSON object
-      if (braceCount === 0) {
-        try {
-          const parsed = JSON.parse(currentJson);
-          results.push(parsed);
-        } catch (err) {
-          console.error('Error parsing JSON object:', err.message);
+      if (inJson) {
+        currentJson += line + '\n';
+        
+        // Count braces to know when we've completed a JSON object
+        for (const char of line) {
+          if (char === '{') braceCount++;
+          if (char === '}') braceCount--;
+        }
+        
+        // When braceCount returns to 0, we have a complete JSON object
+        if (braceCount === 0) {
+          try {
+            const parsed = JSON.parse(currentJson);
+            results.push(parsed);
+          } catch (err) {
+            console.error('Error parsing JSON object:', err.message);
+          }
+          inJson = false;
+          currentJson = '';
         }
-        inJson = false;
-        currentJson = '';
       }
     }
+    
+    return results;
   }
-  
-  return results;
 }
 
 function analyzeResults(results) {

scripts/parse-attw-results.js

@@ -0,0 +1,98 @@
+#!/usr/bin/env node
+
+const { execSync } = require('child_process');
+const fs = require('fs');
+const path = require('path');
+
+/**
+ * Run ATTW checks on all packages and output a properly formatted JSON file
+ */
+
+function getPackages() {
+  try {
+    const output = execSync('npx lerna list --all --json', {
+      encoding: 'utf8',
+      stdio: ['pipe', 'pipe', 'pipe']
+    });
+    return JSON.parse(output);
+  } catch (error) {
+    console.error('Failed to get package list from lerna:', error.message);
+    process.exit(1);
+  }
+}
+
+function runAttwForPackage(packagePath) {
+  try {
+    const output = execSync('npx attw --pack . -f json', {
+      cwd: packagePath,
+      encoding: 'utf8',
+      stdio: ['pipe', 'pipe', 'pipe']
+    });
+    
+    // Parse the JSON output (handle pretty-printed multi-line JSON)
+    return JSON.parse(output);
+  } catch (error) {
+    // attw may exit with non-zero code if problems are found
+    // but the output should still be valid JSON
+    if (error.stdout) {
+      try {
+        return JSON.parse(error.stdout);
+      } catch {
+        console.error(`Failed to parse ATTW output for ${packagePath}:`, error.message);
+        return null;
+      }
+    }
+    console.error(`Failed to run ATTW for ${packagePath}:`, error.message);
+    return null;
+  }
+}
+
+function main() {
+  console.log('Getting package list...');
+  const packages = getPackages();
+  console.log(`Found ${packages.length} packages`);
+  
+  const results = [];
+  let checked = 0;
+  let skipped = 0;
+  
+  for (const pkg of packages) {
+    // Skip private packages
+    if (pkg.private) {
+      console.log(`Skipping private package: ${pkg.name}`);
+      skipped++;
+      continue;
+    }
+    
+    console.log(`Checking ${pkg.name}...`);
+    const result = runAttwForPackage(pkg.location);
+    
+    if (result) {
+      results.push(result);
+      checked++;
+    } else {
+      skipped++;
+    }
+  }
+  
+  // Write the results as a proper JSON array
+  const outputPath = path.join(process.cwd(), 'attw-results.json');
+  fs.writeFileSync(outputPath, JSON.stringify(results, null, 2), 'utf8');
+  
+  console.log(`\n✅ ATTW check complete!`);
+  console.log(`   Packages checked: ${checked}`);
+  console.log(`   Packages skipped: ${skipped}`);
+  console.log(`   Results written to: ${outputPath}`);
+  
+  // Exit with error code if any package has problems
+  const packagesWithProblems = results.filter(r => 
+    r.problems && Object.keys(r.problems).length > 0
+  ).length;
+  
+  if (packagesWithProblems > 0) {
+    console.log(`\n⚠️  ${packagesWithProblems} package(s) have type issues`);
+    process.exit(1);
+  }
+}
+
+main();