Convert @bugsnag/core/lib/iserror to TypeScript (#2422)

* core: convert iserror to typescript

* fix isError function

* delete iserror from package.json

* fix naming

* delete iserror from rn package.json

* delete iserror from all packages as it not used

Author: AnastasiiaSvietlova

package-lock.json

@@ -12,7 +12,6 @@
     "./lib/es-utils/assign": "./src/lib/es-utils/assign.js",
     "./lib/es-utils/includes": "./src/lib/es-utils/includes.js",
     "./lib/es-utils/filter": "./src/lib/es-utils/filter.js",
-    "./lib/iserror": "./src/lib/iserror.js",
     "./lib/es-utils/reduce": "./src/lib/es-utils/reduce.js",
     "./lib/es-utils/keys": "./src/lib/es-utils/keys.js",
     "./lib/derecursify": "./src/lib/derecursify.js",
@@ -52,7 +51,6 @@
     "@bugsnag/cuid": "^3.0.0",
     "@bugsnag/safe-json-stringify": "^6.0.0",
     "error-stack-parser": "^2.0.3",
-    "iserror": "^0.0.2",
     "stack-generator": "^2.0.3"
   },
   "devDependencies": {

packages/core/package.json

@@ -6,5 +6,6 @@ export { default as schema } from './config'
 export { default as cloneClient } from './lib/clone-client'
 export { default as jsonPayload } from './lib/json-payload'
 export { default as intRange } from './lib/validators/int-range'
+export { default as isError } from './lib/iserror'
 
 export * from './common'

packages/core/src/index.ts

@@ -0,0 +1,36 @@
+// MIT License
+
+// Copyright (c) 2017 Anton Yefremov
+
+// Permission is hereby granted, free of charge, to any person obtaining a copy
+// of this software and associated documentation files (the "Software"), to deal
+// in the Software without restriction, including without limitation the rights
+// to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
+// copies of the Software, and to permit persons to whom the Software is
+// furnished to do so, subject to the following conditions:
+
+// The above copyright notice and this permission notice shall be included in all
+// copies or substantial portions of the Software.
+
+// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+// IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+// FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
+// AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+// LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
+// OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
+// SOFTWARE.
+
+const isError = (maybeError: unknown): maybeError is Error => {
+  switch (Object.prototype.toString.call(maybeError)) {
+    case '[object Error]':
+      return true
+    case '[object Exception]':
+      return true
+    case '[object DOMException]':
+      return true
+    default:
+      return maybeError instanceof Error
+  }
+}
+
+export default isError

packages/core/src/lib/iserror.d.ts

@@ -50,7 +50,6 @@
     "@bugsnag/core": "^8.2.0",
     "byline": "^5.0.0",
     "error-stack-parser": "^2.0.3",
-    "iserror": "^0.0.2",
     "pump": "^3.0.0",
     "stack-generator": "^2.0.3"
   }

packages/core/src/lib/iserror.js

@@ -1,5 +1,5 @@
-import { Config, Plugin } from '@bugsnag/core'
-import isError from '@bugsnag/core/lib/iserror'
+import { isError } from '@bugsnag/core'
+import type { Config, Plugin } from '@bugsnag/core'
 import fixBluebirdStacktrace from './fix-bluebird-stacktrace'
 
 type Listener = (evt: PromiseRejectionEvent) => void

packages/core/src/lib/iserror.ts

@@ -64,8 +64,7 @@
     "@bugsnag/plugin-react-native-global-error-handler": "^8.2.0",
     "@bugsnag/plugin-react-native-hermes": "^8.2.0",
     "@bugsnag/plugin-react-native-session": "^8.2.0",
-    "@bugsnag/plugin-react-native-unhandled-rejection": "^8.2.0",
-    "iserror": "^0.0.2"
+    "@bugsnag/plugin-react-native-unhandled-rejection": "^8.2.0"
   },
   "scripts": {
     "prepare": "bash prepare-android-vendor.sh",

packages/node/package.json

@@ -1,7 +1,6 @@
-const { schema } = require('@bugsnag/core')
+const { isError, schema } = require('@bugsnag/core')
 const stringWithLength = require('@bugsnag/core/lib/validators/string-with-length')
 const rnPackage = require('react-native/package.json')
-const iserror = require('iserror')
 
 const ALLOWED_IN_JS = [
   'onError',
@@ -64,7 +63,7 @@ const getPrefixedConsole = () => {
       accum[method] = (...args) => originalConsole[method]('[bugsnag]', ...args)
     } else {
       accum[method] = (...args) => {
-        if (!iserror(args[0])) {
+        if (!isError(args[0])) {
           originalConsole[method]('[bugsnag]', ...args)
         } else {
           // a raw error doesn't display nicely in react native's yellow box,