Skip to content

Commit f36168e

Browse files
Steve Kirkland-WaltonSteve Kirkland-Walton
authored andcommitted
Skip scenario on Android 15 and clean up skip tags
[full ci]
1 parent 9f7d9a8 commit f36168e

3 files changed

Lines changed: 5 additions & 36 deletions

File tree

features/full_tests/naughty_strings.feature

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -26,8 +26,6 @@ Feature: The notifier handles user data containing unusual strings
2626
And the error payload field "events.0.metaData.custom.val_13" equals "𝓣𝓱𝓮 𝓺𝓾𝓲𝓬𝓴 𝓫𝓻𝓸𝔀𝓷 𝓯𝓸𝔁 𝓳𝓾𝓶𝓹𝓼 𝓸𝓿𝓮𝓻 𝓽𝓱𝓮 𝓵𝓪𝔃𝔂 𝓭𝓸𝓰"
2727
And the error payload field "events.0.metaData.custom.val_14" equals "گچپژ"
2828

29-
# commented out some failing unicode assertions and skipped Android <6 until PLAT-5606 is addressed
30-
@skip_below_android_6
3129
Scenario: Test unhandled NDK error
3230
When I run "CXXNaughtyStringsScenario" and relaunch the crashed app
3331
And I configure Bugsnag for "CXXNaughtyStringsScenario"

features/full_tests/startup_anr.feature

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,8 +9,7 @@ Feature: onCreate ANR
99
@skip_android_10
1010
# Android 13+ Note: we no longer have permission to inject BACK button events, which are used to
1111
# trigger the ANR - so the test is not valid on Android 13 either
12-
@skip_android_13
13-
@skip_android_14
12+
@skip_above_android_13
1413
Scenario: onCreate ANR is reported
1514
When I clear any error dialogue
1615
And I run "ConfigureStartupAnrScenario"

features/support/env.rb

Lines changed: 4 additions & 32 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,10 @@
2424
skip_this_scenario("Skipping scenario")
2525
end
2626

27+
Before('@skip_above_android_13') do |scenario|
28+
skip_this_scenario("Skipping scenario") if Maze.config.os_version >= 13
29+
end
30+
2731
Before('@skip_above_android_11') do |scenario|
2832
skip_this_scenario("Skipping scenario") if Maze.config.os_version >= 11
2933
end
@@ -32,10 +36,6 @@
3236
skip_this_scenario("Skipping scenario") if Maze.config.os_version >= 9
3337
end
3438

35-
Before('@skip_above_android_7') do |scenario|
36-
skip_this_scenario("Skipping scenario") if Maze.config.os_version >= 8
37-
end
38-
3939
Before('@skip_below_android_11') do |scenario|
4040
skip_this_scenario("Skipping scenario") if Maze.config.os_version < 11
4141
end
@@ -48,34 +48,6 @@
4848
skip_this_scenario("Skipping scenario") if Maze.config.os_version < 9
4949
end
5050

51-
Before('@skip_below_android_8') do |scenario|
52-
skip_this_scenario("Skipping scenario") if Maze.config.os_version < 8
53-
end
54-
55-
Before('@skip_below_android_6') do |scenario|
56-
skip_this_scenario("Skipping scenario") if Maze.config.os_version < 6
57-
end
58-
59-
Before('@skip_below_android_5') do |scenario|
60-
skip_this_scenario("Skipping scenario") if Maze.config.os_version < 5
61-
end
62-
63-
Before('@skip_android_14') do |scenario|
64-
skip_this_scenario("Skipping scenario") if Maze.config.os_version.floor == 14
65-
end
66-
67-
Before('@skip_android_13') do |scenario|
68-
skip_this_scenario("Skipping scenario") if Maze.config.os_version.floor == 13
69-
end
70-
7151
Before('@skip_android_10') do |scenario|
7252
skip_this_scenario("Skipping scenario") if Maze.config.os_version.floor == 10
7353
end
74-
75-
Before('@skip_android_7') do |scenario|
76-
skip_this_scenario("Skipping scenario") if Maze.config.os_version.floor == 7
77-
end
78-
79-
Before('@skip_android_6') do |scenario|
80-
skip_this_scenario("Skipping scenario") if Maze.config.os_version.floor == 6
81-
end

0 commit comments

Comments
 (0)