Merge pull request #2224 from bugsnag/tms/fixture-version

Use the Buildkite build number for the test fixture app version

Author: twometresteve

features/fixtures/mazerunner/app/build.gradle

@@ -11,7 +11,7 @@ android {
         minSdkVersion 17
         targetSdkVersion 34
         versionCode 1
-        versionName "1.1.14"
+        versionName System.getenv("BUILDKITE_BUILD_NUMBER") ?: "1.1.14"
         manifestPlaceholders = [
                 // omit any of the following placeholders to use the default values
                 bugsnagApiKey: "abc12312312312312312312312312312",

features/full_tests/internal_error_reports.feature

@@ -39,7 +39,7 @@ Feature: Cached Error Reports
     And the event "app.id" equals "com.bugsnag.android.mazerunner"
     And the event "app.releaseStage" equals "mazerunner"
     And the event "app.type" equals "android"
-    And the event "app.version" equals "1.1.14"
+    And the event app version matches the built app version
     And the event "app.versionCode" equals 1
     And the error payload field "events.0.app.duration" is an integer
     And the error payload field "events.0.app.durationInForeground" is an integer

features/full_tests/load_configuration.feature

@@ -45,7 +45,7 @@ Feature: Loading values into the configuration
     And the event "metaData.test.filter_me" equals "foobar"
     And the event "app.versionCode" equals 1
     And the event "app.buildUUID" is not null
-    And the event "app.version" equals "1.1.14"
+    And the event app version matches the built app version
     And the event "app.type" is null
     And the event "user.id" is not null
     And the event "user.name" is null

features/smoke_tests/01_anr.feature

@@ -39,7 +39,7 @@ Feature: ANR smoke test
     And the event "app.id" equals "com.bugsnag.android.mazerunner"
     And the event "app.releaseStage" equals "mazerunner"
     And the event "app.type" equals "android"
-    And the event "app.version" equals "1.1.14"
+    And the event app version matches the built app version
     And the event "app.versionCode" equals 1
     And the error payload field "events.0.app.duration" is an integer
     And the error payload field "events.0.app.durationInForeground" is an integer

features/smoke_tests/02_handled.feature

@@ -39,7 +39,8 @@ Feature: Handled smoke tests
     And the event "app.id" equals "com.bugsnag.android.mazerunner"
     And the event "app.releaseStage" equals "mazerunner"
     And the event "app.type" equals "android"
-    And the event "app.version" equals "1.1.14"
+    And the event app version matches the built app version
+
     And the event "app.versionCode" equals 1
     And the error payload field "events.0.app.duration" is an integer
     And the error payload field "events.0.app.durationInForeground" is an integer
@@ -195,7 +196,7 @@ Feature: Handled smoke tests
     And the event "app.id" equals "com.bugsnag.android.mazerunner"
     And the event "app.releaseStage" equals "mazerunner"
     And the event "app.type" equals "android"
-    And the event "app.version" equals "1.1.14"
+    And the event app version matches the built app version
     And the event "app.versionCode" equals 1
     And the error payload field "events.0.app.duration" is an integer
     And the error payload field "events.0.app.durationInForeground" is an integer

features/smoke_tests/03_sessions.feature

@@ -23,7 +23,7 @@ Feature: Session functionality smoke tests
     And the session payload field "app.id" equals "com.bugsnag.android.mazerunner"
     And the session payload field "app.releaseStage" equals "mazerunner"
     And the session payload field "app.type" equals "android"
-    And the session payload field "app.version" equals "1.1.14"
+    And the session app version matches the built app version
     And the session payload field "app.versionCode" equals 1
 
     # Device data

features/smoke_tests/04_unhandled.feature

@@ -40,7 +40,7 @@ Feature: Unhandled smoke tests
     And the event "app.id" equals "com.bugsnag.android.mazerunner"
     And the event "app.releaseStage" equals "mazerunner"
     And the event "app.type" equals "android"
-    And the event "app.version" equals "1.1.14"
+    And the event app version matches the built app version
     And the event "app.versionCode" equals 1
     And the error payload field "events.0.app.duration" is an integer
     And the error payload field "events.0.app.durationInForeground" is an integer

features/steps/android_steps.rb

@@ -304,3 +304,15 @@ def click_if_present(element)
   regex = Regexp.new pattern
   Maze.check.match regex, lastBreadcrumbName
 end
+
+def expected_app_version
+  ENV['BUILDKITE_BUILD_NUMBER'] || '1.1.14'
+end
+
+Then("the session app version matches the built app version") do
+  step "the session payload field \"app.version\" equals \"#{expected_app_version}\""
+end
+
+Then("the event app version matches the built app version") do
+  step "the event \"app.version\" equals \"#{expected_app_version}\""
+end

scripts/build-test-fixture.rb

@@ -1,7 +1,8 @@
 def upload_files(api_key, dest)
   Dir.chdir('features/fixtures/mazerunner') do
     upload = "bugsnag-cli upload"
-    options = "--api-key=#{api_key} --overwrite --version-code=1"
+    version_code = ENV['BUILDKITE_BUILD_NUMBER']
+    options = "--api-key=#{api_key} --version-code=#{version_code}"
     puts "Uploading symbol files to #{dest}"
     puts `#{upload} android-ndk #{options}`
     puts "Uploading mapping file to #{dest}"