Skip to content

Commit cc4cf67

Browse files
Merge pull request #2192 from bugsnag/tms/macos-15
Move CI jobs to macOS 15
2 parents 2fa9403 + 309d90d commit cc4cf67

4 files changed

Lines changed: 29 additions & 15 deletions

File tree

.buildkite/pipeline.full.yml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ steps:
66
key: "fixture-minimal"
77
timeout_in_minutes: 30
88
agents:
9-
queue: macos-14
9+
queue: macos-15
1010
artifact_paths: build/fixture-minimal.apk
1111
command: make fixture-minimal
1212
env:
@@ -15,7 +15,7 @@ steps:
1515
- label: ':android: Build Example App'
1616
timeout_in_minutes: 10
1717
agents:
18-
queue: macos-14
18+
queue: macos-15
1919
command: 'make example-app'
2020
env:
2121
JAVA_VERSION: 17
@@ -24,7 +24,7 @@ steps:
2424
key: "fixture-debug"
2525
timeout_in_minutes: 30
2626
agents:
27-
queue: macos-14
27+
queue: macos-15
2828
artifact_paths:
2929
- "build/fixture-debug.apk"
3030
- "build/fixture-debug/*"
@@ -35,7 +35,7 @@ steps:
3535
- label: ':android: Build Scan'
3636
timeout_in_minutes: 10
3737
agents:
38-
queue: macos-14
38+
queue: macos-15
3939
command: './gradlew clean assembleRelease check --scan'
4040

4141
#

.buildkite/pipeline.yml

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ steps:
66
- label: 'Audit current licenses'
77
timeout_in_minutes: 30
88
agents:
9-
queue: macos-14
9+
queue: macos-15
1010
commands:
1111
- bundle install
1212
- ./scripts/audit-dependency-licenses.sh
@@ -15,7 +15,7 @@ steps:
1515
key: "fixture-r19"
1616
timeout_in_minutes: 30
1717
agents:
18-
queue: macos-14
18+
queue: macos-15
1919
artifact_paths:
2020
- "build/fixture-r19.apk"
2121
- "build/fixture-r19-url.txt"
@@ -33,7 +33,7 @@ steps:
3333
key: "fixture-r21"
3434
timeout_in_minutes: 30
3535
agents:
36-
queue: macos-14
36+
queue: macos-15
3737
artifact_paths:
3838
- "build/fixture-r21.apk"
3939
- "build/fixture-r21-url.txt"
@@ -50,31 +50,31 @@ steps:
5050
- label: ':android: Coding standards checks'
5151
timeout_in_minutes: 20
5252
agents:
53-
queue: macos-14
53+
queue: macos-15
5454
command: './gradlew --continue checkstyle detekt lint ktlintCheck'
5555

5656
- label: ':android: Binary compatibility checks'
5757
timeout_in_minutes: 20
5858
agents:
59-
queue: macos-14
59+
queue: macos-15
6060
command: './gradlew apiCheck'
6161

6262
- label: ':android: CppCheck'
6363
timeout_in_minutes: 10
6464
agents:
65-
queue: macos-14
65+
queue: macos-15
6666
command: 'bash ./scripts/run-cpp-check.sh'
6767

6868
- label: ':android: ClangFormat'
6969
timeout_in_minutes: 10
7070
agents:
71-
queue: macos-14
71+
queue: macos-15
7272
command: 'bash ./scripts/run-clang-format-ci-check.sh'
7373

7474
- label: ':android: Lint mazerunner scenarios'
7575
timeout_in_minutes: 10
7676
agents:
77-
queue: macos-14
77+
queue: macos-15
7878
commands:
7979
- cd features/fixtures/mazerunner
8080
- ./gradlew ktlintCheck detekt checkstyle
@@ -84,13 +84,13 @@ steps:
8484
- label: ':android: Android size reporting'
8585
timeout_in_minutes: 10
8686
agents:
87-
queue: macos-14
87+
queue: macos-15
8888
command: scripts/run-sizer.sh
8989

9090
- label: ':android: JVM tests'
9191
timeout_in_minutes: 10
9292
agents:
93-
queue: macos-14
93+
queue: macos-15
9494
command: './gradlew test'
9595

9696
- label: ':android: Instrumentation tests'
@@ -99,7 +99,7 @@ steps:
9999
artifacts#v1.9.0:
100100
upload: "bugsnag-*/build/reports/androidTests/connected/**/*.html"
101101
agents:
102-
queue: macos-14-isolated
102+
queue: macos-15-isolated
103103
command: './scripts/run-connected-checks.rb'
104104
env:
105105
API_LEVEL: 30

CHANGELOG.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,11 @@
77
* Allow the metadata in `leaveBreadcrumb` to be null rather than enforcing non-null, aligning `bugsnag-android` with our other SDKs
88
[#2180](https://github.com/bugsnag/bugsnag-android/pull/2180)
99

10+
### Bug fixes
11+
12+
* Sanity check the allocation in the installation of `bugsnag-plugin-android-ndk` to avoid a possible crash when allocation fails
13+
[#2191](https://github.com/bugsnag/bugsnag-android/pull/2191)
14+
1015
## 6.13.0 (2025-04-15)
1116

1217
### Enhancements

bugsnag-plugin-android-ndk/src/main/jni/bugsnag_ndk.c

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -164,6 +164,11 @@ JNIEXPORT void JNICALL Java_com_bugsnag_android_ndk_NativeBridge_install(
164164
}
165165

166166
bsg_environment *bugsnag_env = calloc(1, sizeof(bsg_environment));
167+
if (bugsnag_env == NULL) {
168+
BUGSNAG_LOG("Failed to allocate memory for bsg_environment");
169+
return;
170+
}
171+
167172
bsg_unwinder_init();
168173
bugsnag_env->report_header.big_endian =
169174
htonl(47) == 47; // potentially too clever, see man 3 htonl
@@ -328,6 +333,10 @@ JNIEXPORT void JNICALL Java_com_bugsnag_android_ndk_NativeBridge_addBreadcrumb(
328333

329334
if (name != NULL && timestamp != NULL) {
330335
bugsnag_breadcrumb *crumb = calloc(1, sizeof(bugsnag_breadcrumb));
336+
if (crumb == NULL) {
337+
goto end;
338+
}
339+
331340
bsg_strncpy(crumb->name, name, sizeof(crumb->name));
332341
bsg_strncpy(crumb->timestamp, timestamp, sizeof(crumb->timestamp));
333342

0 commit comments

Comments
 (0)