implement simple clippy recommendations

Author: Johann150

codespan-reporting/examples/custom_files.rs

@@ -60,11 +60,10 @@ mod files {
             use std::cmp::Ordering;
 
             match line_index.cmp(&self.line_starts.len()) {
-                Ordering::Less => Ok(self
+                Ordering::Less => Ok(*self
                     .line_starts
                     .get(line_index)
-                    .expect("failed despite previous check")
-                    .clone()),
+                    .expect("failed despite previous check")),
                 Ordering::Equal => Ok(self.source.len()),
                 Ordering::Greater => Err(files::Error::LineTooLarge {
                     given: line_index,

codespan-reporting/examples/readme_preview.rs

@@ -87,7 +87,7 @@ fn main() -> anyhow::Result<()> {
             };
 
             for diagnostic in &diagnostics {
-                term::emit(&mut writer, &config, &file, &diagnostic)?;
+                term::emit(&mut writer, &config, &file, diagnostic)?;
             }
 
             let num_lines = buffer.iter().filter(|byte| **byte == b'\n').count() + 1;
@@ -178,7 +178,7 @@ fn main() -> anyhow::Result<()> {
             let writer = StandardStream::stderr(color.into());
             let config = codespan_reporting::term::Config::default();
             for diagnostic in &diagnostics {
-                term::emit(&mut writer.lock(), &config, &file, &diagnostic)?;
+                term::emit(&mut writer.lock(), &config, &file, diagnostic)?;
             }
         }
     }
@@ -294,7 +294,7 @@ impl<W: Write> WriteColor for SvgWriter<W> {
             }
 
             Ok(false)
-        };
+        }
 
         fn write_color<W: Write>(color: &Color, writer: &mut SvgWriter<W>) -> io::Result<()> {
             match color {
@@ -309,7 +309,7 @@ impl<W: Write> WriteColor for SvgWriter<W> {
                 // TODO: other colors
                 _ => Ok(()),
             }
-        };
+        }
 
         if let Some(fg) = spec.fg() {
             first = write_first(first, self)?;

codespan-reporting/examples/term.rs

@@ -168,7 +168,7 @@ fn main() -> anyhow::Result<()> {
     let writer = StandardStream::stderr(opts.color.into());
     let config = codespan_reporting::term::Config::default();
     for diagnostic in &diagnostics {
-        term::emit(&mut writer.lock(), &config, &files, &diagnostic)?;
+        term::emit(&mut writer.lock(), &config, &files, diagnostic)?;
     }
 
     Ok(())

codespan-reporting/src/term.rs

@@ -72,9 +72,9 @@ impl FromStr for ColorArg {
     }
 }
 
-impl Into<ColorChoice> for ColorArg {
-    fn into(self) -> ColorChoice {
-        self.0
+impl From<ColorArg> for ColorChoice {
+    fn from(x: ColorArg) -> Self {
+        x.0
     }
 }
 

codespan-reporting/src/term/renderer.rs

@@ -212,7 +212,7 @@ impl<'writer, 'config> Renderer<'writer, 'config> {
         self.reset()?;
 
         write!(self, " ")?;
-        self.snippet_locus(&locus)?;
+        self.snippet_locus(locus)?;
 
         writeln!(self)?;
 

codespan-reporting/tests/support/color_buffer.rs

@@ -92,7 +92,7 @@ impl WriteColor for ColorBuffer {
             }
 
             Ok(false)
-        };
+        }
 
         if let Some(fg) = spec.fg() {
             first = write_first(first, self)?;