Support path mapping in Rust Starlark actions (#4063)

Transition from passing raw string paths (`.path`) to passing `File`
objects directly to action arguments (`Args`). This allows Bazel to
mutate paths during execution, which is required for path mapping
compatibility.

For more details on path mapping best practices, see:
bazelbuild/bazel#22658

Co-authored-by: Krasimir Georgiev <krasimir@google.com>

Author: dabanki

rust/private/rustc.bzl

@@ -836,7 +836,10 @@ def collect_inputs(
 
 def _will_emit_object_file(emit):
     for e in emit:
-        if e == "obj" or e.startswith("obj="):
+        if type(e) in ["tuple", "list"] and len(e) == 2:
+            if e[0] == "obj":
+                return True
+        elif type(e) == "string" and (e == "obj" or e.startswith("obj=")):
             return True
     return False
 
@@ -1175,6 +1178,10 @@ def construct_arguments(
     for kind in emit:
         if kind == "link" and crate_info.type == "bin" and crate_info.output != None:
             rustc_flags.add(crate_info.output, format = "--emit=link=%s")
+        elif type(kind) in ["tuple", "list"] and len(kind) == 2:
+            # 'kind' is a (string, File) tuple/list. Passing the File object directly to
+            # Args.add allows Bazel to perform path mapping on the path.
+            rustc_flags.add(kind[1], format = "--emit=" + kind[0] + "=%s")
         else:
             emit_without_paths.append(kind)
 
@@ -1565,6 +1572,23 @@ def rustc_compile_action(
     if experimental_use_cc_common_link:
         emit = ["obj"]
 
+    # Declares the outputs of the rustc compile action.
+    # By default this is the binary output; if cc_common.link is used, this is
+    # the main `.o` file (`output_o` below).
+    outputs = [crate_info.output]
+
+    # The `.o` output file, only used for linking via cc_common.link.
+    # When output_hash is set (e.g. for rust_test targets), include it in the
+    # filename to avoid collisions with other targets sharing the same crate name.
+    output_o = None
+    if "obj" in emit:
+        obj_ext = ".o"
+        obj_basename = crate_info.name + ("-%s" % output_hash if output_hash else "")
+        output_o = ctx.actions.declare_file(obj_basename + obj_ext, sibling = crate_info.output)
+        outputs = [output_o]
+        emit.remove("obj")
+        emit.append(("obj", output_o))
+
     # Determine whether to pass `--require-explicit-unstable-features true` to the process wrapper:
     require_explicit_unstable_features = False
     if hasattr(ctx.attr, "require_explicit_unstable_features"):
@@ -1639,21 +1663,6 @@ def rustc_compile_action(
     else:
         formatted_version = ""
 
-    # Declares the outputs of the rustc compile action.
-    # By default this is the binary output; if cc_common.link is used, this is
-    # the main `.o` file (`output_o` below).
-    outputs = [crate_info.output]
-
-    # The `.o` output file, only used for linking via cc_common.link.
-    # When output_hash is set (e.g. for rust_test targets), include it in the
-    # filename to avoid collisions with other targets sharing the same crate name.
-    output_o = None
-    if experimental_use_cc_common_link:
-        obj_ext = ".o"
-        obj_basename = crate_info.name + ("-%s" % output_hash if output_hash else "")
-        output_o = ctx.actions.declare_file(obj_basename + obj_ext, sibling = crate_info.output)
-        outputs = [output_o]
-
     # For a cdylib that might be added as a dependency to a cc_* target on Windows, it is important to include the
     # interface library that rustc generates in the output files.
     interface_library = None

rust/toolchain.bzl

@@ -645,7 +645,7 @@ def _rust_toolchain_impl(ctx):
         sysroot_anchor = sysroot.sysroot_anchor,
         sysroot_short_path = sysroot_short_path,
         target_arch = target_arch,
-        target_flag_value = target_json.path if target_json else target_triple.str,
+        target_flag_value = target_json if target_json else target_triple.str,
         target_json = target_json,
         target_os = target_os,
         target_abi = target_abi,

test/unit/toolchain/toolchain_test.bzl

@@ -30,8 +30,10 @@ def _toolchain_specifies_target_json_test_impl(ctx):
     asserts.equals(env, expected_basename, toolchain_info.target_json.basename)
 
     # The value is expected to be to a generated file in bazel-out.
-    asserts.true(env, toolchain_info.target_flag_value.startswith("bazel-out/"))
-    asserts.true(env, toolchain_info.target_flag_value.endswith("/bin/{}/{}".format(ctx.label.package, expected_basename)))
+    asserts.equals(env, "File", type(toolchain_info.target_flag_value))
+    target_path = toolchain_info.target_flag_value.path
+    asserts.true(env, target_path.startswith("bazel-out/"))
+    asserts.true(env, target_path.endswith("/bin/{}/{}".format(ctx.label.package, expected_basename)))
 
     return analysistest.end(env)