Fix failing tests

Signed-off-by: Thomas Lam <thomaslam@canva.com>

Author: lamcw

crate_universe/src/rendering.rs

@@ -2044,8 +2044,10 @@ mod test {
         assert!(found);
     }
 
-    /// Tests a situation where we identical aliases to the crate's name on the
-    /// package's deps
+    /// Tests a situation where we have identical aliases to the crate's name on
+    /// the package's deps, and the dep is itself a workspace member.  Because
+    /// workspace-member deps have no spoke repo and no override_targets["lib"]
+    /// is set, no hub alias should be emitted at all.
     #[test]
     fn crate_with_ambiguous_rename() {
         let mut context = Context::default();
@@ -2095,54 +2097,12 @@ mod test {
         let build_file_content = output.get(&PathBuf::from("BUILD.bazel")).unwrap();
 
         println!("{build_file_content}");
-        let expected = indoc! {r#"
-            ###############################################################################
-            # @generated
-            # DO NOT MODIFY: This file is auto-generated by a crate_universe tool. To
-            # regenerate this file, run the following:
-            #
-            #     cargo_bazel_regen_command
-            ###############################################################################
-
-            package(default_visibility = ["//visibility:public"])
-
-            exports_files(
-                [
-                    "cargo-bazel.json",
-                    "defs.bzl",
-                ] + glob(
-                    allow_empty = True,
-                    include = ["*.bazel"],
-                ),
-            )
-
-            filegroup(
-                name = "srcs",
-                srcs = glob(
-                    allow_empty = True,
-                    include = [
-                        "*.bazel",
-                        "*.bzl",
-                    ],
-                ),
-            )
-
-            # Workspace Member Dependencies
-            alias(
-                name = "mock_crate-0.1.0",
-                actual = "@test_rendering__mock_crate-0.1.0//:library_name",
-                tags = ["manual"],
-            )
-
-            alias(
-                name = "mock_crate",
-                actual = "@test_rendering__mock_crate-0.1.0//:library_name",
-                tags = ["manual"],
-            )
-        "#};
-        assert!(build_file_content
-            .replace(' ', "")
-            .contains(&expected.replace(' ', "")));
+        // mock_crate is a workspace member dep with no override_targets["lib"],
+        // so no hub alias should be emitted to avoid dangling spoke-repo refs.
+        assert!(
+            !build_file_content.contains("alias("),
+            "no alias should be emitted for workspace member dep with ambiguous rename and no override:\n{build_file_content}"
+        );
     }
 
     /// Tests a situation where there are two dependencies referencing the same