Support toolchain-driven unused dependencies checking (Starlark changes)

Author: JonathanPerry651

java/common/java_semantics.bzl

@@ -128,5 +128,6 @@ semantics = struct(
     update_args_for_import_deps = _update_args_for_import_deps,
     expand_javacopts_make_variables = True,
     java_toolchain_supports_one_version = _bazel_version_ge("8.0.0"),  # can be dropped once we no longer support Bazel 7
+    create_compilation_action_supports_extra_args = _bazel_version_ge("10.0.0-pre"),
     TEST_SUITE_PROPERTY_NAME = "bazel.test_suite",
 )

java/common/rules/java_package_configuration.bzl

@@ -28,6 +28,7 @@ JavaPackageConfigurationInfo = provider(
         "matches",
         "package_specs",
         "system",
+        "unused_deps",
     ],
 )
 
@@ -50,6 +51,7 @@ def _rule_impl(ctx):
             matches = _matches,
             package_specs = package_specs,
             system = system,
+            unused_deps = ctx.attr.unused_deps,
         ),
     ]
 
@@ -116,6 +118,13 @@ The list of files needed by this configuration at runtime.
             providers = [BootClassPathInfo],
             doc = """
 Corresponds to javac's --system flag.
+""",
+        ),
+        "unused_deps": attr.string(
+            default = "off",
+            values = ["off", "error"],
+            doc = """
+Unused dependencies checking mode.
 """,
         ),
         # buildifier: disable=attr-licenses

java/private/java_common_internal.bzl

@@ -20,6 +20,7 @@ load("//java/common/rules:java_helper.bzl", "helper")
 load("//java/common/rules:java_toolchain.bzl", "JavaToolchainInfo")
 load(
     ":java_info.bzl",
+    "JavaInfo",
     "JavaPluginInfo",
     "disable_plugin_info_annotation_processing",
     "java_info_for_compilation",
@@ -165,7 +166,8 @@ def compile(
         include_compilation_info = True,
         classpath_resources = [],
         resource_jars = [],
-        injecting_rule_kind = None):
+        injecting_rule_kind = None,
+        extra_args = []):
     """Compiles Java source files/jars from the implementation of a Starlark rule
 
     The result is a provider that represents the results of the compilation and can be added to the
@@ -215,6 +217,7 @@ def compile(
         add_exports: ([str]) Allow this library to access the given <module>/<package>. Optional.
         add_opens: ([str]) Allow this library to reflectively access the given <module>/<package>.
              Optional.
+        extra_args: (list[Args]) Additional args to pass to JavaBuilder. Optional.
 
     Returns:
         (JavaInfo)
@@ -314,6 +317,32 @@ def compile(
     if uses_annotation_processing:
         generated_class_jar = _derive_output_file(ctx, output, name_suffix = "-gen")
         generated_source_jar = _derive_output_file(ctx, output, name_suffix = "-gensrc")
+
+    extra_args_list = list(extra_args)
+    if semantics.create_compilation_action_supports_extra_args:
+        repo_name = ctx.label.repo_name if hasattr(ctx.label, "repo_name") else ctx.label.workspace_name
+        if not repo_name:
+            resolved_unused_deps_mode = "off"
+            for package_config in java_toolchain._package_configuration:
+                if package_config.matches(package_config.package_specs, ctx.label):
+                    if hasattr(package_config, "unused_deps"):
+                        resolved_unused_deps_mode = package_config.unused_deps
+
+            if resolved_unused_deps_mode == "error" and hasattr(ctx.attr, "deps"):
+                unused_deps_args = ctx.actions.args()
+                for dep in ctx.attr.deps:
+                    if JavaInfo in dep:
+                        if hasattr(dep[JavaInfo], "java_outputs"):
+                            for output_info in dep[JavaInfo].java_outputs:
+                                dep_compile_jar = output_info.compile_jar if output_info.compile_jar else output_info.class_jar
+                                if dep_compile_jar:
+                                    unused_deps_args.add("--declared_dep", dep_compile_jar, format = "%s::" + str(dep.label))
+                extra_args_list.append(unused_deps_args)
+
+    extra_compilation_action_args = {}
+    if semantics.create_compilation_action_supports_extra_args:
+        extra_compilation_action_args["extra_args"] = extra_args_list
+
     get_internal_java_common().create_compilation_action(
         ctx,
         java_toolchain,
@@ -343,6 +372,7 @@ def compile(
         enable_direct_classpath,
         annotation_processor_additional_inputs,
         annotation_processor_additional_outputs,
+        **extra_compilation_action_args
     )
 
     create_output_source_jar = len(source_files) > 0 or source_jars != [output_source_jar]

test/java/toolchains/java_toolchain_tests.bzl

@@ -11,6 +11,7 @@ load("//test/java/testutil:java_info_subject.bzl", "java_info_subject")
 load("//test/java/testutil:java_toolchain_info_subject.bzl", "java_toolchain_info_subject")
 load("//test/java/testutil:javac_action_subject.bzl", "javac_action_subject")
 load("//test/java/testutil:mock_java_toolchain.bzl", "mock_java_toolchain")
+load("//java/common/rules:java_package_configuration.bzl", "JavaPackageConfigurationInfo", "java_package_configuration")
 load("//toolchains:java_toolchain_alias.bzl", "java_toolchain_alias")
 
 def _test_javac_gets_options(name):
@@ -744,6 +745,39 @@ def _test_default_javac_opts_impl(env, target):
         "6",
     ]).in_order()
 
+def _test_java_package_configuration_unused_deps(name):
+    util.helper_target(
+        java_package_configuration,
+        name = name + "/pkg_config",
+        unused_deps = "error",
+    )
+
+    analysis_test(
+        name = name,
+        impl = _test_java_package_configuration_unused_deps_impl,
+        target = name + "/pkg_config",
+    )
+
+def _test_java_package_configuration_unused_deps_impl(env, target):
+    info = target[JavaPackageConfigurationInfo]
+    env.expect.that_str(info.unused_deps).equals("error")
+
+def _test_java_package_configuration_default_unused_deps(name):
+    util.helper_target(
+        java_package_configuration,
+        name = name + "/pkg_config_default",
+    )
+
+    analysis_test(
+        name = name,
+        impl = _test_java_package_configuration_default_unused_deps_impl,
+        target = name + "/pkg_config_default",
+    )
+
+def _test_java_package_configuration_default_unused_deps_impl(env, target):
+    info = target[JavaPackageConfigurationInfo]
+    env.expect.that_str(info.unused_deps).equals("off")
+
 def java_toolchain_tests(name):
     test_suite(
         name = name,
@@ -772,5 +806,7 @@ def java_toolchain_tests(name):
             _test_java_toolchain_flag_set,
             _test_default_javac_opts_depset,
             _test_default_javac_opts,
+            _test_java_package_configuration_unused_deps,
+            _test_java_package_configuration_default_unused_deps,
         ],
     )