Skip to content

Commit fc721cc

Browse files
committed
Address review feedback (#4485)
- Drop is_nvidia_nouveau() helper. It is not called anywhere yet; can be re-added when a consumer lands. - Collapse the Sway+Nvidia confirmation result handling into a single expression now that allow_skip=False guarantees a boolean answer.
1 parent 40cbc30 commit fc721cc

2 files changed

Lines changed: 1 addition & 13 deletions

File tree

archinstall/lib/hardware.py

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -81,17 +81,6 @@ def is_nvidia_proprietary(self) -> bool:
8181
case _:
8282
return False
8383

84-
def is_nvidia_nouveau(self) -> bool:
85-
"""
86-
True for the open-source nouveau driver (Mesa) for Nvidia GPUs.
87-
Currently only NvidiaOpenSource. Officially supported by Sway.
88-
"""
89-
match self:
90-
case GfxDriver.NvidiaOpenSource:
91-
return True
92-
case _:
93-
return False
94-
9584
def packages_text(self) -> str:
9685
pkg_names = [p.value for p in self.gfx_packages()]
9786
text = tr('Installed packages') + ':\n'

archinstall/lib/profile/profile_menu.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -105,8 +105,7 @@ async def _select_gfx_driver(self, preset: GfxDriver | None = None) -> GfxDriver
105105
preset=False,
106106
).show()
107107

108-
if not result.get_value():
109-
return preset
108+
return driver if result.get_value() else preset
110109

111110
return driver
112111

0 commit comments

Comments
 (0)