Skip to content

Commit e8fd1de

Browse files
authored
Avoid using generics with EditMenu (#3415)
This is a follow-up to commit 0de90bd.
1 parent 437bb9c commit e8fd1de

8 files changed

Lines changed: 16 additions & 16 deletions

File tree

archinstall/lib/disk/partitioning_menu.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -509,7 +509,7 @@ def validate(value: str) -> str | None:
509509

510510
title = str(_('Size (default: {}): ')).format(max_size.format_highest())
511511

512-
result = EditMenu[str](
512+
result = EditMenu(
513513
title,
514514
header=f'{prompt}\b',
515515
allow_skip=True,

archinstall/lib/disk/subvolume_menu.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ def selected_action_display(self, selection: SubvolumeModification) -> str:
4141
return str(selection.name)
4242

4343
def _add_subvolume(self, preset: SubvolumeModification | None = None) -> SubvolumeModification | None:
44-
result = EditMenu[str](
44+
result = EditMenu(
4545
str(_('Subvolume name')),
4646
alignment=Alignment.CENTER,
4747
allow_skip=True,

archinstall/lib/interactions/general_conf.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,7 @@ def ask_ntp(preset: bool = True) -> bool:
6161

6262

6363
def ask_hostname(preset: str | None = None) -> str | None:
64-
result = EditMenu[str](
64+
result = EditMenu(
6565
str(_('Hostname')),
6666
alignment=Alignment.CENTER,
6767
allow_skip=True,
@@ -255,7 +255,7 @@ def validator(s: str) -> str | None:
255255

256256
return str(_('Invalid download number'))
257257

258-
result = EditMenu[str](
258+
result = EditMenu(
259259
str(_('Number downloads')),
260260
header=header,
261261
allow_skip=True,

archinstall/lib/interactions/manage_users_conf.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,7 @@ def _check_for_correct_username(self, username: str) -> str | None:
7070
return str(_("The username you entered is invalid"))
7171

7272
def _add_user(self) -> User | None:
73-
editResult = EditMenu[str](
73+
editResult = EditMenu(
7474
str(_('Username')),
7575
allow_skip=True,
7676
validator=self._check_for_correct_username

archinstall/lib/interactions/network_menu.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -106,7 +106,7 @@ def validator(ip: str) -> str | None:
106106
except ValueError:
107107
return str(_('You need to enter a valid IP in IP-config mode'))
108108

109-
result = EditMenu[str](
109+
result = EditMenu(
110110
title,
111111
header=header,
112112
validator=validator,

archinstall/lib/mirrors.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,7 @@ def handle_action(
7474
return data
7575

7676
def _add_custom_repository(self, preset: CustomRepository | None = None) -> CustomRepository | None:
77-
edit_result = EditMenu[str](
77+
edit_result = EditMenu(
7878
str(_('Repository name')),
7979
alignment=Alignment.CENTER,
8080
allow_skip=True,
@@ -91,7 +91,7 @@ def _add_custom_repository(self, preset: CustomRepository | None = None) -> Cust
9191

9292
header = f'{_("Name")}: {name}'
9393

94-
edit_result = EditMenu[str](
94+
edit_result = EditMenu(
9595
str(_('Url')),
9696
header=header,
9797
alignment=Alignment.CENTER,
@@ -196,7 +196,7 @@ def handle_action(
196196
return data
197197

198198
def _add_custom_server(self, preset: CustomServer | None = None) -> CustomServer | None:
199-
edit_result = EditMenu[str](
199+
edit_result = EditMenu(
200200
str(_('Server url')),
201201
alignment=Alignment.CENTER,
202202
allow_skip=True,

archinstall/lib/utils/util.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ def get_password(
3131
elif header is not None:
3232
user_hdr = header
3333

34-
result = EditMenu[str](
34+
result = EditMenu(
3535
text,
3636
header=user_hdr,
3737
alignment=Alignment.CENTER,
@@ -53,7 +53,7 @@ def get_password(
5353
else:
5454
confirmation_header = f'{_("Password")}: {password.hidden()}\n'
5555

56-
result = EditMenu[str](
56+
result = EditMenu(
5757
str(_('Confirm password')),
5858
header=confirmation_header,
5959
alignment=Alignment.CENTER,
@@ -87,7 +87,7 @@ def validate_path(path: str) -> str | None:
8787
else:
8888
validate_func = None
8989

90-
result = EditMenu[str](
90+
result = EditMenu(
9191
text,
9292
header=header,
9393
alignment=Alignment.CENTER,

archinstall/tui/curses_menu.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -455,7 +455,7 @@ def update(
455455
self._main_win.refresh()
456456

457457

458-
class EditMenu[ValueT](AbstractCurses[ValueT]):
458+
class EditMenu(AbstractCurses[str]):
459459
def __init__(
460460
self,
461461
title: str,
@@ -504,7 +504,7 @@ def __init__(
504504

505505
self._init_viewports()
506506

507-
self._last_state: Result[ValueT] | None = None
507+
self._last_state: Result[str] | None = None
508508
self._help_active = False
509509
self._real_input = default_text or ""
510510

@@ -534,7 +534,7 @@ def _init_viewports(self) -> None:
534534
y_offset += 3
535535
self._info_vp = Viewport(self._max_width, 1, 0, y_offset, alignment=self._alignment)
536536

537-
def input(self) -> Result[ValueT]:
537+
def input(self) -> Result[str]:
538538
result = Tui.run(self)
539539

540540
assert not result.has_item() or isinstance(result.text(), str)
@@ -591,7 +591,7 @@ def _draw(self) -> None:
591591
self._input_vp.edit(default_text=self._default_text)
592592

593593
@override
594-
def kickoff(self, win: curses.window) -> Result[ValueT]:
594+
def kickoff(self, win: curses.window) -> Result[str]:
595595
try:
596596
self._draw()
597597
except KeyboardInterrupt:

0 commit comments

Comments
 (0)