Skip to content

Commit e245a11

Browse files
authored
Remove return value check for Installer.minimal_installation (#3555)
The minimal_installation method always returns None.
1 parent 48c3f63 commit e245a11

2 files changed

Lines changed: 15 additions & 15 deletions

File tree

archinstall/lib/installer.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -824,7 +824,7 @@ def minimal_installation(
824824
mkinitcpio: bool = True,
825825
hostname: str | None = None,
826826
locale_config: LocaleConfiguration | None = LocaleConfiguration.default(),
827-
):
827+
) -> None:
828828
if self._disk_config.lvm_config:
829829
lvm = 'lvm2'
830830
self.add_additional_packages(lvm)

archinstall/scripts/minimal.py

Lines changed: 14 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -31,25 +31,25 @@ def perform_installation(mountpoint: Path) -> None:
3131
) as installation:
3232
# Strap in the base system, add a boot loader and configure
3333
# some other minor details as specified by this profile and user.
34-
if installation.minimal_installation():
35-
installation.set_hostname('minimal-arch')
36-
installation.add_bootloader(Bootloader.Systemd)
34+
installation.minimal_installation()
35+
installation.set_hostname('minimal-arch')
36+
installation.add_bootloader(Bootloader.Systemd)
3737

38-
network_config = config.network_config
38+
network_config = config.network_config
3939

40-
if network_config:
41-
network_config.install_network_config(
42-
installation,
43-
config.profile_config,
44-
)
40+
if network_config:
41+
network_config.install_network_config(
42+
installation,
43+
config.profile_config,
44+
)
4545

46-
installation.add_additional_packages(['nano', 'wget', 'git'])
46+
installation.add_additional_packages(['nano', 'wget', 'git'])
4747

48-
profile_config = ProfileConfiguration(MinimalProfile())
49-
profile_handler.install_profile_config(installation, profile_config)
48+
profile_config = ProfileConfiguration(MinimalProfile())
49+
profile_handler.install_profile_config(installation, profile_config)
5050

51-
user = User('devel', Password(plaintext='devel'), False)
52-
installation.create_users(user)
51+
user = User('devel', Password(plaintext='devel'), False)
52+
installation.create_users(user)
5353

5454
# Once this is done, we output some useful information to the user
5555
# And the installation is complete.

0 commit comments

Comments
 (0)