Hi,
Really liking the service and library so far.
I have a few improvements to suggest:
- The try/catch & log on line 50 of
api.js is not very useful to the caller of the function.
- It feels like as the caller, I cannot handle the error and decide what to do. I think you should just throw the error. Or at least return
false.
- There are also logs that we may not even want to be logged in our app (we have a custom logger). So Ideally, this library would not log anything, but would either return some success object or error. Which we can handle and log as appropriate.
- You guys are using
axiosRetry. I would add the retry attempts as a parameter so we can control this. i.e if we only wanted to check when the app first opens.
- Typescript support
Hi,
Really liking the service and library so far.
I have a few improvements to suggest:
api.jsis not very useful to the caller of the function.false.axiosRetry. I would add the retry attempts as a parameter so we can control this. i.e if we only wanted to check when the app first opens.